[Freeciv-Dev] [patch #4893] Make requirement types that check unit state possible
Update of patch #4893 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4893 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4893] Make requirement types that check unit state possible
URL: http://gna.org/patch/?4893 Summary: Make requirement types that check unit state possible Project: Freeciv Submitted by: sveinung Submitted on: Wed 02 Jul 2014 08:47:39 PM UTC Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: sveinung Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Forward unit to is_req_active(), the requirement evaluation function. No new requirement type is added. The unit argument can't replace the unit type argument since some users don't have a specific unit in mind. Related to patch #4671. Posted separately since: - it can be used for many requirement types (like tile nativity, veteran level, hi, mp etc) - it adds noise to the requirement type patch - most of the effort when running git rebase is in it ___ File Attachments: --- Date: Wed 02 Jul 2014 08:47:39 PM UTC Name: 0001-Make-requirement-types-that-check-unit-state-possibl.patch Size: 42kB By: sveinung http://gna.org/patch/download.php?file_id=21246 ___ Reply to this item at: http://gna.org/patch/?4893 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4893] Make requirement types that check unit state possible
Follow-up Comment #1, patch #4893 (project freeciv): This looks like it is only an API change. Would it make sense to add a preface in is_req_active that sets target_unittype in the event that target_unit != NULL target_unittype == NULL? If not, perhaps at least a sanity assertion that unit_type(target_unit) == target_unittype? ___ Reply to this item at: http://gna.org/patch/?4893 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4893] Make requirement types that check unit state possible
Follow-up Comment #2, patch #4893 (project freeciv): _This looks like it is only an API change._ Correct. _Would it make sense to add a preface in is_req_active that sets target_unittype in the event that target_unit != NULL target_unittype == NULL?_ Great idea. Added. (file #21257) ___ Additional Item Attachment: File name: 0001-Make-requirement-types-that-check-unit-state-possibl.patch Size:42 KB ___ Reply to this item at: http://gna.org/patch/?4893 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
