[Freeciv-Dev] [patch #4944] Want techs for direct effect value

2014-07-19 Thread Marko Lindqvist
Update of patch #4944 (project freeciv):

  Status: In Progress = Ready For Test 

___

Follow-up Comment #2:

- Readjusted order of iterations (what is outermost and which innermost) to
make it work so that base_want is calculated only once for each tech/city.
- Fixed handling of !present effect requirements: do not subtract all of
dai_effect_value() (total value of tech) but only the delta it made (value of
the specific effect) See also bug #22363

(file #21464)
___

Additional Item Attachment:

File name: TechEffectWant-2.patch Size:7 KB


___

Reply to this item at:

  http://gna.org/patch/?4944

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4944] Want techs for direct effect value

2014-07-14 Thread Marko Lindqvist
Follow-up Comment #1, patch #4944 (project freeciv):

Base want needs to be moved outside the effects iteration loop - it currently
adds it once for each effect provided by the tech, i.e., base want is
multiplied by the number of effects. Still, for performance reasons, even base
want should not be calculated for techs that provide no direct effects at all
(great majority of techs in supplied rulesets) - that's why tech effects cache
was added in the first place.

___

Reply to this item at:

  http://gna.org/patch/?4944

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4944] Want techs for direct effect value

2014-07-13 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?4944

 Summary: Want techs for direct effect value
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 14 Jul 2014 03:42:39 AM EEST
Category: ai
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

Add tech want for direct effects the tech enables.

In classic ruleset this should affect at least want for Mysticism (when Temple
already built), Electricity (when Colosseum already built), Theology 
Communism (when Cathedral or Michelangelo's Chapel already built). Alien
ruleset should benefit more, as well as some custom rulesets.



___

File Attachments:


---
Date: Mon 14 Jul 2014 03:42:39 AM EEST  Name: TechEffectWant.patch  Size: 8kB 
 By: cazfi

http://gna.org/patch/download.php?file_id=21408

___

Reply to this item at:

  http://gna.org/patch/?4944

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev