[Freeciv-Dev] [patch #6168] Action enabler control for Clean Pollution and Clean Fallout

[Sveinung Kvilhaugsvik]

Update of patch #6168 (project freeciv):

  Depends on: => patch #5085


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6168] Action enabler control for Clean Pollution and Clean Fallout

[Marko Lindqvist]

Follow-up Comment #7, patch #6168 (project freeciv):

Might be a good idea to handle patch #5085 to merge CleanPollution and
CleanFallout first, to reduce amount of work needed here.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6168] Action enabler control for Clean Pollution and Clean Fallout

[Sveinung Kvilhaugsvik]

Follow-up Comment #5, patch #6168 (project freeciv):

_The problem without it was that unit approaching cleanable tile got the
action dialog popping up._
This is a bug. The only time a tile targeted action is supposed to make the
action selection dialog pop up is when the tile already has a target city or
target unit.

___

Reply to this item at:

  http://gna.org/patch/?6168

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6168] Action enabler control for Clean Pollution and Clean Fallout

[Sveinung Kvilhaugsvik]

Update of patch #6168 (project freeciv):

 Assigned to:None = sveinung   

___

Follow-up Comment #3:

_Could you take this ticket for making the changes such a way that they fit to
your other actions design?_
Yes. Could you please explain the motivation(s) behind user_initiated? Any
other use cases / corner cases I should be aware of?

___

Reply to this item at:

  http://gna.org/patch/?6168

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6168] Action enabler control for Clean Pollution and Clean Fallout

[Marko Lindqvist]

Follow-up Comment #4, patch #6168 (project freeciv):

 Could you please explain the motivation(s) behind user_initiated?

Naming of that variable is necessarily the best. It could also be negated and
called internal - it's an action that should not exist in the UI, but that
freeciv uses internally (just to take advantage of action enablers - ruleset
defined requirements etc) The problem without it was that unit approaching
cleanable tile got the action dialog popping up.

___

Reply to this item at:

  http://gna.org/patch/?6168

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6168] Action enabler control for Clean Pollution and Clean Fallout

[Marko Lindqvist]

Update of patch #6168 (project freeciv):

  Status:  Ready For Test = In Progress

___

Follow-up Comment #2:

Could you take this ticket for making the changes such a way that they fit to
your other actions design?

___

Reply to this item at:

  http://gna.org/patch/?6168

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6168] Action enabler control for Clean Pollution and Clean Fallout

[Sveinung Kvilhaugsvik]

Follow-up Comment #1, patch #6168 (project freeciv):

The Qt client crashes with this patch applied. I assume that it tries to
access the action UI name via setup_menues() before it has been received.

___

Reply to this item at:

  http://gna.org/patch/?6168

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6168] Action enabler control for Clean Pollution and Clean Fallout

[Marko Lindqvist]

URL:
  http://gna.org/patch/?6168

 Summary: Action enabler control for Clean Pollution and Clean
Fallout
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 03 Aug 2015 05:32:39 AM EEST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0

___

Details:

These actions are internal to related activities. The client still requests
changing the unit activity. Server handles this activity change as an action.
Unit will remain in that activity as long as it takes to finish it.




___

File Attachments:


---
Date: Mon 03 Aug 2015 05:32:39 AM EEST  Name: CleanActions.patch  Size: 23kB  
By: cazfi

http://gna.org/patch/download.php?file_id=24741

___

Reply to this item at:

  http://gna.org/patch/?6168

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev