[Freeciv-Dev] [patch #6912] Public FREECIV_HAVE_LIBREADLINE

[Marko Lindqvist]

Follow-up Comment #7, patch #6912 (project freeciv):

Interestingly, I've had no similar problems when testing patch #6932. I
suspect that the relevant difference between these two patches is that patch
#6932 changes name of a macro AC_DEFINEd in configure.ac, while this patch did
it for a macro AC_DEFINEd in a included m4-file.
I'm not yet entirely sure if there's some way autoconf (as a project) expects
us to implement this ourselves (some extra DEPENDENCY variable or similar for
invoking autoheader) or is this autoconf bug/missing feature.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6912] Public FREECIV_HAVE_LIBREADLINE

[Marko Lindqvist]

Follow-up Comment #1, patch #6912 (project freeciv):

While testing this, I've noticed that there's something our rebuilding rules
do not catch. Once this is applied, fc_config.h does not get automatically
regenerated, leading to compilation failures. If one encounters such problems,
'./config.status --recheck' should be enough to force regeneration of
configure produced files.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6912] Public FREECIV_HAVE_LIBREADLINE

[Marko Lindqvist]

Update of patch #6912 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6912] Public FREECIV_HAVE_LIBREADLINE

[Jacob Nevins]

Follow-up Comment #4, patch #6912 (project freeciv):

On my system, trunk compilation is failing in a way that "./config.status
--recheck" doesn't help with:


  CC   console.lo
../../server/console.c: In function 'con_update_prompt':
../../server/console.c:98:5: error: implicit declaration of function
'rl_forced_update_display' [-Werror=implicit-function-declaration]
 rl_forced_update_display();
 ^
../../server/console.c:98:5: error: nested extern declaration of
'rl_forced_update_display' [-Werror=nested-externs]
../../server/console.c: At top level:
cc1: error: unrecognized command line option "-Wno-tautological-compare"
[-Werror]
cc1: all warnings being treated as errors
make[2]: *** [console.lo] Error 1
make[2]: Leaving directory `/home/jtn/src/freeciv/git/btrunk/server'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/jtn/src/freeciv/git/btrunk/server'
make: *** [all-recursive] Error 1


Moving the "#include " later in the file makes it build --
after the next line #including "fcbacktrace.h" is sufficient.

I assume that console.c is not ensuring freeciv_config.h is included in the
correct way; but I don't know what the correct way is.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6912] Public FREECIV_HAVE_LIBREADLINE

[Marko Lindqvist]

Follow-up Comment #5, patch #6912 (project freeciv):

> ensuring freeciv_config.h is included in the correct way;

There should be no need to include freeciv_config.h when fc_config.h is
included.

$ grep -r "FREECIV_HAVE_LIBREADLINE" gen_headers/
gen_headers/freeciv_config.h:#define FREECIV_HAVE_LIBREADLINE 1
gen_headers/fc_config.h:#define FREECIV_HAVE_LIBREADLINE 1

Try running './autogen.sh --no-configure-run' first (to make sure autoheader
has run and regenerated fc_config.h.in template) and './config.status
--recheck' only then.

$ grep -r "FREECIV_HAVE_LIBREADLINE" ../src/gen_headers/fc_config.h.in
#undef FREECIV_HAVE_LIBREADLINE

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6912] Public FREECIV_HAVE_LIBREADLINE

[Jacob Nevins]

Follow-up Comment #6, patch #6912 (project freeciv):

> Try running './autogen.sh --no-configure-run' first (to make 
> sure autoheader has run and regenerated fc_config.h.in template) 
> and './config.status --recheck' only then. 
Yes, that worked. (Should have thought of that.)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6912] Public FREECIV_HAVE_LIBREADLINE

[Marko Lindqvist]

URL:
  

 Summary: Public FREECIV_HAVE_LIBREADLINE
 Project: Freeciv
Submitted by: cazfi
Submitted on: Fri 05 Feb 2016 02:06:05 AM EET
Category: bootstrap
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:

Make HAVE_LIBREADLINE public in freeciv_config.h as FREECIV_HAVE_LIBREADLINE



___

File Attachments:


---
Date: Fri 05 Feb 2016 02:06:05 AM EET  Name: PublicHaveLibreadline.patch 
Size: 9kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev