On Mon, 3 Aug 2015 21:28:15 +0200
win...@genial.ms wrote:
[who knows what the current active unit is?]
Well IGC does not know, it asks (Swing)GUI (which routes that to MapViewer)
I think this is overstating the case. IGC calls getActiveUnit in three
places:
1. saveGame, because the active unit has to go into the saved game
2. doExecuteGotoOrders, where it just saves the current unit so it can
restore it after doing all the automatic moves.
Neither of these cases are involve decision making. The only place
where the result of getActiveUnit is tested at all is:
3. updateActiveUnit, where it merely checks if the current active unit can
still move before looking for the next one.
AFAICT if we wanted to, IGC could just cache the last active unit it set
and eliminate these calls entirely, albeit for very little gain. It does
have to be in the GUI.
OTOH all the actual *decisions* about when the active unit needs
to change are made in the command-level routines in IGC, and end up in
calls to updateActiveUnit. I think my contention that IGC has the
knowledge is solid.
This is not to disagree with your point that MapViewer is a mess and is
probably confusing matters. Also, looking at IGC, I think the code can be
tightened further in a few places... patches underway.
Yes, InfoPanel is mostly passive, but when its called to be informed of
an update it only gets partial information and then does back calling to
grab missing info. The back calling should be deleted.
Agreed.
Well, it needs checking anyway. As said above the view mode changing is
probably
missing some calls to propagate updates.
I am pretty sure IGC is making the required calls, but I am looking for
omissions nonetheless. All I have found so far is places where it
probably makes too many. The suspicion is certainly that something is
getting lost in MapViewer.
[open-needs-media / Media_Needed]
I saw your updates, but they are a bit inconsistent.
Each tracker had already different milestones, openness status and shown
colums, which is irritating. Now one of the art things is a milestone, the
other is open-need media.
Is it possible to make them all more alike the Bugs tracker?
That probably makes sense for the IRs. Low priority task. Next time I am
sick perhaps. FC2-tracker is a different case.
Cheers,
Mike Pope
pgpukmB3C119b.pgp
Description: OpenPGP digital signature
--
___
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers
