Re: [Freedos-kernel] freedos 2039 finddisk regression

2011-04-10 Thread Bart Oldeman
On 24 August 2009 10:25, Rugxulo rugx...@gmail.com wrote:
 On Mon, Aug 24, 2009 at 2:18 PM, Bart
 Oldemanbartolde...@users.sourceforge.net wrote:

 I can't reproduce a regression, although there is a bug with respect to 
 MSDOS:

 FreeDOS kernel build 2038 [version May 16, 2009 compiled May 16 2009]
 Kernel compatibility 7.10 - WATCOMC - FAT32 support

 D:\FREEDOSfinddisk fdos
 no match

 D:\FREEDOSfinddisk FDOS
 echo Match on
 E:

 (i.e. it only works case sensitive!, unlike MSDOS) But this behaviour
 is the same for the FD1.0 kernel and also kernel 2039

 No, that's not the problem. When using Jack Ellis' RDISK (RAM drive)
 it won't find the volume Hallelu-Jah in 2039 whereas 2038 works
 fine. (If you really really want, I can upload my test floppy image
 where I discovered the problem.) In particular, I originally used
 2038pre when making the floppy disk for testing, and when 2038 came
 out I upgraded. And then when 2039 came out, I figured I should
 upgrade again but didn't test again until recently. And at startup it
 immediately tries to jump to RAM disk for my purposes, but definitely
 a regression since it doesn't find it anymore.

I finally had a closer look. What happens is that the int21/11 input
pattern of finddisk gets uppercased to  HALLELU-JAH, and then
case-sensitively compared to the directory entries on the RAM drive.
So it doesn't find it. This is compatible with MSDOS, where finddisk
doesn't find the RAM disk either. (It's very strange to have a mixed
case label as that doesn't match with short-file-name FAT).

Older versions of the FreeDOS kernel (=2038) did not compare
(ignored) the name for the volume label: it was returned no matter
which pattern was given to int21/11 (and 4e). That's why there is
%define BUGGY_FCB 1 in finddisk.asm.

The correct DOS-independent fix would be to change finddisk to search
for the volume label with .???, and then compare the result
with the search term.

Bart

--
Xperia(TM) PLAY
It's a major breakthrough. An authentic gaming
smartphone on the nation's most reliable network.
And it wants your games.
http://p.sf.net/sfu/verizon-sfdev
___
Freedos-kernel mailing list
Freedos-kernel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freedos-kernel


Re: [Freedos-kernel] freedos 2039 finddisk regression

2009-08-30 Thread Rugxulo
Hi,

On Mon, Aug 24, 2009 at 2:18 PM, Bart
Oldemanbartolde...@users.sourceforge.net wrote:

 I can't reproduce a regression, although there is a bug with respect to MSDOS:

 FreeDOS kernel build 2038 [version May 16, 2009 compiled May 16 2009]
 Kernel compatibility 7.10 - WATCOMC - FAT32 support

 D:\FREEDOSfinddisk fdos
 no match

 D:\FREEDOSfinddisk FDOS
 echo Match on
 E:

 (i.e. it only works case sensitive!, unlike MSDOS) But this behaviour
 is the same for the FD1.0 kernel and also kernel 2039

No, that's not the problem. When using Jack Ellis' RDISK (RAM drive)
it won't find the volume Hallelu-Jah in 2039 whereas 2038 works
fine. (If you really really want, I can upload my test floppy image
where I discovered the problem.) In particular, I originally used
2038pre when making the floppy disk for testing, and when 2038 came
out I upgraded. And then when 2039 came out, I figured I should
upgrade again but didn't test again until recently. And at startup it
immediately tries to jump to RAM disk for my purposes, but definitely
a regression since it doesn't find it anymore.

http://johnson.tmfc.net/dos/file/drivers.zip  (RDISK.COM)

--
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
___
Freedos-kernel mailing list
Freedos-kernel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freedos-kernel


Re: [Freedos-kernel] freedos 2039 finddisk regression

2009-08-24 Thread Bart Oldeman
Hi Eric,

I can't reproduce a regression, although there is a bug with respect to MSDOS:

FreeDOS kernel build 2038 [version May 16, 2009 compiled May 16 2009]
Kernel compatibility 7.10 - WATCOMC - FAT32 support

D:\FREEDOSfinddisk fdos
no match

D:\FREEDOSfinddisk FDOS
echo Match on
E:

(i.e. it only works case sensitive!, unlike MSDOS) But this behaviour
is the same for the FD1.0 kernel and also kernel 2039

how to reproduce your exact problem?

cc-ing freedos-kernel as this shouldn't be private.

FYI, There have been quite a few internal changes between 2038 and
2039 (the far fnode removal operation).

Bart

2009/8/24 Eric Auer e.a...@jpberlin.de:

 Hi Bart, Ruxgulo reports a regression problem
 in kernel 2039 with a small piece of software:

 www.auersoft.eu/~auersoft/soft/specials/find-drive-by-label-finddisk.zip

 This software uses int 21.11 - 21.69 - 21.0e
 as notable DOS calls, plus of course the usual
 command line, print stuff, exit to dos stuff.

 Could you have a look at this? Thanks :-)

 Eric

 Hey, small regression in latest 2039 kernel,
    Your finddisk (useful with RDISK, for instance) doesn't work
 anymore. I then reverted to kernel 2038, and it worked again. Weird. I
 honestly didn't expect that (or anything, really) to break with 2039
 as I expected overall changes to be small. Oh well. Also on
 SourceForge I saw a report that Breadbox Ensemble also doesn't work
 with 2039 but 2038 is okay. Strange. Not a huge problem, but still
 weird.

 Just thought you should know.   :-)





--
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
___
Freedos-kernel mailing list
Freedos-kernel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freedos-kernel