Re: [Freedreno] [PATCH 01/34] docs: filesystems: fix references for doc files there
On 2020/4/15 22:32, Mauro Carvalho Chehab wrote: > Several files there were renamed to ReST. Fix the broken > references. > > Signed-off-by: Mauro Carvalho Chehab > --- > Documentation/ABI/stable/sysfs-devices-node | 2 +- > Documentation/ABI/testing/procfs-smaps_rollup | 2 +- > Documentation/admin-guide/cpu-load.rst| 2 +- > Documentation/admin-guide/nfs/nfsroot.rst | 2 +- > Documentation/driver-api/driver-model/device.rst | 2 +- > Documentation/driver-api/driver-model/overview.rst| 2 +- > Documentation/filesystems/dax.txt | 2 +- > Documentation/filesystems/dnotify.txt | 2 +- > Documentation/filesystems/ramfs-rootfs-initramfs.rst | 2 +- > Documentation/powerpc/firmware-assisted-dump.rst | 2 +- > Documentation/process/adding-syscalls.rst | 2 +- > .../translations/it_IT/process/adding-syscalls.rst| 2 +- > Documentation/translations/zh_CN/filesystems/sysfs.txt| 6 +++--- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 2 +- > fs/Kconfig| 2 +- > fs/Kconfig.binfmt | 2 +- > fs/adfs/Kconfig | 2 +- > fs/affs/Kconfig | 2 +- > fs/afs/Kconfig| 6 +++--- > fs/bfs/Kconfig| 2 +- > fs/cramfs/Kconfig | 2 +- > fs/ecryptfs/Kconfig | 2 +- > fs/fat/Kconfig| 8 > fs/fuse/Kconfig | 2 +- > fs/fuse/dev.c | 2 +- > fs/hfs/Kconfig| 2 +- > fs/hpfs/Kconfig | 2 +- > fs/isofs/Kconfig | 2 +- > fs/namespace.c| 2 +- > fs/notify/inotify/Kconfig | 2 +- > fs/ntfs/Kconfig | 2 +- > fs/ocfs2/Kconfig | 2 +- For ocfs2 part, Acked-by: Joseph Qi > fs/overlayfs/Kconfig | 6 +++--- > fs/proc/Kconfig | 4 ++-- > fs/romfs/Kconfig | 2 +- > fs/sysfs/dir.c| 2 +- > fs/sysfs/file.c | 2 +- > fs/sysfs/mount.c | 2 +- > fs/sysfs/symlink.c| 2 +- > fs/sysv/Kconfig | 2 +- > fs/udf/Kconfig| 2 +- > include/linux/relay.h | 2 +- > include/linux/sysfs.h | 2 +- > kernel/relay.c| 2 +- > 44 files changed, 54 insertions(+), 54 deletions(-) > > diff --git a/Documentation/ABI/stable/sysfs-devices-node > b/Documentation/ABI/stable/sysfs-devices-node > index df8413cf1468..484fc04bcc25 100644 > --- a/Documentation/ABI/stable/sysfs-devices-node > +++ b/Documentation/ABI/stable/sysfs-devices-node > @@ -54,7 +54,7 @@ Date: October 2002 > Contact: Linux Memory Management list > Description: > Provides information about the node's distribution and memory > - utilization. Similar to /proc/meminfo, see > Documentation/filesystems/proc.txt > + utilization. Similar to /proc/meminfo, see > Documentation/filesystems/proc.rst > > What:/sys/devices/system/node/nodeX/numastat > Date:October 2002 > diff --git a/Documentation/ABI/testing/procfs-smaps_rollup > b/Documentation/ABI/testing/procfs-smaps_rollup > index 274df44d8b1b..046978193368 100644 > --- a/Documentation/ABI/testing/procfs-smaps_rollup > +++ b/Documentation/ABI/testing/procfs-smaps_rollup > @@ -11,7 +11,7 @@ Description: > Additionally, the fields Pss_Anon, Pss_File and Pss_Shmem > are not present in /proc/pid/smaps. These fields represent > the sum of the Pss field of each type (anon, file, shmem). > - For more details, see Documentation/filesystems/proc.txt > + For more details, see Documentation/filesystems/proc.rst > and the procfs man page. > > Typical output looks like this: > diff --git a/Documentation/admin-guide/cpu-load.rst > b/Documentation/admin-guide/cpu-load.rst > index 2d01ce43d2a2..ebdecf864080 100644 > --- a/Documentation/admin-guide/cpu-load.rst > +++ b/Documentation/adm
Re: [Freedreno] [PATCH v7 2/2] drm/panel: add support for rm69299 visionox panel driver
Hi, checkpatch finds multiple errors with this patch, as Sam reported on https://patchwork.kernel.org/cover/11461945/. Please fix those and send a new version (not sure which version number this should be (v11?), this series is a bit confusing in this aspect). Please also double check if there is any outstanding feedback that still needs to be addressed (not from my side AFAIK). Thanks Matthias On Mon, Mar 16, 2020 at 09:46:47AM +0530, Harigovindan P wrote: > Add support for Visionox panel driver. > > Signed-off-by: Harigovindan P > --- > > Changes in v2: > - Dropping redundant space in Kconfig(Sam Ravnborg). > - Changing structure for include files(Sam Ravnborg). > - Removing backlight related code and functions(Sam Ravnborg). > - Removing repeated printing of error message(Sam Ravnborg). > - Adding drm_connector as an argument for get_modes function. > Changes in v3: > - Adding arguments for drm_panel_init to support against mainline. > Changes in v4: > - Removing error messages from regulator_set_load. > - Removing dev struct entry. > - Removing checks. > - Dropping empty comment lines. > Changes in v5: > - Removing unused struct member variables. > - Removing blank lines. > - Fixed indentation. > - Invoking dsi_detach and panel_remove while early exiting from probe. > Changes in v6: > - Changed "35597" to "rm69299" for power_on function. > - Removing rm69299_config since it supports single type of panel for > now. > - Fixed alignment. > - Using goto statements when regulator_set_load fails. > Changes in v7: > - Added new goto statement when regulator_set_load fails. > > drivers/gpu/drm/panel/Kconfig | 8 + > drivers/gpu/drm/panel/Makefile| 1 + > .../gpu/drm/panel/panel-visionox-rm69299.c| 295 ++ > 3 files changed, 304 insertions(+) > create mode 100644 drivers/gpu/drm/panel/panel-visionox-rm69299.c > > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig > index ae44ac2ec106..7b696f304a99 100644 > --- a/drivers/gpu/drm/panel/Kconfig > +++ b/drivers/gpu/drm/panel/Kconfig > @@ -389,6 +389,14 @@ config DRM_PANEL_TRULY_NT35597_WQXGA > Say Y here if you want to enable support for Truly NT35597 WQXGA Dual > DSI > Video Mode panel > > +config DRM_PANEL_VISIONOX_RM69299 > + tristate "Visionox RM69299" > + depends on OF > + depends on DRM_MIPI_DSI > + help > + Say Y here if you want to enable support for Visionox > + RM69299 DSI Video Mode panel. > + > config DRM_PANEL_XINPENG_XPP055C272 > tristate "Xinpeng XPP055C272 panel driver" > depends on OF > diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile > index 7c4d3c581fd4..9f11d067a6b2 100644 > --- a/drivers/gpu/drm/panel/Makefile > +++ b/drivers/gpu/drm/panel/Makefile > @@ -41,4 +41,5 @@ obj-$(CONFIG_DRM_PANEL_TPO_TD028TTEC1) += > panel-tpo-td028ttec1.o > obj-$(CONFIG_DRM_PANEL_TPO_TD043MTEA1) += panel-tpo-td043mtea1.o > obj-$(CONFIG_DRM_PANEL_TPO_TPG110) += panel-tpo-tpg110.o > obj-$(CONFIG_DRM_PANEL_TRULY_NT35597_WQXGA) += panel-truly-nt35597.o > +obj-$(CONFIG_DRM_PANEL_VISIONOX_RM69299) += panel-visionox-rm69299.o > obj-$(CONFIG_DRM_PANEL_XINPENG_XPP055C272) += panel-xinpeng-xpp055c272.o > diff --git a/drivers/gpu/drm/panel/panel-visionox-rm69299.c > b/drivers/gpu/drm/panel/panel-visionox-rm69299.c > new file mode 100644 > index ..0f877d21fdf2 > --- /dev/null > +++ b/drivers/gpu/drm/panel/panel-visionox-rm69299.c > @@ -0,0 +1,295 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (c) 2019, The Linux Foundation. All rights reserved. > + */ > + > +#include > +#include > +#include > +#include > +#include > + > +#include > + > +#include > +#include > +#include > +#include > + > +struct visionox_rm69299 { > + struct drm_panel panel; > + struct regulator_bulk_data supplies[2]; > + struct gpio_desc *reset_gpio; > + struct mipi_dsi_device *dsi; > + bool prepared; > + bool enabled; > +}; > + > +static inline struct visionox_rm69299 *panel_to_ctx(struct drm_panel *panel) > +{ > + return container_of(panel, struct visionox_rm69299, panel); > +} > + > +static int visionox_rm69299_power_on(struct visionox_rm69299 *ctx) > +{ > + int ret; > + > + ret = regulator_bulk_enable(ARRAY_SIZE(ctx->supplies), ctx->supplies); > + if (ret < 0) > + return ret; > + > + /* > + * Reset sequence of visionox panel requires the panel to be > + * out of reset for 10ms, followed by being held in reset > + * for 10ms and then out again > + */ > + gpiod_set_value(ctx->reset_gpio, 1); > + usleep_range(1, 2); > + gpiod_set_value(ctx->reset_gpio, 0); > + usleep_range(1, 2); > + gpiod_set_value(ctx->reset_gpio, 1); > + usleep_range(1, 2); > + > +
Re: [Freedreno] [PATCH 1/2] dt-bindings: msm: disp: Add Display Port HPD GPIO bindings
On Tue, Apr 07, 2020 at 03:48:28PM -0700, Tanmay Shah wrote: > Add Display Port HPD GPIO description in bindings > > This Patch depends on: > https://patchwork.kernel.org/patch/11468505/ This belongs below the '---' and probably means you should send all this as one series. > > Signed-off-by: Tanmay Shah > --- > Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml > b/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml > index 761a01d..003f5f7 100644 > --- a/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml > @@ -155,6 +155,11 @@ properties: > data-lanes: > description: Maximum number of lanes that can be used for Display > port. > > + dp-hpd-gpio: We already have a standard property for this. Use it. It belongs in the connector node as HPD is part of the connector. > + maxItems: 1 > + description: Specifies HPD gpio for DP connector without > +USB PHY or AUX switch. > + > usbplug-cc-gpio: Note that this too should be in a connector node. > maxItems: 1 > description: Specifies the usbplug orientation gpio. > @@ -282,6 +287,8 @@ examples: > aux-sel-gpio = <&msmgpio 110 1>; > usbplug-cc-gpio = <&msmgpio 90 1>; > > +dp-hpd-gpio = <&msmgpio 117 0>; > + > ports { > #address-cells = <1>; > #size-cells = <0>; > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno
[Freedreno] [PATCH 01/34] docs: filesystems: fix references for doc files there
Several files there were renamed to ReST. Fix the broken references. Signed-off-by: Mauro Carvalho Chehab --- Documentation/ABI/stable/sysfs-devices-node | 2 +- Documentation/ABI/testing/procfs-smaps_rollup | 2 +- Documentation/admin-guide/cpu-load.rst| 2 +- Documentation/admin-guide/nfs/nfsroot.rst | 2 +- Documentation/driver-api/driver-model/device.rst | 2 +- Documentation/driver-api/driver-model/overview.rst| 2 +- Documentation/filesystems/dax.txt | 2 +- Documentation/filesystems/dnotify.txt | 2 +- Documentation/filesystems/ramfs-rootfs-initramfs.rst | 2 +- Documentation/powerpc/firmware-assisted-dump.rst | 2 +- Documentation/process/adding-syscalls.rst | 2 +- .../translations/it_IT/process/adding-syscalls.rst| 2 +- Documentation/translations/zh_CN/filesystems/sysfs.txt| 6 +++--- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 2 +- fs/Kconfig| 2 +- fs/Kconfig.binfmt | 2 +- fs/adfs/Kconfig | 2 +- fs/affs/Kconfig | 2 +- fs/afs/Kconfig| 6 +++--- fs/bfs/Kconfig| 2 +- fs/cramfs/Kconfig | 2 +- fs/ecryptfs/Kconfig | 2 +- fs/fat/Kconfig| 8 fs/fuse/Kconfig | 2 +- fs/fuse/dev.c | 2 +- fs/hfs/Kconfig| 2 +- fs/hpfs/Kconfig | 2 +- fs/isofs/Kconfig | 2 +- fs/namespace.c| 2 +- fs/notify/inotify/Kconfig | 2 +- fs/ntfs/Kconfig | 2 +- fs/ocfs2/Kconfig | 2 +- fs/overlayfs/Kconfig | 6 +++--- fs/proc/Kconfig | 4 ++-- fs/romfs/Kconfig | 2 +- fs/sysfs/dir.c| 2 +- fs/sysfs/file.c | 2 +- fs/sysfs/mount.c | 2 +- fs/sysfs/symlink.c| 2 +- fs/sysv/Kconfig | 2 +- fs/udf/Kconfig| 2 +- include/linux/relay.h | 2 +- include/linux/sysfs.h | 2 +- kernel/relay.c| 2 +- 44 files changed, 54 insertions(+), 54 deletions(-) diff --git a/Documentation/ABI/stable/sysfs-devices-node b/Documentation/ABI/stable/sysfs-devices-node index df8413cf1468..484fc04bcc25 100644 --- a/Documentation/ABI/stable/sysfs-devices-node +++ b/Documentation/ABI/stable/sysfs-devices-node @@ -54,7 +54,7 @@ Date: October 2002 Contact: Linux Memory Management list Description: Provides information about the node's distribution and memory - utilization. Similar to /proc/meminfo, see Documentation/filesystems/proc.txt + utilization. Similar to /proc/meminfo, see Documentation/filesystems/proc.rst What: /sys/devices/system/node/nodeX/numastat Date: October 2002 diff --git a/Documentation/ABI/testing/procfs-smaps_rollup b/Documentation/ABI/testing/procfs-smaps_rollup index 274df44d8b1b..046978193368 100644 --- a/Documentation/ABI/testing/procfs-smaps_rollup +++ b/Documentation/ABI/testing/procfs-smaps_rollup @@ -11,7 +11,7 @@ Description: Additionally, the fields Pss_Anon, Pss_File and Pss_Shmem are not present in /proc/pid/smaps. These fields represent the sum of the Pss field of each type (anon, file, shmem). - For more details, see Documentation/filesystems/proc.txt + For more details, see Documentation/filesystems/proc.rst and the procfs man page. Typical output looks like this: diff --git a/Documentation/admin-guide/cpu-load.rst b/Documentation/admin-guide/cpu-load.rst index 2d01ce43d2a2..ebdecf864080 100644 --- a/Documentation/admin-guide/cpu-load.rst +++ b/Documentation/admin-guide/cpu-load.rst @@ -105,7 +105,7 @@ References -- - http://lkml.org/lkml/2007/2/12/6 -- Documentation/filesystems/proc.txt (1.8) +- Documentation/filesystems/proc.rst (1.8) Thanks diff --git a/Documentation/admin-guide/nfs/nfsroot.rst
[Freedreno] [PATCH 00/34] fs: convert remaining docs to ReST file format
This patch series convert the remaining files under Documentation/filesystems to the ReST file format. It is based on linux-next (next-20200414). PS.: I opted to add mainly ML from the output of get_maintainers.pl to the c/c list of patch 00/34, because otherwise the number of c/c would be too many, with would very likely cause ML servers to reject it. The results of those changes (together with other changes from my pending doc patches) are available at: https://www.infradead.org/~mchehab/kernel_docs/filesystems/index.html Mauro Carvalho Chehab (34): docs: filesystems: fix references for doc files there docs: filesystems: convert caching/object.txt to ReST docs: filesystems: convert caching/fscache.txt to ReST format docs: filesystems: caching/netfs-api.txt: convert it to ReST docs: filesystems: caching/operations.txt: convert it to ReST docs: filesystems: caching/cachefiles.txt: convert to ReST docs: filesystems: caching/backend-api.txt: convert it to ReST docs: filesystems: convert cifs/cifsroot.rst to ReST docs: filesystems: convert configfs.txt to ReST docs: filesystems: convert automount-support.txt to ReST docs: filesystems: convert coda.txt to ReST docs: filesystems: convert dax.txt to ReST docs: filesystems: convert devpts.txt to ReST docs: filesystems: convert dnotify.txt to ReST docs: filesystems: convert fiemap.txt to ReST docs: filesystems: convert files.txt to ReST docs: filesystems: convert fuse-io.txt to ReST docs: filesystems: convert gfs2-glocks.txt to ReST docs: filesystems: convert locks.txt to ReST docs: filesystems: convert mandatory-locking.txt to ReST docs: filesystems: convert mount_api.txt to ReST docs: filesystems: rename path-lookup.txt file docs: filesystems: convert path-walking.txt to ReST docs: filesystems: convert quota.txt to ReST docs: filesystems: convert seq_file.txt to ReST docs: filesystems: convert sharedsubtree.txt to ReST docs: filesystems: split spufs.txt into 3 separate files docs: filesystems: convert spufs/spu_create.txt to ReST docs: filesystems: convert spufs/spufs.txt to ReST docs: filesystems: convert spufs/spu_run.txt to ReST docs: filesystems: convert sysfs-pci.txt to ReST docs: filesystems: convert sysfs-tagging.txt to ReST docs: filesystems: convert xfs-delayed-logging-design.txt to ReST docs: filesystems: convert xfs-self-describing-metadata.txt to ReST Documentation/ABI/stable/sysfs-devices-node |2 +- Documentation/ABI/testing/procfs-smaps_rollup |2 +- Documentation/admin-guide/cpu-load.rst|2 +- Documentation/admin-guide/ext4.rst|2 +- Documentation/admin-guide/nfs/nfsroot.rst |2 +- Documentation/admin-guide/sysctl/kernel.rst |2 +- .../driver-api/driver-model/device.rst|2 +- .../driver-api/driver-model/overview.rst |2 +- ...ount-support.txt => automount-support.rst} | 23 +- .../{backend-api.txt => backend-api.rst} | 165 +- .../{cachefiles.txt => cachefiles.rst}| 139 +- Documentation/filesystems/caching/fscache.rst | 565 ++ Documentation/filesystems/caching/fscache.txt | 448 - Documentation/filesystems/caching/index.rst | 14 + .../caching/{netfs-api.txt => netfs-api.rst} | 172 +- .../caching/{object.txt => object.rst}| 43 +- .../{operations.txt => operations.rst}| 45 +- .../cifs/{cifsroot.txt => cifsroot.rst} | 56 +- Documentation/filesystems/coda.rst| 1670 Documentation/filesystems/coda.txt| 1676 - .../{configfs/configfs.txt => configfs.rst} | 129 +- .../filesystems/{dax.txt => dax.rst} | 11 +- Documentation/filesystems/devpts.rst | 36 + Documentation/filesystems/devpts.txt | 26 - .../filesystems/{dnotify.txt => dnotify.rst} | 13 +- Documentation/filesystems/ext2.rst|2 +- .../filesystems/{fiemap.txt => fiemap.rst}| 133 +- .../filesystems/{files.txt => files.rst} | 15 +- .../filesystems/{fuse-io.txt => fuse-io.rst} |6 + .../{gfs2-glocks.txt => gfs2-glocks.rst} | 147 +- Documentation/filesystems/index.rst | 26 + .../filesystems/{locks.txt => locks.rst} | 14 +- ...tory-locking.txt => mandatory-locking.rst} | 25 +- .../{mount_api.txt => mount_api.rst} | 329 ++-- .../{path-lookup.txt => path-walking.rst} | 88 +- Documentation/filesystems/porting.rst |2 +- Documentation/filesystems/proc.rst|2 +- .../filesystems/{quota.txt => quota.rst} | 41 +- .../filesystems/ramfs-rootfs-initramfs.rst|2 +- .../{seq_file.txt => seq_file.rst}| 61 +- .../{sharedsubtree.txt => sharedsubtree.rst} | 394 ++-- Documentation/filesystems/spufs/index.rst | 13 + .../filesystems/spufs/spu_create.rst | 131 ++ Documentation/filesystems/spufs/spu_run.rst | 138 ++ .../{spufs.txt => spufs/spufs.
Re: [Freedreno] [v2 1/3] drm/msm/dpu: add support for clk and bw scaling for display
Hi Krishna, Thanks for the patch! On 4/2/20 09:52, Krishna Manikandan wrote: > This change adds support to scale src clk and bandwidth as > per composition requirements. > > Interconnect registration for bw has been moved to mdp > device node from mdss to facilitate the scaling. No Signed-off-by ? > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 106 > + > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 5 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 4 + > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c| 37 - > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h| 4 + > drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c | 9 ++- > drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 82 +++ > drivers/gpu/drm/msm/disp/dpu1/dpu_plane.h | 4 + > 8 files changed, 228 insertions(+), 23 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c > b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c [..] > @@ -186,10 +247,21 @@ static int _dpu_core_perf_crtc_update_bus(struct > dpu_kms *kms, > perf.max_per_pipe_ib = max(perf.max_per_pipe_ib, > dpu_cstate->new_perf.max_per_pipe_ib); > > - DPU_DEBUG("crtc=%d bw=%llu\n", tmp_crtc->base.id, > - dpu_cstate->new_perf.bw_ctl); > + perf.bw_ctl += dpu_cstate->new_perf.bw_ctl; > + > + DPU_DEBUG("crtc=%d bw=%llu paths:%d\n", > + tmp_crtc->base.id, > + dpu_cstate->new_perf.bw_ctl, kms->num_paths); > } > } > + > + avg_bw = kms->num_paths ? > + perf.bw_ctl / kms->num_paths : 0; > + > + for (i = 0; i < kms->num_paths; i++) > + icc_set_bw(kms->path[i], > + Bps_to_icc(avg_bw), (perf.max_per_pipe_ib)); In what units is max_per_pipe_ib? Can you use Bps_to_icc() or KBps_to_icc()? > + > return ret; > } > [..] > @@ -1037,8 +1065,15 @@ static int __maybe_unused dpu_runtime_resume(struct > device *dev) > struct drm_encoder *encoder; > struct drm_device *ddev; > struct dss_module_power *mp = &dpu_kms->mp; > + int i; > > ddev = dpu_kms->dev; > + > + /* Min vote of BW is required before turning on AXI clk */ > + for (i = 0; i < dpu_kms->num_paths; i++) > + icc_set_bw(dpu_kms->path[i], 0, > + dpu_kms->catalog->perf.min_dram_ib); Bps_to_icc() ? Thanks, Georgi ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno