Re: [Freedreno] (subset) [PATCH RFC v7 00/10] Support for Solid Fill Planes
On Monday, December 4th, 2023 at 18:51, Abhinav Kumar wrote: > > Where are the IGT and userspace for this uAPI addition? > > Yes, we made IGT changes to test and validate this. We will post them on > the IGT dev list shortly and CC you. > > We do not have a compositor change yet for this as we primarily used IGT > to validate this. Yes, please post the IGT. > Can we re-try to land this once IGT changes are accepted? There will need to be a user-space implementation as well, since this is a hard requirement for new uAPI [1]. Maybe I'll give this a go if I have time. [1]: https://dri.freedesktop.org/docs/drm/gpu/drm-uapi.html#open-source-userspace-requirements
Re: [Freedreno] (subset) [PATCH RFC v7 00/10] Support for Solid Fill Planes
On 12/4/2023 9:57 AM, Simon Ser wrote: On Monday, December 4th, 2023 at 18:51, Abhinav Kumar wrote: Where are the IGT and userspace for this uAPI addition? Yes, we made IGT changes to test and validate this. We will post them on the IGT dev list shortly and CC you. We do not have a compositor change yet for this as we primarily used IGT to validate this. Yes, please post the IGT. Can we re-try to land this once IGT changes are accepted? There will need to be a user-space implementation as well, since this is a hard requirement for new uAPI [1]. Maybe I'll give this a go if I have time. Much appreciated. [1]: https://dri.freedesktop.org/docs/drm/gpu/drm-uapi.html#open-source-userspace-requirements
Re: [Freedreno] (subset) [PATCH RFC v7 00/10] Support for Solid Fill Planes
Hi Simon On 12/3/2023 4:15 AM, Simon Ser wrote: On Saturday, December 2nd, 2023 at 22:41, Dmitry Baryshkov wrote: On Fri, 27 Oct 2023 15:32:50 -0700, Jessica Zhang wrote: Some drivers support hardware that have optimizations for solid fill planes. This series aims to expose these capabilities to userspace as some compositors have a solid fill flag (ex. SOLID_COLOR in the Android hardware composer HAL) that can be set by apps like the Android Gears test app. In order to expose this capability to userspace, this series will: [...] Applied to drm-misc-next, thanks! Where are the IGT and userspace for this uAPI addition? Yes, we made IGT changes to test and validate this. We will post them on the IGT dev list shortly and CC you. We do not have a compositor change yet for this as we primarily used IGT to validate this. Can we re-try to land this once IGT changes are accepted? Thanks Abhinav
Re: [Freedreno] (subset) [PATCH RFC v7 00/10] Support for Solid Fill Planes
On Sun, Dec 03, 2023 at 08:10:31PM +0200, Dmitry Baryshkov wrote: > On Sun, 3 Dec 2023 at 14:15, Simon Ser wrote: > > > > On Saturday, December 2nd, 2023 at 22:41, Dmitry Baryshkov > > wrote: > > > > > On Fri, 27 Oct 2023 15:32:50 -0700, Jessica Zhang wrote: > > > > > > > Some drivers support hardware that have optimizations for solid fill > > > > planes. This series aims to expose these capabilities to userspace as > > > > some compositors have a solid fill flag (ex. SOLID_COLOR in the Android > > > > hardware composer HAL) that can be set by apps like the Android Gears > > > > test app. > > > > > > > > In order to expose this capability to userspace, this series will: > > > > > > > > [...] > > > > > > > > > Applied to drm-misc-next, thanks! > > > > Where are the IGT and userspace for this uAPI addition? > > Indeed. I checked that there are uABI acks/reviews, but I didn't check > these requirements. Frankly speaking, I thought that they were handled > already, before giving the ack. How should we proceed? Should I land a > revert? Yes Maxime signature.asc Description: PGP signature
Re: [Freedreno] (subset) [PATCH RFC v7 00/10] Support for Solid Fill Planes
On Sun, 3 Dec 2023 at 14:15, Simon Ser wrote: > > On Saturday, December 2nd, 2023 at 22:41, Dmitry Baryshkov > wrote: > > > On Fri, 27 Oct 2023 15:32:50 -0700, Jessica Zhang wrote: > > > > > Some drivers support hardware that have optimizations for solid fill > > > planes. This series aims to expose these capabilities to userspace as > > > some compositors have a solid fill flag (ex. SOLID_COLOR in the Android > > > hardware composer HAL) that can be set by apps like the Android Gears > > > test app. > > > > > > In order to expose this capability to userspace, this series will: > > > > > > [...] > > > > > > Applied to drm-misc-next, thanks! > > Where are the IGT and userspace for this uAPI addition? Indeed. I checked that there are uABI acks/reviews, but I didn't check these requirements. Frankly speaking, I thought that they were handled already, before giving the ack. How should we proceed? Should I land a revert? -- With best wishes Dmitry
Re: [Freedreno] (subset) [PATCH RFC v7 00/10] Support for Solid Fill Planes
On Saturday, December 2nd, 2023 at 22:41, Dmitry Baryshkov wrote: > On Fri, 27 Oct 2023 15:32:50 -0700, Jessica Zhang wrote: > > > Some drivers support hardware that have optimizations for solid fill > > planes. This series aims to expose these capabilities to userspace as > > some compositors have a solid fill flag (ex. SOLID_COLOR in the Android > > hardware composer HAL) that can be set by apps like the Android Gears > > test app. > > > > In order to expose this capability to userspace, this series will: > > > > [...] > > > Applied to drm-misc-next, thanks! Where are the IGT and userspace for this uAPI addition?
Re: [Freedreno] (subset) [PATCH RFC v7 00/10] Support for Solid Fill Planes
On Fri, 27 Oct 2023 15:32:50 -0700, Jessica Zhang wrote: > Some drivers support hardware that have optimizations for solid fill > planes. This series aims to expose these capabilities to userspace as > some compositors have a solid fill flag (ex. SOLID_COLOR in the Android > hardware composer HAL) that can be set by apps like the Android Gears > test app. > > In order to expose this capability to userspace, this series will: > > [...] Applied to drm-misc-next, thanks! [01/10] drm: Introduce pixel_source DRM plane property commit: e50e5fed41c7eed2db4119645bf3480ec43fec11 [02/10] drm: Introduce solid fill DRM plane property commit: 85863a4e16e77079ee14865905ddc3ef9483a640 [03/10] drm: Add solid fill pixel source commit: 4b64167042927531f4cfaf035b8f88c2f7a05f06 [04/10] drm/atomic: Add pixel source to plane state dump commit: 8283ac7871a959848e09fc6593b8c12b8febfee6 [05/10] drm/atomic: Add solid fill data to plane state dump commit: e86413f5442ee094e66b3e75f2d3419ed0df9520 [06/10] drm/atomic: Move framebuffer checks to helper commit: 4ba6b7a646321e740c7f2d80c90505019c4e8fce [07/10] drm/atomic: Loosen FB atomic checks commit: f1e75da5364e780905d9cd6043f9c74cdcf84073 Best regards, -- Dmitry Baryshkov
