Re: [Freedreno] [PATCH] drm/msm/dp: switch to devm_drm_of_get_bridge

[José Expósito]

On Tue, Feb 22, 2022 at 09:07:49PM +, Stephen Boyd wrote:
> Quoting José Expósito (2022-02-20 23:33:39)
> > The function "drm_of_find_panel_or_bridge" has been deprecated in
> > favor of "devm_drm_of_get_bridge".
> >
> > Switch to the new function and reduce boilerplate.
> >
> > Signed-off-by: José Expósito 
> > ---
> 
> Dmitry is rewriting this code in a larger series. This patch is
> superseded by that work.

Thanks for the heads up Stephen, it is indeed superseded by [0].

And thanks for the review Maxime.

[0] 
https://lore.kernel.org/dri-devel/20220211224006.1797846-3-dmitry.barysh...@linaro.org/

Re: [Freedreno] [PATCH] drm/msm/dp: switch to devm_drm_of_get_bridge

[Stephen Boyd]

Quoting José Expósito (2022-02-20 23:33:39)
> The function "drm_of_find_panel_or_bridge" has been deprecated in
> favor of "devm_drm_of_get_bridge".
>
> Switch to the new function and reduce boilerplate.
>
> Signed-off-by: José Expósito 
> ---

Dmitry is rewriting this code in a larger series. This patch is
superseded by that work.

Re: [Freedreno] [PATCH] drm/msm/dp: switch to devm_drm_of_get_bridge

[Maxime Ripard]

On Mon, Feb 21, 2022 at 08:33:39AM +0100, José Expósito wrote:
> The function "drm_of_find_panel_or_bridge" has been deprecated in
> favor of "devm_drm_of_get_bridge".
> 
> Switch to the new function and reduce boilerplate.
> 
> Signed-off-by: José Expósito 

Reviewed-by: Maxime Ripard 

Maxime


signature.asc
Description: PGP signature

[Freedreno] [PATCH] drm/msm/dp: switch to devm_drm_of_get_bridge

[José Expósito]

The function "drm_of_find_panel_or_bridge" has been deprecated in
favor of "devm_drm_of_get_bridge".

Switch to the new function and reduce boilerplate.

Signed-off-by: José Expósito 
---
 drivers/gpu/drm/msm/dp/dp_parser.c | 10 +-
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/drivers/gpu/drm/msm/dp/dp_parser.c 
b/drivers/gpu/drm/msm/dp/dp_parser.c
index a7acc23f742b..0951752e2d98 100644
--- a/drivers/gpu/drm/msm/dp/dp_parser.c
+++ b/drivers/gpu/drm/msm/dp/dp_parser.c
@@ -268,16 +268,8 @@ static int dp_parser_clock(struct dp_parser *parser)
 static int dp_parser_find_panel(struct dp_parser *parser)
 {
struct device *dev = >pdev->dev;
-   struct drm_panel *panel;
-   int rc;
 
-   rc = drm_of_find_panel_or_bridge(dev->of_node, 1, 0, , NULL);
-   if (rc) {
-   DRM_ERROR("failed to acquire DRM panel: %d\n", rc);
-   return rc;
-   }
-
-   parser->panel_bridge = devm_drm_panel_bridge_add(dev, panel);
+   parser->panel_bridge = devm_drm_of_get_bridge(dev, dev->of_node, 1, 0);
if (IS_ERR(parser->panel_bridge)) {
DRM_ERROR("failed to create panel bridge\n");
return PTR_ERR(parser->panel_bridge);
-- 
2.25.1