Re: [Freedreno] [PATCH] drm/msm/submit: fix overflow check on 64-bit architectures

[Stephen Boyd]

Quoting Arnd Bergmann (2021-09-27 04:36:23)
> From: Arnd Bergmann 
>
> The overflow check does causes a warning from clang-14 when 'sz' is a type
> that is smaller than size_t:
>
> drivers/gpu/drm/msm/msm_gem_submit.c:217:10: error: result of comparison of 
> constant 18446744073709551615 with expression of type 'unsigned int' is 
> always false [-Werror,-Wtautological-constant-out-of-range-compare]
> if (sz == SIZE_MAX) {
>
> Change the type accordingly.
>
> Fixes: 20224d715a88 ("drm/msm/submit: Move copy_from_user ahead of locking 
> bos")
> Signed-off-by: Arnd Bergmann 
> ---

Reviewed-by: Stephen Boyd 

[Freedreno] [PATCH] drm/msm/submit: fix overflow check on 64-bit architectures

[Arnd Bergmann]

From: Arnd Bergmann 

The overflow check does causes a warning from clang-14 when 'sz' is a type
that is smaller than size_t:

drivers/gpu/drm/msm/msm_gem_submit.c:217:10: error: result of comparison of 
constant 18446744073709551615 with expression of type 'unsigned int' is always 
false [-Werror,-Wtautological-constant-out-of-range-compare]
if (sz == SIZE_MAX) {

Change the type accordingly.

Fixes: 20224d715a88 ("drm/msm/submit: Move copy_from_user ahead of locking bos")
Signed-off-by: Arnd Bergmann 
---
 drivers/gpu/drm/msm/msm_gem_submit.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/msm_gem_submit.c 
b/drivers/gpu/drm/msm/msm_gem_submit.c
index fdc5367aecaa..ac23bbdb0bab 100644
--- a/drivers/gpu/drm/msm/msm_gem_submit.c
+++ b/drivers/gpu/drm/msm/msm_gem_submit.c
@@ -171,7 +171,8 @@ static int submit_lookup_objects(struct msm_gem_submit 
*submit,
 static int submit_lookup_cmds(struct msm_gem_submit *submit,
struct drm_msm_gem_submit *args, struct drm_file *file)
 {
-   unsigned i, sz;
+   unsigned i;
+   size_t sz;
int ret = 0;
 
for (i = 0; i < args->nr_cmds; i++) {
-- 
2.29.2