Re: [Freedreno] [PATCH v2 2/2] dt-bindings: Add SC7280 compatible string

2021-10-21 Thread quic_sbillaka 
Hi Doug,

Sorry about that, this is the first time I am posting changes upstream and 
still getting hold of conventions.

I think I misinterpreted your subject line comment and changed the just title 
to include dp-controller. I will correct it in the next version.

sc7280-dp will be added later when dp support for sc7280 will be posted. I will 
reply on the feedback email from Stephen.

Thank you,
Sankeerth

-Original Message-
From: Doug Anderson  
Sent: Wednesday, October 20, 2021 11:11 PM
To: quic_sbillaka 
Cc: dri-devel ; linux-arm-msm 
; freedreno ; 
LKML ; Sankeerth Billakanti 
; Rob Clark ; Sean Paul 
; Stephen Boyd ; Kalyan Thota 
; Abhinav Kumar ; Kuogee 
Hsieh ; Krishna Manikandan 
Subject: Re: [PATCH v2 2/2] dt-bindings: Add SC7280 compatible string

WARNING: This email originated from outside of Qualcomm. Please be wary of any 
links or attachments, and do not enable macros.

Hi,

On Wed, Oct 20, 2021 at 5:14 AM Sankeerth Billakanti 
 wrote:
>
> From: Sankeerth Billakanti 
>
> The Qualcomm SC7280 platform supports an eDP controller, add 
> compatible string for it to dp-controller.
>
> Signed-off-by: Sankeerth Billakanti 
> ---
>  Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 1 
> +
>  1 file changed, 1 insertion(+)

I think you ignored some of the feedback that was given on v1. Perhaps you 
could go back and re-read that feedback? See the replies to:

https://lore.kernel.org/r/1628726882-27841-3-git-send-email-sbill...@codeaurora.org/

For one, ${SUBJECT} needs updating. It's probably as simple as adding the 
"msm/dp" tag, like:

dt-bindings: msm/dp: Add SC7280 compatible string

For another, Stephen requested that you add "sc7280-dp" too.

Re: [Freedreno] [PATCH v2 2/2] dt-bindings: Add SC7280 compatible string

2021-10-20 Thread Doug Anderson 
Hi,

On Wed, Oct 20, 2021 at 5:14 AM Sankeerth Billakanti
 wrote:
>
> From: Sankeerth Billakanti 
>
> The Qualcomm SC7280 platform supports an eDP controller, add
> compatible string for it to dp-controller.
>
> Signed-off-by: Sankeerth Billakanti 
> ---
>  Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 1 +
>  1 file changed, 1 insertion(+)

I think you ignored some of the feedback that was given on v1. Perhaps
you could go back and re-read that feedback? See the replies to:

https://lore.kernel.org/r/1628726882-27841-3-git-send-email-sbill...@codeaurora.org/

For one, ${SUBJECT} needs updating. It's probably as simple as adding
the "msm/dp" tag, like:

dt-bindings: msm/dp: Add SC7280 compatible string

For another, Stephen requested that you add "sc7280-dp" too.

[Freedreno] [PATCH v2 2/2] dt-bindings: Add SC7280 compatible string

2021-10-20 Thread Sankeerth Billakanti 
From: Sankeerth Billakanti 

The Qualcomm SC7280 platform supports an eDP controller, add
compatible string for it to dp-controller.

Signed-off-by: Sankeerth Billakanti 
---
 Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml 
b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
index 63e585f..ab2bb1b 100644
--- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
@@ -17,6 +17,7 @@ properties:
   compatible:
 enum:
   - qcom,sc7180-dp
+  - qcom,sc7280-edp
   - qcom,sc8180x-dp
   - qcom,sc8180x-edp
 
-- 
The Qualcomm Innovatin Center, Inc. is a member of the Code Aurora Forum, a 
Linux Foundation Collaborative Project