Re: [Freedreno] [PATCH v3 08/11] arm64: dts: qcom: sm8350: Use 2 interconnect cells
On Mon, 5 Dec 2022 at 20:19, Georgi Djakov wrote: > > Hi Robert, > > On 5.12.22 18:37, Robert Foss wrote: > > Use two interconnect cells in order to optionally > > support a path tag. > > > > Signed-off-by: Robert Foss > > Reviewed-by: Konrad Dybcio > > --- > > arch/arm64/boot/dts/qcom/sm8350.dtsi | 28 ++-- > > 1 file changed, 14 insertions(+), 14 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi > > b/arch/arm64/boot/dts/qcom/sm8350.dtsi > > index 805d53d91952..434f8e8b12c1 100644 > > --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi > > @@ -1543,56 +1543,56 @@ apps_smmu: iommu@1500 { > > config_noc: interconnect@150 { > > compatible = "qcom,sm8350-config-noc"; > > reg = <0 0x0150 0 0xa580>; > > - #interconnect-cells = <1>; > > + #interconnect-cells = <2>; > > qcom,bcm-voters = <_bcm_voter>; > > }; > > > > mc_virt: interconnect@158 { > > compatible = "qcom,sm8350-mc-virt"; > > reg = <0 0x0158 0 0x1000>; > > - #interconnect-cells = <1>; > > + #interconnect-cells = <2>; > > qcom,bcm-voters = <_bcm_voter>; > > }; > [..] > > @@ -1620,8 +1620,8 @@ ipa: ipa@1e4 { > > clocks = < RPMH_IPA_CLK>; > > clock-names = "core"; > > > > - interconnects = <_noc MASTER_IPA _virt > > SLAVE_EBI1>, > > - <_noc MASTER_APPSS_PROC > > _noc SLAVE_IPA_CFG>; > > + interconnects = <_noc MASTER_IPA 0 _virt > > SLAVE_EBI1 0>, > > + <_noc MASTER_APPSS_PROC 0 > > _noc SLAVE_IPA_CFG 0>; > > interconnect-names = "memory", > >"config"; > > > > @@ -1661,7 +1661,7 @@ mpss: remoteproc@408 { > > < SM8350_MSS>; > > power-domain-names = "cx", "mss"; > > > > - interconnects = <_virt MASTER_LLCC _virt > > SLAVE_EBI1>; > > + interconnects = <_virt MASTER_LLCC _virt > > SLAVE_EBI1 0>; > > The second cell for the first endpoint is missing, so this should be: > interconnects = <_virt MASTER_LLCC 0 _virt SLAVE_EBI1 0>; Nice catch, thanks! > > Thanks, > Georgi > > > > > memory-region = <_modem_mem>; > > > > @@ -2239,7 +2239,7 @@ cdsp: remoteproc@9890 { > > < SM8350_MXC>; > > power-domain-names = "cx", "mxc"; > > > > - interconnects = <_noc MASTER_CDSP_PROC > > _virt SLAVE_EBI1>; > > + interconnects = <_noc MASTER_CDSP_PROC 0 > > _virt SLAVE_EBI1 0>; > > > > memory-region = <_cdsp_mem>; > > > > @@ -2421,14 +2421,14 @@ usb_2_ssphy: phy@88ebe00 { > > dc_noc: interconnect@90c { > > compatible = "qcom,sm8350-dc-noc"; > > reg = <0 0x090c 0 0x4200>; > > - #interconnect-cells = <1>; > > + #interconnect-cells = <2>; > > qcom,bcm-voters = <_bcm_voter>; > > }; > > > > gem_noc: interconnect@910 { > > compatible = "qcom,sm8350-gem-noc"; > > reg = <0 0x0910 0 0xb4000>; > > - #interconnect-cells = <1>; > > + #interconnect-cells = <2>; > > qcom,bcm-voters = <_bcm_voter>; > > }; > > >
Re: [Freedreno] [PATCH v3 08/11] arm64: dts: qcom: sm8350: Use 2 interconnect cells
Hi Robert, On 5.12.22 18:37, Robert Foss wrote: Use two interconnect cells in order to optionally support a path tag. Signed-off-by: Robert Foss Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi index 805d53d91952..434f8e8b12c1 100644 --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi @@ -1543,56 +1543,56 @@ apps_smmu: iommu@1500 { config_noc: interconnect@150 { compatible = "qcom,sm8350-config-noc"; reg = <0 0x0150 0 0xa580>; - #interconnect-cells = <1>; + #interconnect-cells = <2>; qcom,bcm-voters = <_bcm_voter>; }; mc_virt: interconnect@158 { compatible = "qcom,sm8350-mc-virt"; reg = <0 0x0158 0 0x1000>; - #interconnect-cells = <1>; + #interconnect-cells = <2>; qcom,bcm-voters = <_bcm_voter>; }; [..] @@ -1620,8 +1620,8 @@ ipa: ipa@1e4 { clocks = < RPMH_IPA_CLK>; clock-names = "core"; - interconnects = <_noc MASTER_IPA _virt SLAVE_EBI1>, - <_noc MASTER_APPSS_PROC _noc SLAVE_IPA_CFG>; + interconnects = <_noc MASTER_IPA 0 _virt SLAVE_EBI1 0>, + <_noc MASTER_APPSS_PROC 0 _noc SLAVE_IPA_CFG 0>; interconnect-names = "memory", "config"; @@ -1661,7 +1661,7 @@ mpss: remoteproc@408 { < SM8350_MSS>; power-domain-names = "cx", "mss"; - interconnects = <_virt MASTER_LLCC _virt SLAVE_EBI1>; + interconnects = <_virt MASTER_LLCC _virt SLAVE_EBI1 0>; The second cell for the first endpoint is missing, so this should be: interconnects = <_virt MASTER_LLCC 0 _virt SLAVE_EBI1 0>; Thanks, Georgi memory-region = <_modem_mem>; @@ -2239,7 +2239,7 @@ cdsp: remoteproc@9890 { < SM8350_MXC>; power-domain-names = "cx", "mxc"; - interconnects = <_noc MASTER_CDSP_PROC _virt SLAVE_EBI1>; + interconnects = <_noc MASTER_CDSP_PROC 0 _virt SLAVE_EBI1 0>; memory-region = <_cdsp_mem>; @@ -2421,14 +2421,14 @@ usb_2_ssphy: phy@88ebe00 { dc_noc: interconnect@90c { compatible = "qcom,sm8350-dc-noc"; reg = <0 0x090c 0 0x4200>; - #interconnect-cells = <1>; + #interconnect-cells = <2>; qcom,bcm-voters = <_bcm_voter>; }; gem_noc: interconnect@910 { compatible = "qcom,sm8350-gem-noc"; reg = <0 0x0910 0 0xb4000>; - #interconnect-cells = <1>; + #interconnect-cells = <2>; qcom,bcm-voters = <_bcm_voter>; };
[Freedreno] [PATCH v3 08/11] arm64: dts: qcom: sm8350: Use 2 interconnect cells
Use two interconnect cells in order to optionally support a path tag. Signed-off-by: Robert Foss Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi index 805d53d91952..434f8e8b12c1 100644 --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi @@ -1543,56 +1543,56 @@ apps_smmu: iommu@1500 { config_noc: interconnect@150 { compatible = "qcom,sm8350-config-noc"; reg = <0 0x0150 0 0xa580>; - #interconnect-cells = <1>; + #interconnect-cells = <2>; qcom,bcm-voters = <_bcm_voter>; }; mc_virt: interconnect@158 { compatible = "qcom,sm8350-mc-virt"; reg = <0 0x0158 0 0x1000>; - #interconnect-cells = <1>; + #interconnect-cells = <2>; qcom,bcm-voters = <_bcm_voter>; }; system_noc: interconnect@168 { compatible = "qcom,sm8350-system-noc"; reg = <0 0x0168 0 0x1c200>; - #interconnect-cells = <1>; + #interconnect-cells = <2>; qcom,bcm-voters = <_bcm_voter>; }; aggre1_noc: interconnect@16e { compatible = "qcom,sm8350-aggre1-noc"; reg = <0 0x016e 0 0x1f180>; - #interconnect-cells = <1>; + #interconnect-cells = <2>; qcom,bcm-voters = <_bcm_voter>; }; aggre2_noc: interconnect@170 { compatible = "qcom,sm8350-aggre2-noc"; reg = <0 0x0170 0 0x33000>; - #interconnect-cells = <1>; + #interconnect-cells = <2>; qcom,bcm-voters = <_bcm_voter>; }; mmss_noc: interconnect@174 { compatible = "qcom,sm8350-mmss-noc"; reg = <0 0x0174 0 0x1f080>; - #interconnect-cells = <1>; + #interconnect-cells = <2>; qcom,bcm-voters = <_bcm_voter>; }; lpass_ag_noc: interconnect@3c4 { compatible = "qcom,sm8350-lpass-ag-noc"; reg = <0 0x03c4 0 0xf080>; - #interconnect-cells = <1>; + #interconnect-cells = <2>; qcom,bcm-voters = <_bcm_voter>; }; compute_noc: interconnect@a0c{ compatible = "qcom,sm8350-compute-noc"; reg = <0 0x0a0c 0 0xa180>; - #interconnect-cells = <1>; + #interconnect-cells = <2>; qcom,bcm-voters = <_bcm_voter>; }; @@ -1620,8 +1620,8 @@ ipa: ipa@1e4 { clocks = < RPMH_IPA_CLK>; clock-names = "core"; - interconnects = <_noc MASTER_IPA _virt SLAVE_EBI1>, - <_noc MASTER_APPSS_PROC _noc SLAVE_IPA_CFG>; + interconnects = <_noc MASTER_IPA 0 _virt SLAVE_EBI1 0>, + <_noc MASTER_APPSS_PROC 0 _noc SLAVE_IPA_CFG 0>; interconnect-names = "memory", "config"; @@ -1661,7 +1661,7 @@ mpss: remoteproc@408 { < SM8350_MSS>; power-domain-names = "cx", "mss"; - interconnects = <_virt MASTER_LLCC _virt SLAVE_EBI1>; + interconnects = <_virt MASTER_LLCC _virt SLAVE_EBI1 0>; memory-region = <_modem_mem>; @@ -2239,7 +2239,7 @@ cdsp: remoteproc@9890 { < SM8350_MXC>; power-domain-names = "cx", "mxc"; - interconnects = <_noc MASTER_CDSP_PROC _virt SLAVE_EBI1>; + interconnects = <_noc MASTER_CDSP_PROC 0 _virt SLAVE_EBI1 0>; memory-region = <_cdsp_mem>; @@ -2421,14 +2421,14 @@ usb_2_ssphy: phy@88ebe00 { dc_noc: interconnect@90c { compatible = "qcom,sm8350-dc-noc"; reg = <0 0x090c 0 0x4200>; - #interconnect-cells = <1>; + #interconnect-cells = <2>;