Re: [Freedreno] [PATCH v6 02/11] dt-bindings: display/msm: add SoC-specific compats to qcom, mdp5.yaml

[Rob Herring]

On Fri, Jan 13, 2023 at 10:37:11AM +0200, Dmitry Baryshkov wrote:
> Add platform-specific compatible entries to the qcom,mdp5.yaml to allow
> distinguishing between various platforms.
> 
> Signed-off-by: Dmitry Baryshkov 
> ---
>  .../bindings/display/msm/qcom,mdp5.yaml | 17 -
>  .../bindings/display/msm/qcom,mdss.yaml |  6 +-
>  2 files changed, 21 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml 
> b/Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml
> index 5e3cd7abf046..cb7bf48c3a58 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml
> @@ -16,7 +16,22 @@ maintainers:
>  
>  properties:
>compatible:
> -const: qcom,mdp5
> +oneOf:
> +  - const: qcom,mdp5
> +deprecated: true
> +  - items:
> +  - enum:
> +  - qcom,apq8084-mdp5
> +  - qcom,msm8916-mdp5
> +  - qcom,msm8917-mdp5
> +  - qcom,msm8953-mdp5
> +  - qcom,msm8974-mdp5
> +  - qcom,msm8976-mdp5
> +  - qcom,msm8994-mdp5
> +  - qcom,msm8996-mdp5
> +  - qcom,sdm630-mdp5
> +  - qcom,sdm660-mdp5
> +  - const: qcom,mdp5
>  
>reg:
>  maxItems: 1
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml 
> b/Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml
> index ba0460268731..dcde34ffc8d0 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml
> @@ -88,7 +88,11 @@ patternProperties:
>  type: object
>  properties:
>compatible:
> -const: qcom,mdp5
> +oneOf:
> +  - const: qcom,mdp5
> +  - items:
> +  - {}
> +  - const: qcom,mdp5

Just 'contains' is sufficient for all this. The exact length and order 
will be checked by qcom,mdp5.yaml. With that,

Reviewed-by: Rob Herring 

Rob

[Freedreno] [PATCH v6 02/11] dt-bindings: display/msm: add SoC-specific compats to qcom, mdp5.yaml

[Dmitry Baryshkov]

Add platform-specific compatible entries to the qcom,mdp5.yaml to allow
distinguishing between various platforms.

Signed-off-by: Dmitry Baryshkov 
---
 .../bindings/display/msm/qcom,mdp5.yaml | 17 -
 .../bindings/display/msm/qcom,mdss.yaml |  6 +-
 2 files changed, 21 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml 
b/Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml
index 5e3cd7abf046..cb7bf48c3a58 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml
@@ -16,7 +16,22 @@ maintainers:
 
 properties:
   compatible:
-const: qcom,mdp5
+oneOf:
+  - const: qcom,mdp5
+deprecated: true
+  - items:
+  - enum:
+  - qcom,apq8084-mdp5
+  - qcom,msm8916-mdp5
+  - qcom,msm8917-mdp5
+  - qcom,msm8953-mdp5
+  - qcom,msm8974-mdp5
+  - qcom,msm8976-mdp5
+  - qcom,msm8994-mdp5
+  - qcom,msm8996-mdp5
+  - qcom,sdm630-mdp5
+  - qcom,sdm660-mdp5
+  - const: qcom,mdp5
 
   reg:
 maxItems: 1
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml 
b/Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml
index ba0460268731..dcde34ffc8d0 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml
@@ -88,7 +88,11 @@ patternProperties:
 type: object
 properties:
   compatible:
-const: qcom,mdp5
+oneOf:
+  - const: qcom,mdp5
+  - items:
+  - {}
+  - const: qcom,mdp5
 
   "^dsi@[1-9a-f][0-9a-f]*$":
 type: object
-- 
2.39.0