Re: [PATCH v2 3/4] dt-bindings: display/msm: Add SM7150 DPU
On 13/06/2024 12:13, Dmitry Baryshkov wrote: > On Thu, Jun 13, 2024 at 11:23:50AM +0200, Krzysztof Kozlowski wrote: >> On 12/06/2024 20:43, Danila Tikhonov wrote: >>> Document the DPU hardware found on the Qualcomm SM7150 platform. >> >> In general, this should be before MDSS, because it defines fully the >> compatibles already used in the MDSS schema. For multi-binding devices >> it always starts with children and ends with parent/top schema. >> >>> >>> Signed-off-by: Danila Tikhonov >>> --- >>> .../bindings/display/msm/qcom,sm7150-dpu.yaml | 143 ++ >>> 1 file changed, 143 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/display/msm/qcom,sm7150-dpu.yaml >>> >>> diff --git >>> a/Documentation/devicetree/bindings/display/msm/qcom,sm7150-dpu.yaml >>> b/Documentation/devicetree/bindings/display/msm/qcom,sm7150-dpu.yaml >>> new file mode 100644 >>> index 0..1a44cad131a72 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm7150-dpu.yaml >>> @@ -0,0 +1,143 @@ >>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/display/msm/qcom,sm7150-dpu.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Qualcomm SM7150 Display DPU >> >> What is DPU? Such acronyms should be explained in description or >> expanded here, if there is space. > > Other bindings here use 'DPU', so probably we need to fix all of them at > the same time. Well, we can also start it for new bindings but that's not a reason for resend itself. Best regards, Krzysztof
Re: [PATCH v2 3/4] dt-bindings: display/msm: Add SM7150 DPU
On Thu, Jun 13, 2024 at 11:23:50AM +0200, Krzysztof Kozlowski wrote: > On 12/06/2024 20:43, Danila Tikhonov wrote: > > Document the DPU hardware found on the Qualcomm SM7150 platform. > > In general, this should be before MDSS, because it defines fully the > compatibles already used in the MDSS schema. For multi-binding devices > it always starts with children and ends with parent/top schema. > > > > > Signed-off-by: Danila Tikhonov > > --- > > .../bindings/display/msm/qcom,sm7150-dpu.yaml | 143 ++ > > 1 file changed, 143 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/display/msm/qcom,sm7150-dpu.yaml > > > > diff --git > > a/Documentation/devicetree/bindings/display/msm/qcom,sm7150-dpu.yaml > > b/Documentation/devicetree/bindings/display/msm/qcom,sm7150-dpu.yaml > > new file mode 100644 > > index 0..1a44cad131a72 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm7150-dpu.yaml > > @@ -0,0 +1,143 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/msm/qcom,sm7150-dpu.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Qualcomm SM7150 Display DPU > > What is DPU? Such acronyms should be explained in description or > expanded here, if there is space. Other bindings here use 'DPU', so probably we need to fix all of them at the same time. > > Reviewed-by: Krzysztof Kozlowski > > > + > > +maintainers: > > + - Danila Tikhonov > > + > > +$ref: /schemas/display/msm/dpu-common.yaml# > > + > > +properties: > > + compatible: > > +const: qcom,sm7150-dpu > > + > > > > Best regards, > Krzysztof > -- With best wishes Dmitry
Re: [PATCH v2 3/4] dt-bindings: display/msm: Add SM7150 DPU
On 12/06/2024 20:43, Danila Tikhonov wrote: > Document the DPU hardware found on the Qualcomm SM7150 platform. In general, this should be before MDSS, because it defines fully the compatibles already used in the MDSS schema. For multi-binding devices it always starts with children and ends with parent/top schema. > > Signed-off-by: Danila Tikhonov > --- > .../bindings/display/msm/qcom,sm7150-dpu.yaml | 143 ++ > 1 file changed, 143 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/display/msm/qcom,sm7150-dpu.yaml > > diff --git > a/Documentation/devicetree/bindings/display/msm/qcom,sm7150-dpu.yaml > b/Documentation/devicetree/bindings/display/msm/qcom,sm7150-dpu.yaml > new file mode 100644 > index 0..1a44cad131a72 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm7150-dpu.yaml > @@ -0,0 +1,143 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/msm/qcom,sm7150-dpu.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm SM7150 Display DPU What is DPU? Such acronyms should be explained in description or expanded here, if there is space. Reviewed-by: Krzysztof Kozlowski > + > +maintainers: > + - Danila Tikhonov > + > +$ref: /schemas/display/msm/dpu-common.yaml# > + > +properties: > + compatible: > +const: qcom,sm7150-dpu > + Best regards, Krzysztof
[PATCH v2 3/4] dt-bindings: display/msm: Add SM7150 DPU
Document the DPU hardware found on the Qualcomm SM7150 platform.
Signed-off-by: Danila Tikhonov
---
.../bindings/display/msm/qcom,sm7150-dpu.yaml | 143 ++
1 file changed, 143 insertions(+)
create mode 100644
Documentation/devicetree/bindings/display/msm/qcom,sm7150-dpu.yaml
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm7150-dpu.yaml
b/Documentation/devicetree/bindings/display/msm/qcom,sm7150-dpu.yaml
new file mode 100644
index 0..1a44cad131a72
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/msm/qcom,sm7150-dpu.yaml
@@ -0,0 +1,143 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/msm/qcom,sm7150-dpu.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm SM7150 Display DPU
+
+maintainers:
+ - Danila Tikhonov
+
+$ref: /schemas/display/msm/dpu-common.yaml#
+
+properties:
+ compatible:
+const: qcom,sm7150-dpu
+
+ reg:
+items:
+ - description: Address offset and size for mdp register set
+ - description: Address offset and size for vbif register set
+
+ reg-names:
+items:
+ - const: mdp
+ - const: vbif
+
+ clocks:
+items:
+ - description: Display hf axi clock
+ - description: Display ahb clock
+ - description: Display rotator clock
+ - description: Display lut clock
+ - description: Display core clock
+ - description: Display vsync clock
+
+ clock-names:
+items:
+ - const: bus
+ - const: iface
+ - const: rot
+ - const: lut
+ - const: core
+ - const: vsync
+
+required:
+ - compatible
+ - reg
+ - reg-names
+ - clocks
+ - clock-names
+
+unevaluatedProperties: false
+
+examples:
+ - |
+#include
+#include
+
+display-controller@ae01000 {
+compatible = "qcom,sm7150-dpu";
+reg = <0x0ae01000 0x8f000>,
+ <0x0aeb 0x2008>;
+reg-names = "mdp", "vbif";
+
+clocks = <&gcc_disp_hf_axi_clk>,
+ <&dispcc_mdss_ahb_clk>,
+ <&dispcc_mdss_rot_clk>,
+ <&dispcc_mdss_mdp_lut_clk>,
+ <&dispcc_mdss_mdp_clk>,
+ <&dispcc_mdss_vsync_clk>;
+clock-names = "bus",
+ "iface",
+ "rot",
+ "lut",
+ "core",
+ "vsync";
+
+assigned-clocks = <&dispcc_mdss_vsync_clk>;
+assigned-clock-rates = <1920>;
+
+operating-points-v2 = <&mdp_opp_table>;
+power-domains = <&rpmhpd RPMHPD_CX>;
+
+interrupt-parent = <&mdss>;
+interrupts = <0>;
+
+ports {
+#address-cells = <1>;
+#size-cells = <0>;
+
+port@0 {
+reg = <0>;
+dpu_intf1_out: endpoint {
+remote-endpoint = <&mdss_dsi0_in>;
+};
+};
+
+port@1 {
+reg = <1>;
+dpu_intf2_out: endpoint {
+remote-endpoint = <&mdss_dsi1_in>;
+};
+};
+
+port@2 {
+reg = <2>;
+dpu_intf0_out: endpoint {
+remote-endpoint = <&dp_in>;
+};
+};
+};
+
+mdp_opp_table: opp-table {
+compatible = "operating-points-v2";
+
+opp-1920 {
+opp-hz = /bits/ 64 <1920>;
+required-opps = <&rpmhpd_opp_min_svs>;
+};
+
+opp-2 {
+opp-hz = /bits/ 64 <2>;
+required-opps = <&rpmhpd_opp_low_svs>;
+};
+
+opp-3 {
+opp-hz = /bits/ 64 <3>;
+required-opps = <&rpmhpd_opp_svs>;
+};
+
+opp-34400 {
+opp-hz = /bits/ 64 <34400>;
+required-opps = <&rpmhpd_opp_svs_l1>;
+};
+
+opp-43000 {
+opp-hz = /bits/ 64 <43000>;
+required-opps = <&rpmhpd_opp_nom>;
+};
+};
+};
+...
--
2.45.2
