Re: [PATCH] drm/msm/dpu: drop duplicate drm formats from wb2_formats arrays
On Fri, 24 May 2024 23:01:12 +0800, Junhao Xie wrote: > There are duplicate items in wb2_formats_rgb and wb2_formats_rgb_yuv, > which cause weston assertions failed. > > weston: libweston/drm-formats.c:131: weston_drm_format_array_add_format: > Assertion `!weston_drm_format_array_find_format(formats, format)' failed. > > > [...] Applied, thanks! [1/1] drm/msm/dpu: drop duplicate drm formats from wb2_formats arrays https://gitlab.freedesktop.org/abhinavk/msm-next/-/commit/3788ddf084b7 Best regards, -- Abhinav Kumar
Re: [PATCH] drm/msm/dpu: drop duplicate drm formats from wb2_formats arrays
On Fri, May 24, 2024 at 11:01:12PM +0800, Junhao Xie wrote:
> There are duplicate items in wb2_formats_rgb and wb2_formats_rgb_yuv,
> which cause weston assertions failed.
>
> weston: libweston/drm-formats.c:131: weston_drm_format_array_add_format:
> Assertion `!weston_drm_format_array_find_format(formats, format)' failed.
>
> Signed-off-by: Junhao Xie
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 6 --
> 1 file changed, 6 deletions(-)
>
To make patchwork happy:
Reviewed-by: Konrad Dybcio
Fixes: 8c16b988ba2d ("drm/msm/dpu: introduce separate wb2_format arrays for rgb
and yuv")
Fixes: 53324b99bd7b ("drm/msm/dpu: add writeback blocks to the sm8250 DPU
catalog")
Reviewed-by: Abhinav Kumar
Reviewed-by: Dmitry Baryshkov
--
With best wishes
Dmitry
Re: [PATCH] drm/msm/dpu: drop duplicate drm formats from wb2_formats arrays
On Fri, May 24, 2024 at 11:19:41AM -0700, Abhinav Kumar wrote:
>
>
> On 5/24/2024 8:01 AM, Junhao Xie wrote:
> > There are duplicate items in wb2_formats_rgb and wb2_formats_rgb_yuv,
> > which cause weston assertions failed.
> >
> > weston: libweston/drm-formats.c:131: weston_drm_format_array_add_format:
> > Assertion `!weston_drm_format_array_find_format(formats, format)' failed.
> >
> > Signed-off-by: Junhao Xie
> > ---
> > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 6 --
> > 1 file changed, 6 deletions(-)
> >
>
> I think we need two fixes tag here, one for the RGB array and the other one
> for the RGB+YUV array.
>
> Fixes: 8c16b988ba2d ("drm/msm/dpu: introduce separate wb2_format arrays for
> rgb and yuv")
>
> Fixes: 53324b99bd7b ("drm/msm/dpu: add writeback blocks to the sm8250 DPU
> catalog")
>
> Reviewed-by: Abhinav Kumar
>
> (pls ignore the line breaks in the fixes line, I will fix it while applying)
With the Fixes tags in place:
Reviewed-by: Dmitry Baryshkov
--
With best wishes
Dmitry
Re: [PATCH] drm/msm/dpu: drop duplicate drm formats from wb2_formats arrays
On 5/24/2024 8:01 AM, Junhao Xie wrote:
There are duplicate items in wb2_formats_rgb and wb2_formats_rgb_yuv,
which cause weston assertions failed.
weston: libweston/drm-formats.c:131: weston_drm_format_array_add_format:
Assertion `!weston_drm_format_array_find_format(formats, format)' failed.
Signed-off-by: Junhao Xie
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 6 --
1 file changed, 6 deletions(-)
I think we need two fixes tag here, one for the RGB array and the other
one for the RGB+YUV array.
Fixes: 8c16b988ba2d ("drm/msm/dpu: introduce separate wb2_format arrays
for rgb and yuv")
Fixes: 53324b99bd7b ("drm/msm/dpu: add writeback blocks to the sm8250
DPU catalog")
Reviewed-by: Abhinav Kumar
(pls ignore the line breaks in the fixes line, I will fix it while applying)
Re: [PATCH] drm/msm/dpu: drop duplicate drm formats from wb2_formats arrays
On 24.05.2024 5:01 PM, Junhao Xie wrote: > There are duplicate items in wb2_formats_rgb and wb2_formats_rgb_yuv, > which cause weston assertions failed. > > weston: libweston/drm-formats.c:131: weston_drm_format_array_add_format: > Assertion `!weston_drm_format_array_find_format(formats, format)' failed. > > Signed-off-by: Junhao Xie > --- Reviewed-by: Konrad Dybcio Konrad
