[Freeipa-devel] [freeipa PR#701][comment] ipa help doesn't always work

2017-06-15 Thread martbab via FreeIPA-devel 
  URL: https://github.com/freeipa/freeipa/pull/701
Title: #701: ipa help doesn't always work

martbab commented:
"""
master:

* d5bb541061e6c0952d2075a24d0a58c87455f233 Store help in Schema before writing 
to disk
* bf0ba9b36e95f2e2b14bb27059280027d8354c13 Disable pylint in get_help function 
because of type confusion.


"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/701#issuecomment-308648946
___
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org

[Freeipa-devel] [freeipa PR#701][comment] ipa help doesn't always work

2017-06-09 Thread neffs via FreeIPA-devel 
  URL: https://github.com/freeipa/freeipa/pull/701
Title: #701: ipa help doesn't always work

neffs commented:
"""
@martbab I pushed this additional change but pylint still reports this error 
which is clearly wrong because the line is only executed if it is an instance 
of bytes. Could you please provide some directions?
I only have the code on my mac and unfortunately can't run the tests locally.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/701#issuecomment-307434275
___
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org

[Freeipa-devel] [freeipa PR#701][comment] ipa help doesn't always work

2017-06-02 Thread neffs via FreeIPA-devel 
  URL: https://github.com/freeipa/freeipa/pull/701
Title: #701: ipa help doesn't always work

neffs commented:
"""
Not sure why pylint is reporting this, it looks fine to me and I didn't change 
this function.
```python
if isinstance(self._help, bytes):
self._help = json.loads(self._help.decode('utf-8'))
```

maybe we can trick it with a change like this (similar to 
read_namespace_member):
```python
value = self._help
if isinstance(value, bytes):
self._help = json.loads(value.decode('utf-8'))
```
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/701#issuecomment-304273513
___
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org

[Freeipa-devel] [freeipa PR#701][comment] ipa help doesn't always work

2017-05-26 Thread neffs via FreeIPA-devel 
  URL: https://github.com/freeipa/freeipa/pull/701
Title: #701: ipa help doesn't always work

neffs commented:
"""
Not sure why pylint is reporting this, it looks fine to me and I didn't change 
this function.
```python
if isinstance(self._help, bytes):
self._help = json.loads(self._help.decode('utf-8'))
```

maybe we can trick it with a change like this (similar to 
read_namespace_member):
```python
value = self._help
if isinstance(value, bytes):
self._help = json.loads(value.decode('utf-8'))
```
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/701#issuecomment-304273513
___
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org

[Freeipa-devel] [freeipa PR#701][comment] ipa help doesn't always work

2017-05-26 Thread martbab via FreeIPA-devel 
  URL: https://github.com/freeipa/freeipa/pull/701
Title: #701: ipa help doesn't always work

martbab commented:
"""
@neffs please fix pylint error reported in Travis CI:

```console
* Module ipaclient.remote_plugins.schema

ipaclient/remote_plugins/schema.py:519: [E1101(no-member), Schema.get_help] 
Instance of 'dict' has no 'decode' member)

make: *** [pylint] Error 2

Makefile:1175: recipe for target 'pylint' failed
```
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/701#issuecomment-304254492
___
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org