[Freeipa-devel] [freeipa PR#845][comment] ipadiscovery: Return realm as a string
URL: https://github.com/freeipa/freeipa/pull/845 Title: #845: ipadiscovery: Return realm as a string MartinBasti commented: """ LGTM, we anyway assume inside framework that everything is in utf-8 """ See the full comment at https://github.com/freeipa/freeipa/pull/845#issuecomment-307142144 ___ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org
[Freeipa-devel] [freeipa PR#845][comment] ipadiscovery: Return realm as a string
URL: https://github.com/freeipa/freeipa/pull/845 Title: #845: ipadiscovery: Return realm as a string MartinBasti commented: """ That is an experimental only RFC. By general it can contain any byte textually represented in octal form. str() in python2 converts from bytes using ASCII codec, so by keeping compatibility and avoiding to parse weird realms it should be IMO ASCII. But I can live with utf-8 as well, but I haven't checked how is this handled later in code """ See the full comment at https://github.com/freeipa/freeipa/pull/845#issuecomment-305739666 ___ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org
[Freeipa-devel] [freeipa PR#845][comment] ipadiscovery: Return realm as a string
URL: https://github.com/freeipa/freeipa/pull/845 Title: #845: ipadiscovery: Return realm as a string stlaz commented: """ https://tools.ietf.org/html/rfc1464 suggests that only ASCII may be contained in a TXT record, although I like to go with the Internet rule: "Trust noone." and so I decided to decode it as UTF-8. You want to go even further on the aforementioned rule which is OK with me, then, I will update the PR. """ See the full comment at https://github.com/freeipa/freeipa/pull/845#issuecomment-305725226 ___ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org
[Freeipa-devel] [freeipa PR#845][comment] ipadiscovery: Return realm as a string
URL: https://github.com/freeipa/freeipa/pull/845 Title: #845: ipadiscovery: Return realm as a string MartinBasti commented: """ A TXT record can contain anything in any encoding, it contains just bytes without predefined semantic, we should play safe here and catch UnicodeDecodeError. Also currently we support only ASCII for realms, I'm not sure which character are allowed to be in realm outside IPA world, I haven't found a clear answer. """ See the full comment at https://github.com/freeipa/freeipa/pull/845#issuecomment-305722760 ___ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org
