Re: [Freeipa-devel] [PATCH] Make error messages in migration plugin unicode.

2010-02-17 Thread Rob Crittenden

Pavel Zuna wrote:

Fixes output of the migration plugin.

Pavel


Tested, works fine for me.

pushed to master

rob

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


[Freeipa-devel] [PATCH] Make error messages in migration plugin unicode.

2010-02-17 Thread Pavel Zuna

Fixes output of the migration plugin.

Pavel


0001-Make-error-message-in-migration-plugin-unicode.patch
Description: application/mbox
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH 384-386 small problems discovered in migration

2010-02-17 Thread Rob Crittenden

Pavel Zuna wrote:

Rob Crittenden wrote:
Here are 3 tiny patches that fix some problems in the migration 
plugin. This should allow group migration from an IPA v1 server to work.


rob


ack all 3 patches

Pavel


pushed all 3 to master

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH 384-386 small problems discovered in migration

2010-02-17 Thread Pavel Zuna

Rob Crittenden wrote:
Here are 3 tiny patches that fix some problems in the migration plugin. 
This should allow group migration from an IPA v1 server to work.


rob


ack all 3 patches

Pavel

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


[Freeipa-devel] [PATCH 384-386 small problems discovered in migration

2010-02-17 Thread Rob Crittenden
Here are 3 tiny patches that fix some problems in the migration plugin. 
This should allow group migration from an IPA v1 server to work.


rob


freeipa-384-attr.patch
Description: application/mbox


freeipa-385-list.patch
Description: application/mbox


freeipa-386-migrate.patch
Description: application/mbox
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 383 reverse special handling for it

2010-02-17 Thread Jason Gerard DeRose
On Wed, 2010-02-17 at 10:59 -0500, Rob Crittenden wrote:
> Well this hack lasted less time than I expected. This backs out special 
> handling for ints.
> 
> rob

ack.  pushed to master.

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


[Freeipa-devel] [PATCH] 383 reverse special handling for it

2010-02-17 Thread Rob Crittenden
Well this hack lasted less time than I expected. This backs out special 
handling for ints.


rob


freeipa-383-int.patch
Description: application/mbox
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] Auto-generate --all and --raw for commands, that return entries.

2010-02-17 Thread Rob Crittenden

Pavel Zuna wrote:
This patch makes the Command base class generate --all and --raw 
parameters for every command, that has either an Entry or a 
ListOfEntries instance in its has_output.


It also modifies the default output_for_cli to take these options into 
account. I think its better if output_for_cli (instead of 
textui.print_entry) handles things like attribute labels and attribute 
order.


Pavel


ack, pushed to master

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] Convert password policy integer values to unicode instead of str.

2010-02-17 Thread Rob Crittenden

Pavel Zuna wrote:
Password policy plugin was converting integers to str, which is 
unfriendly with our str==binary approach.


Pavel


ack, pushed to master

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] Convert integers and boolean values to unicode, don't leave them as str.

2010-02-17 Thread Rob Crittenden

Pavel Zuna wrote:
This solves the bug, where integer and boolean values are interpreted as 
binary.


Pavel


ack, pushed to master

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] Convert integers and boolean values to unicode, don't leave them as str.

2010-02-17 Thread John Dennis

On 02/17/2010 09:56 AM, Pavel Zuna wrote:

This solves the bug, where integer and boolean values are interpreted as
binary.


ACK

--
John Dennis 

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] Convert password policy integer values to unicode instead of str.

2010-02-17 Thread John Dennis

On 02/17/2010 10:25 AM, Pavel Zuna wrote:

Password policy plugin was converting integers to str, which is
unfriendly with our str==binary approach.

Pavel


ACK

--
John Dennis 

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


[Freeipa-devel] [PATCH] Convert password policy integer values to unicode instead of str.

2010-02-17 Thread Pavel Zuna
Password policy plugin was converting integers to str, which is unfriendly with 
our str==binary approach.


Pavel


0001-Convert-password-policy-integer-values-to-unicode-in.patch
Description: application/mbox
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] Auto-generate --all and --raw for commands, that return entries.

2010-02-17 Thread Pavel Zuna
This patch makes the Command base class generate --all and --raw parameters for 
every command, that has either an Entry or a ListOfEntries instance in its 
has_output.


It also modifies the default output_for_cli to take these options into account. 
I think its better if output_for_cli (instead of textui.print_entry) handles 
things like attribute labels and attribute order.


Pavel


0001-Auto-generate-all-and-raw-for-commands-that-return-e.patch
Description: application/mbox
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] Convert integers and boolean values to unicode, don't leave them as str.

2010-02-17 Thread Pavel Zuna

This solves the bug, where integer and boolean values are interpreted as binary.

Pavel


0002-Convert-integer-and-boolean-values-to-unicode-don-t-.patch
Description: application/mbox
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 381 fix output of integers

2010-02-17 Thread Pavel Zuna

Rob Crittenden wrote:
Integers are included in the list of things to convert to str 
internally. This makes them be considered binary by 
ipalib.cli.encode_binary(). Add a hackish test for now to see if we have 
an integer or not. I know that Pavel is working on more graceful way to 
handle encoding and I can live with this for now.


rob
I know it's late, but NACK. This isn't the right solution. I just posted a patch 
that solves this problem at its root (ldap2).


Pavel

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] 382 fix pwpolicy output

2010-02-17 Thread Jason Gerard DeRose
On Tue, 2010-02-16 at 23:01 -0500, Rob Crittenden wrote:
> Convert the pwpolicy plugin to use the new output system. Otherwise some 
> of these commands output nothing at all, or at best something not quite 
> useful.
> 
> rob

ack.  pushed to master.

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] 381 fix output of integers

2010-02-17 Thread Jason Gerard DeRose
On Tue, 2010-02-16 at 23:00 -0500, Rob Crittenden wrote:
> Integers are included in the list of things to convert to str 
> internally. This makes them be considered binary by 
> ipalib.cli.encode_binary(). Add a hackish test for now to see if we have 
> an integer or not. I know that Pavel is working on more graceful way to 
> handle encoding and I can live with this for now.
> 
> rob

ack.  pushed to master.

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel