[Freeipa-devel] [freeipa PR#12] Tests: Duplicate declaration on variables in ID views tests (label change)

2016-08-23 Thread freeipa-github-notification
mirielka's pull request #12: "Tests: Duplicate declaration on variables in ID 
views tests" label *ack* has been added

See the full pull-request at https://github.com/freeipa/freeipa/pull/12
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#12] Tests: Duplicate declaration on variables in ID views tests (opened)

2016-08-23 Thread freeipa-github-notification
mirielka's pull request #12: "Tests: Duplicate declaration on variables in ID 
views tests" was opened

PR body:
In ipatests/test_xmlrpc/test_idviews_plugin several variables are declared
twice, while never using the first declaration. The duplicate declaration is
hereby removed.

https://fedorahosted.org/freeipa/ticket/6246

See the full pull-request at https://github.com/freeipa/freeipa/pull/12


freeipa-pr-12.patch
Description: application/text/diff
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#11] Removed unwanted line break from RefererError Dialog message (label change)

2016-08-23 Thread freeipa-github-notification
Akasurde's pull request #11: "Removed unwanted line break from RefererError 
Dialog message" label *ack* has been added

See the full pull-request at https://github.com/freeipa/freeipa/pull/11
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#11] Removed unwanted line break from RefererError Dialog message (opened)

2016-08-22 Thread freeipa-github-notification
Akasurde's pull request #11: "Removed unwanted line break from RefererError 
Dialog message" was opened

PR body:
Fixes: https://fedorahosted.org/freeipa/ticket/5932

Signed-off-by: Abhijeet Kasurde 

See the full pull-request at https://github.com/freeipa/freeipa/pull/11


freeipa-pr-11.patch
Description: application/text/diff
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#10] Client-side CSR autogeneration (opened)

2016-08-22 Thread freeipa-github-notification
LiptonB's pull request #10: "Client-side CSR autogeneration" was opened

PR body:
Adds a library that builds scripts that builds CSRs. Adds a CLI command, 
'cert-get-requestdata', that uses this library and builds the script for a 
given principal. Adds rules for the caIPAserviceCert profile, as well as a new 
userCert profile, stored in json files in /usr/share/ipa/csr. The rule provider 
is a separate class so that it can be replaced easily if we ever want to move 
rules to the server side.

See the full pull-request at https://github.com/freeipa/freeipa/pull/10


freeipa-pr-10.patch
Description: application/text/diff
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#4] Fix man page ipa-replica-manage: remove duplicate -c option from --no-lookup (closed)

2016-08-22 Thread freeipa-github-notification
pspacek's pull request #4: "Fix man page ipa-replica-manage: remove duplicate 
-c option from --no-lookup" was closed

See the full pull-request at https://github.com/freeipa/freeipa/pull/4
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#4] Fix man page ipa-replica-manage: remove duplicate -c option from --no-lookup (label change)

2016-08-22 Thread freeipa-github-notification
pspacek's pull request #4: "Fix man page ipa-replica-manage: remove duplicate 
-c option from --no-lookup" label *pushed* has been added

See the full pull-request at https://github.com/freeipa/freeipa/pull/4
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#4] Fix man page ipa-replica-manage: remove duplicate -c option from --no-lookup (comment)

2016-08-22 Thread freeipa-github-notification
mbasti-rh commented on a pull request

Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/1142c3a28079316e2946ef008ad52e7e4cf89863

See the full comment at 
https://github.com/freeipa/freeipa/pull/4#issuecomment-241483260
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#4] Fix man page ipa-replica-manage: remove duplicate -c option from --no-lookup (label change)

2016-08-22 Thread freeipa-github-notification
pspacek's pull request #4: "Fix man page ipa-replica-manage: remove duplicate 
-c option from --no-lookup" label *ack* has been added

See the full pull-request at https://github.com/freeipa/freeipa/pull/4
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#9] ipa-4-3: add python-libsss_nss_idmap and python-sss to BuildRequires (comment)

2016-08-22 Thread freeipa-github-notification
mbasti-rh commented on a pull request

Fixed upstream
ipa-4-3:
https://fedorahosted.org/freeipa/changeset/b0e43d5ec879fc56c38328cd9f01b04d8b6a870d

See the full comment at 
https://github.com/freeipa/freeipa/pull/9#issuecomment-241477746
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#9] ipa-4-3: add python-libsss_nss_idmap and python-sss to BuildRequires (closed)

2016-08-22 Thread freeipa-github-notification
martbab's pull request #9: "ipa-4-3: add python-libsss_nss_idmap and python-sss 
to BuildRequires" was closed

See the full pull-request at https://github.com/freeipa/freeipa/pull/9
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#9] ipa-4-3: add python-libsss_nss_idmap and python-sss to BuildRequires (label change)

2016-08-22 Thread freeipa-github-notification
martbab's pull request #9: "ipa-4-3: add python-libsss_nss_idmap and python-sss 
to BuildRequires" label *pushed* has been added

See the full pull-request at https://github.com/freeipa/freeipa/pull/9
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#8] add python-libsss_nss_idmap and python-sss to BuildRequires (closed)

2016-08-22 Thread freeipa-github-notification
martbab's pull request #8: "add python-libsss_nss_idmap and python-sss to 
BuildRequires" was closed

See the full pull-request at https://github.com/freeipa/freeipa/pull/8
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#8] add python-libsss_nss_idmap and python-sss to BuildRequires (label change)

2016-08-22 Thread freeipa-github-notification
martbab's pull request #8: "add python-libsss_nss_idmap and python-sss to 
BuildRequires" label *pushed* has been added

See the full pull-request at https://github.com/freeipa/freeipa/pull/8
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#8] add python-libsss_nss_idmap and python-sss to BuildRequires (comment)

2016-08-22 Thread freeipa-github-notification
martbab commented on a pull request

Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/a4f4cac993afa1c0bd1585d14a26d4ce1f729b95

See the full comment at 
https://github.com/freeipa/freeipa/pull/8#issuecomment-241477680
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#9] ipa-4-3: add python-libsss_nss_idmap and python-sss to BuildRequires (label change)

2016-08-22 Thread freeipa-github-notification
martbab's pull request #9: "ipa-4-3: add python-libsss_nss_idmap and python-sss 
to BuildRequires" label *ack* has been added

See the full pull-request at https://github.com/freeipa/freeipa/pull/9
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#9] ipa-4-3: add python-libsss_nss_idmap and python-sss to BuildRequires (comment)

2016-08-22 Thread freeipa-github-notification
abbra commented on a pull request

The backport is OK too.

See the full comment at 
https://github.com/freeipa/freeipa/pull/9#issuecomment-241476574
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#9] ipa-4-3: add python-libsss_nss_idmap and python-sss to BuildRequires (opened)

2016-08-22 Thread freeipa-github-notification
martbab's pull request #9: "ipa-4-3: add python-libsss_nss_idmap and python-sss 
to BuildRequires" was opened

PR body:
This fixes pylint failing on import errors during 'lint' phase of build.

https://fedorahosted.org/freeipa/ticket/6244

See the full pull-request at https://github.com/freeipa/freeipa/pull/9


freeipa-pr-9.patch
Description: application/text/diff
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#8] add python-libsss_nss_idmap and python-sss to BuildRequires (comment)

2016-08-22 Thread freeipa-github-notification
abbra commented on a pull request

Looks good to me.

See the full comment at 
https://github.com/freeipa/freeipa/pull/8#issuecomment-241474126
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#8] add python-libsss_nss_idmap and python-sss to BuildRequires (label change)

2016-08-22 Thread freeipa-github-notification
martbab's pull request #8: "add python-libsss_nss_idmap and python-sss to 
BuildRequires" label *ack* has been added

See the full pull-request at https://github.com/freeipa/freeipa/pull/8
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#8] add python-libsss_nss_idmap and python-sss to BuildRequires (opened)

2016-08-22 Thread freeipa-github-notification
martbab's pull request #8: "add python-libsss_nss_idmap and python-sss to 
BuildRequires" was opened

PR body:
This fixes pylint failing on import errors during 'lint' phase of build.

https://fedorahosted.org/freeipa/ticket/6244

See the full pull-request at https://github.com/freeipa/freeipa/pull/8


freeipa-pr-8.patch
Description: application/text/diff
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#5] migrate-ds: Mention --enable-migration in error message about migraion mode (label change)

2016-08-22 Thread freeipa-github-notification
pspacek's pull request #5: "migrate-ds: Mention --enable-migration in error 
message about migraion mode" label *pushed* has been added

See the full pull-request at https://github.com/freeipa/freeipa/pull/5
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#5] migrate-ds: Mention --enable-migration in error message about migraion mode (comment)

2016-08-22 Thread freeipa-github-notification
mbasti-rh commented on a pull request

Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/0f4df2f03df09ebced37ff0dd49d489782b85d73

See the full comment at 
https://github.com/freeipa/freeipa/pull/5#issuecomment-241460779
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#5] migrate-ds: Mention --enable-migration in error message about migraion mode (closed)

2016-08-22 Thread freeipa-github-notification
pspacek's pull request #5: "migrate-ds: Mention --enable-migration in error 
message about migraion mode" was closed

See the full pull-request at https://github.com/freeipa/freeipa/pull/5
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#7] config-mod: normalize attribute names for --usersearch/--groupsearch (comment)

2016-08-22 Thread freeipa-github-notification
mbasti-rh commented on a pull request

Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/3ac2709f4b026e7c7153777f7472c383fe99a175

See the full comment at 
https://github.com/freeipa/freeipa/pull/7#issuecomment-241458780
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#7] config-mod: normalize attribute names for --usersearch/--groupsearch (label change)

2016-08-22 Thread freeipa-github-notification
pspacek's pull request #7: "config-mod: normalize attribute names for 
--usersearch/--groupsearch" label *pushed* has been added

See the full pull-request at https://github.com/freeipa/freeipa/pull/7
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#7] config-mod: normalize attribute names for --usersearch/--groupsearch (closed)

2016-08-22 Thread freeipa-github-notification
pspacek's pull request #7: "config-mod: normalize attribute names for 
--usersearch/--groupsearch" was closed

See the full pull-request at https://github.com/freeipa/freeipa/pull/7
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#3] User add fix #6199 (synchronize)

2016-08-22 Thread freeipa-github-notification
mbasti-rh's pull request #3: "User add fix #6199" was synchronize

See the full pull-request at https://github.com/freeipa/freeipa/pull/3


freeipa-pr-3.patch
Description: application/text/diff
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#6] adtrust-install: Mention AD GC port 3286 in list of required ports (label change)

2016-08-22 Thread freeipa-github-notification
pspacek's pull request #6: "adtrust-install: Mention AD GC port 3286 in list of 
required ports" label *pushed* has been added

See the full pull-request at https://github.com/freeipa/freeipa/pull/6
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#6] adtrust-install: Mention AD GC port 3286 in list of required ports (comment)

2016-08-22 Thread freeipa-github-notification
mbasti-rh commented on a pull request

Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/3cf80e747d0172f7a80f5393c4481392e4448ca6

See the full comment at 
https://github.com/freeipa/freeipa/pull/6#issuecomment-241373805
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#6] adtrust-install: Mention AD GC port 3286 in list of required ports (closed)

2016-08-22 Thread freeipa-github-notification
pspacek's pull request #6: "adtrust-install: Mention AD GC port 3286 in list of 
required ports" was closed

See the full pull-request at https://github.com/freeipa/freeipa/pull/6
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#7] config-mod: normalize attribute names for --usersearch/--groupsearch (comment)

2016-08-22 Thread freeipa-github-notification
abbra commented on a pull request

Looks good to me. Thanks.

See the full comment at 
https://github.com/freeipa/freeipa/pull/7#issuecomment-241345286
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#5] migrate-ds: Mention --enable-migration in error message about migraion mode (comment)

2016-08-22 Thread freeipa-github-notification
mbasti-rh commented on a pull request

Works for me

See the full comment at 
https://github.com/freeipa/freeipa/pull/5#issuecomment-241343377
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#5] migrate-ds: Mention --enable-migration in error message about migraion mode (label change)

2016-08-22 Thread freeipa-github-notification
pspacek's pull request #5: "migrate-ds: Mention --enable-migration in error 
message about migraion mode" label *ack* has been added

See the full pull-request at https://github.com/freeipa/freeipa/pull/5
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#7] config-mod: normalize attribute names for --usersearch/--groupsearch (opened)

2016-08-22 Thread freeipa-github-notification
pspacek's pull request #7: "config-mod: normalize attribute names for 
--usersearch/--groupsearch" was opened

PR body:
https://fedorahosted.org/freeipa/ticket/6236

See the full pull-request at https://github.com/freeipa/freeipa/pull/7


freeipa-pr-7.patch
Description: application/text/diff
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#6] adtrust-install: Mention AD GC port 3286 in list of required ports (comment)

2016-08-22 Thread freeipa-github-notification
abbra commented on a pull request

Sounds good to me. Thanks.

See the full comment at 
https://github.com/freeipa/freeipa/pull/6#issuecomment-241337413
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#6] adtrust-install: Mention AD GC port 3286 in list of required ports (label change)

2016-08-22 Thread freeipa-github-notification
pspacek's pull request #6: "adtrust-install: Mention AD GC port 3286 in list of 
required ports" label *ack* has been added

See the full pull-request at https://github.com/freeipa/freeipa/pull/6
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa/freeipa #6] adtrust-install: Mention AD GC port 3286 in list of required ports (opened)

2016-08-22 Thread freeipa-github-notification
pspacek's pull request #6: "adtrust-install: Mention AD GC port 3286 in list of 
required ports" was opened

PR body:
Port name "msft-gc" is taken form /etc/services file provided by package
setup-2.10.1-1.fc24.noarch.

https://fedorahosted.org/freeipa/ticket/6235

See the full pull-request at https://github.com/freeipa/freeipa/pull/6
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa/freeipa #5] migrate-ds: Mention --enable-migration in error message about migraion mode (opened)

2016-08-22 Thread freeipa-github-notification
pspacek's pull request #5: "migrate-ds: Mention --enable-migration in error 
message about migraion mode" was opened

PR body:
https://fedorahosted.org/freeipa/ticket/6234

See the full pull-request at https://github.com/freeipa/freeipa/pull/5
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa/freeipa #4] Fix man page ipa-replica-manage: remove duplicate -c option from --no-lookup (opened)

2016-08-22 Thread freeipa-github-notification
pspacek's pull request #4: "Fix man page ipa-replica-manage: remove duplicate 
-c option from --no-lookup" was opened

PR body:
https://fedorahosted.org/freeipa/ticket/6233

See the full pull-request at https://github.com/freeipa/freeipa/pull/4
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa/freeipa #3] User add fix #6199 (comment)

2016-08-21 Thread freeipa-github-notification
jcholast commented on a pull request

This is not very comprehensible. I would rather replace the:
```python
dn = self.obj.get_either_dn(*keys, **options)
```
at the beginning of `user_add.pre_callback` with:
```python
delete_dn = self.obj.get_delete_dn(*keys, **options)
try:
ldap.get_entry(delete_dn, [''])
except errors.NotFound:
pass
else:
self.obj.handle_duplicate_entry(*keys)
```
Note that this assumes that the routine to get `delete_dn` was split off from 
`user.get_either_dn()` into `user.get_delete_dn()` to avoid copy-pasta.

See the full comment at 
https://github.com/freeipa/freeipa/pull/3#issuecomment-241318444
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa/freeipa #2] Remove forgotten print from DN.__str__ implementation (comment)

2016-08-19 Thread freeipa-github-notification
mbasti-rh commented on a pull request

Sorry testing phase of tools :)

Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/86e156c3c5f331e3f169b941be2d9f72e7c8f000


See the full comment at 
https://github.com/freeipa/freeipa/pull/2#issuecomment-240991058
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa/freeipa #2] Remove forgotten print from DN.__str__ implementation (closed)

2016-08-19 Thread freeipa-github-notification
mbasti-rh's pull request #2: "Remove forgotten print from DN.__str__ 
implementation" was closed

See the full pull-request at https://github.com/freeipa/freeipa/pull/2
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa/freeipa #2] Remove forgotten print from DN.__str__ implementation (comment)

2016-08-19 Thread freeipa-github-notification
mbasti-rh commented on a pull request

m
a
s
t
e
r
:


*
 
8
6
e
1
5
6
c
3
c
5
f
3
3
1
e
3
f
1
6
9
b
9
4
1
b
e
2
d
9
f
7
2
e
7
c
8
f
0
0
0
 
R
e
m
o
v
e
 
f
o
r
g
o
t
t
e
n
 
p
r
i
n
t
 
f
r
o
m
 
D
N
.
_
_
s
t
r
_
_
 
i
m
p
l
e
m
e
n
t
a
t
i
o
n

See the full comment at 
https://github.com/freeipa/freeipa/pull/2#issuecomment-240990609
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa/freeipa #2] Remove forgotten print from DN.__str__ implementation (label change)

2016-08-19 Thread freeipa-github-notification
mbasti-rh's pull request #2: "Remove forgotten print from DN.__str__ 
implementation" label *ack* has been added

See the full pull-request at https://github.com/freeipa/freeipa/pull/2
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa/freeipa #2] Remove forgotten print from DN.__str__ implementation (comment)

2016-08-19 Thread freeipa-github-notification
dkupka commented on a pull request

Makes sense.

See the full comment at 
https://github.com/freeipa/freeipa/pull/2#issuecomment-240984276
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa/freeipa #2] Remove forgotten print from DN.__str__ implementation (comment)

2016-08-19 Thread freeipa-github-notification
dkupka commented on a pull request

Makes sence.

See the full comment at 
https://github.com/freeipa/freeipa/pull/2#issuecomment-240981516
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa/freeipa #2] Remove forgotten print from DN.__str__ implementation (comment)

2016-08-19 Thread freeipa-github-notification
davidkupka commented on a pull request

Makes sence.

See the full comment at 
https://github.com/freeipa/freeipa/pull/2#issuecomment-240977749
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa/freeipa #3] User add fix #6199 (opened)

2016-08-19 Thread freeipa-github-notification
mbasti-rh's pull request #3: "User add fix #6199" was opened

PR body:
We do not have right to write to users delete_container. In case that
user already exists in that container and we tried to add entry, we
receive ACIError. This must be checked and DuplicationEntry error must
be raised before.

https://fedorahosted.org/freeipa/ticket/6199

See the full pull-request at https://github.com/freeipa/freeipa/pull/3
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa/freeipa #2] Remove forgotten print from DN.__str__ implementation (opened)

2016-08-19 Thread freeipa-github-notification
mbasti-rh's pull request #2: "Remove forgotten print from DN.__str__ 
implementation" was opened

PR body:
These debug prints were forgotten there and should be removed, because
str(DN) is often operation and we may save time with handling exceptions
and printing unwanted debug

See the full pull-request at https://github.com/freeipa/freeipa/pull/2
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code