Re: [Freeipa-devel] [PATCH] Revert-Set-hard-limit-on-number-of-commands-in-batch

2011-03-01 Thread Rob Crittenden

Adam Young wrote:

I have not tested this, just ran:

git revert 79d22f8341026450ba7ca564e24812c9351c7e70


Please test before ACKing. I will test as well now.




ack

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] Revert-Set-hard-limit-on-number-of-commands-in-batch

2011-03-01 Thread Adam Young

On 03/01/2011 05:34 PM, Rob Crittenden wrote:

Adam Young wrote:

I have not tested this, just ran:

git revert 79d22f8341026450ba7ca564e24812c9351c7e70


Please test before ACKing. I will test as well now.




ack

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Pushed to master

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


[Freeipa-devel] [PATCH] Revert-Set-hard-limit-on-number-of-commands-in-batch

2011-02-25 Thread Adam Young

I have not tested this, just ran:

git revert 79d22f8341026450ba7ca564e24812c9351c7e70


Please test before ACKing.  I will test as well now.
From 07d17548e9bb2d7b2a13667cb1c3f4bc23d9e92b Mon Sep 17 00:00:00 2001
From: Adam Young ayo...@redhat.com
Date: Fri, 25 Feb 2011 13:33:42 -0500
Subject: [PATCH] Revert Set hard limit on number of commands in batch request to 256.

This reverts commit 79d22f8341026450ba7ca564e24812c9351c7e70.
---
 ipalib/errors.py|   17 -
 ipalib/plugins/batch.py |2 --
 2 files changed, 0 insertions(+), 19 deletions(-)

diff --git a/ipalib/errors.py b/ipalib/errors.py
index 6883cbdabd39bb71bb2831bdcc72d66d1000f5c5..f48ad55aaf0c268f5c9088639224fe2b58f7c6bb 100644
--- a/ipalib/errors.py
+++ b/ipalib/errors.py
@@ -1471,23 +1471,6 @@ class NotRegisteredError(ExecutionError):
 format = _('Not registered yet')
 
 
-class BatchRequestLimitError(ExecutionError):
-
-**4307** Raised when a batch request contains too many commands
-
-For example:
- raise BatchRequestLimitError(limit=128)
-Traceback (most recent call last):
-  ...
-BatchRequestLimitError: Too many commands in request, limit is 128
-
-
-
-errno = 4307
-format = _('Too many commands in request, limit is %(limit)s')
-
-
-
 ##
 # 5000 - 5999: Generic errors
 
diff --git a/ipalib/plugins/batch.py b/ipalib/plugins/batch.py
index 5455340b2812991a012e87fc951062200b795cd1..a5907791d9dbe6c5beddf1a084fedc4d35215c38 100644
--- a/ipalib/plugins/batch.py
+++ b/ipalib/plugins/batch.py
@@ -80,8 +80,6 @@ class batch(Command):
 
 def execute(self, *args, **options):
 results=[]
-if len(args[0])  256:
-raise errors.BatchRequestLimitError(limit=256)
 for arg in args[0]:
 try:
 a = arg['params'][0]
-- 
1.7.3.5

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel