[Freeipa-devel] [PATCH] 0056 webui: Counterpart of dnsserver-{find, show, mod}
Hello,
please review attached patch.
https://fedorahosted.org/freeipa/ticket/5905
--
Pavel^3 Vomacka
From 16270e37ce76796e76513270f5833241d4f5c892 Mon Sep 17 00:00:00 2001
From: Pavel Vomacka
Date: Thu, 16 Jun 2016 10:09:36 +0200
Subject: [PATCH] DNS Servers: Web UI part
Adds new page with DNS Servers and details page about each server.
There is also new adder dialog for adding new DNS Server. In summary
it is counterpart of dnsserver-{find,show,mod} CLI commands.
Part of: https://fedorahosted.org/freeipa/ticket/5905
---
install/ui/src/freeipa/dns.js | 54 ++
install/ui/src/freeipa/navigation/menu_spec.js | 1 +
2 files changed, 55 insertions(+)
diff --git a/install/ui/src/freeipa/dns.js b/install/ui/src/freeipa/dns.js
index 8573e653770867210bb31066021e5b78809b1573..a441b56026aa1510d5c7357c156a12e2eb46325b 100644
--- a/install/ui/src/freeipa/dns.js
+++ b/install/ui/src/freeipa/dns.js
@@ -492,6 +492,58 @@ return {
};};
+var make_dnsserver_spec = function() {
+var spec = {
+name: 'dnsserver',
+enable_test: function() {
+return IPA.dns_enabled;
+},
+facets: [
+{
+$type: 'search',
+no_update: true,
+columns: [
+'idnsserverid'
+]
+},
+{
+$type: 'details',
+disable_facet_tabs: true,
+fields: [
+'idnssoamname',
+'idnsserverid',
+{
+$type: 'multivalued',
+name: 'idnsforwarders',
+validators: ['dnsforwarder']
+},
+{
+$type: 'radio',
+name: 'idnsforwardpolicy',
+options: [
+{
+value: 'first',
+label: '@i18n:objects.dnsconfig.forward_first'
+},
+{
+value: 'only',
+label: '@i18n:objects.dnsconfig.forward_only'
+},
+{
+value: 'none',
+label: '@i18n:objects.dnsconfig.forward_none'
+}
+]
+}
+]
+}
+]
+};
+
+return spec;
+};
+
+
IPA.dnszone_details_facet = function(spec, no_init) {
spec = spec || {};
@@ -2521,6 +2573,7 @@ exp.config_spec = make_config_spec();
exp.zone_spec = make_zone_spec();
exp.record_spec = make_record_spec();
exp.forwardzone_spec = make_forwardzone_spec();
+exp.dnsserver_spec = make_dnsserver_spec();
exp.register = function() {
var e = reg.entity;
var w = reg.widget;
@@ -2532,6 +2585,7 @@ exp.register = function() {
e.register({type: 'dnszone', spec: exp.zone_spec});
e.register({type: 'dnsrecord', spec: exp.record_spec});
e.register({type: 'dnsforwardzone', spec: exp.forwardzone_spec});
+e.register({type: 'dnsserver', spec: exp.dnsserver_spec});
w.register('dnszone_name', IPA.dnszone_name_widget);
w.register('force_dnszone_add_checkbox', IPA.force_dnszone_add_checkbox_widget);
diff --git a/install/ui/src/freeipa/navigation/menu_spec.js b/install/ui/src/freeipa/navigation/menu_spec.js
index 2e47761ce3f17289d0a0a914896ee31209ace290..108f4577f7e1326b9c9bc495c54f6e1f12a0cce6 100644
--- a/install/ui/src/freeipa/navigation/menu_spec.js
+++ b/install/ui/src/freeipa/navigation/menu_spec.js
@@ -179,6 +179,7 @@ var nav = {};
]
},
{ entity: 'dnsforwardzone' },
+{ entity: 'dnsserver' },
{ entity: 'dnsconfig' }
]
}
--
2.5.5
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH] 0056 webui: Counterpart of dnsserver-{find, show, mod}
On 06/16/2016 12:06 PM, Pavel Vomacka wrote:
Hello,
please review attached patch.
https://fedorahosted.org/freeipa/ticket/5905
Fixed commit message
--
Pavel^3 Vomacka
From c61e0dd9190be2537ecd8da0a4fa5c0ace81a81e Mon Sep 17 00:00:00 2001
From: Pavel Vomacka
Date: Thu, 16 Jun 2016 10:09:36 +0200
Subject: [PATCH] DNS Servers: Web UI part
Adds new page with DNS Servers and details page about each server.
It is counterpart of dnsserver-{find,show,mod} CLI commands.
Part of: https://fedorahosted.org/freeipa/ticket/5905
---
install/ui/src/freeipa/dns.js | 54 ++
install/ui/src/freeipa/navigation/menu_spec.js | 1 +
2 files changed, 55 insertions(+)
diff --git a/install/ui/src/freeipa/dns.js b/install/ui/src/freeipa/dns.js
index 8573e653770867210bb31066021e5b78809b1573..a441b56026aa1510d5c7357c156a12e2eb46325b 100644
--- a/install/ui/src/freeipa/dns.js
+++ b/install/ui/src/freeipa/dns.js
@@ -492,6 +492,58 @@ return {
};};
+var make_dnsserver_spec = function() {
+var spec = {
+name: 'dnsserver',
+enable_test: function() {
+return IPA.dns_enabled;
+},
+facets: [
+{
+$type: 'search',
+no_update: true,
+columns: [
+'idnsserverid'
+]
+},
+{
+$type: 'details',
+disable_facet_tabs: true,
+fields: [
+'idnssoamname',
+'idnsserverid',
+{
+$type: 'multivalued',
+name: 'idnsforwarders',
+validators: ['dnsforwarder']
+},
+{
+$type: 'radio',
+name: 'idnsforwardpolicy',
+options: [
+{
+value: 'first',
+label: '@i18n:objects.dnsconfig.forward_first'
+},
+{
+value: 'only',
+label: '@i18n:objects.dnsconfig.forward_only'
+},
+{
+value: 'none',
+label: '@i18n:objects.dnsconfig.forward_none'
+}
+]
+}
+]
+}
+]
+};
+
+return spec;
+};
+
+
IPA.dnszone_details_facet = function(spec, no_init) {
spec = spec || {};
@@ -2521,6 +2573,7 @@ exp.config_spec = make_config_spec();
exp.zone_spec = make_zone_spec();
exp.record_spec = make_record_spec();
exp.forwardzone_spec = make_forwardzone_spec();
+exp.dnsserver_spec = make_dnsserver_spec();
exp.register = function() {
var e = reg.entity;
var w = reg.widget;
@@ -2532,6 +2585,7 @@ exp.register = function() {
e.register({type: 'dnszone', spec: exp.zone_spec});
e.register({type: 'dnsrecord', spec: exp.record_spec});
e.register({type: 'dnsforwardzone', spec: exp.forwardzone_spec});
+e.register({type: 'dnsserver', spec: exp.dnsserver_spec});
w.register('dnszone_name', IPA.dnszone_name_widget);
w.register('force_dnszone_add_checkbox', IPA.force_dnszone_add_checkbox_widget);
diff --git a/install/ui/src/freeipa/navigation/menu_spec.js b/install/ui/src/freeipa/navigation/menu_spec.js
index 2e47761ce3f17289d0a0a914896ee31209ace290..108f4577f7e1326b9c9bc495c54f6e1f12a0cce6 100644
--- a/install/ui/src/freeipa/navigation/menu_spec.js
+++ b/install/ui/src/freeipa/navigation/menu_spec.js
@@ -179,6 +179,7 @@ var nav = {};
]
},
{ entity: 'dnsforwardzone' },
+{ entity: 'dnsserver' },
{ entity: 'dnsconfig' }
]
}
--
2.5.5
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH] 0056 webui: Counterpart of dnsserver-{find, show, mod}
On 16.6.2016 12:09, Pavel Vomacka wrote: > > > On 06/16/2016 12:06 PM, Pavel Vomacka wrote: >> Hello, >> >> please review attached patch. >> >> https://fedorahosted.org/freeipa/ticket/5905 >> > Fixed commit message LGTM from user's perspective but I did not review the code. -- Petr^2 Spacek -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH] 0056 webui: Counterpart of dnsserver-{find, show, mod}
On 06/16/2016 01:38 PM, Petr Spacek wrote: > On 16.6.2016 12:09, Pavel Vomacka wrote: >> >> >> On 06/16/2016 12:06 PM, Pavel Vomacka wrote: >>> Hello, >>> >>> please review attached patch. >>> >>> https://fedorahosted.org/freeipa/ticket/5905 >>> >> Fixed commit message > > > LGTM from user's perspective but I did not review the code. > Code looks OK, applies well, but I did not test yet. So if Petr's LGTM is functional test ACK, then ACK from me. -- Petr Vobornik -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH] 0056 webui: Counterpart of dnsserver-{find, show, mod}
On 21.06.2016 16:44, Petr Vobornik wrote: On 06/16/2016 01:38 PM, Petr Spacek wrote: On 16.6.2016 12:09, Pavel Vomacka wrote: On 06/16/2016 12:06 PM, Pavel Vomacka wrote: Hello, please review attached patch. https://fedorahosted.org/freeipa/ticket/5905 Fixed commit message LGTM from user's perspective but I did not review the code. Code looks OK, applies well, but I did not test yet. So if Petr's LGTM is functional test ACK, then ACK from me. Pushed to master: cc6a3325d497286620cada12dca22fe5e5cf15e7 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
