[Freeipa-devel] [PATCH] 0074 Add requires
First part of ticket #855 Add the requires we will need on F15, tested against jdennis ipa-devel repo, works as expected. Simo. -- Simo Sorce * Red Hat, Inc * New York >From abe98c75d45630ecb8150c8b1deb11da8213f8e1 Mon Sep 17 00:00:00 2001 From: Simo Sorce Date: Wed, 26 Jan 2011 16:34:44 -0500 Subject: [PATCH 2/3] Add requires for the pki First part of: https://fedorahosted.org/freeipa/ticket/855 --- freeipa.spec.in |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/freeipa.spec.in b/freeipa.spec.in index 19b03f67e09305c5f30b62dec5363a5cbe55149f..5ebf30a765d0228df6813def1c01bed8a5413d42 100644 --- a/freeipa.spec.in +++ b/freeipa.spec.in @@ -88,6 +88,8 @@ Requires(post): selinux-policy-base Requires: slapi-nis >= 0.21 Requires: pki-ca >= 9.0.0 Requires: pki-silent >= 9.0.0 +Requires: dogtag-pki-common-theme +Requires: dogtag-pki-ca-theme Requires(preun): python initscripts chkconfig Requires(postun): python initscripts chkconfig -- 1.7.3.4 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 0074 Add requires
Simo Sorce wrote: > First part of ticket #855 > > Add the requires we will need on F15, tested against jdennis ipa-devel > repo, works as expected. > > Simo. The patch is obviously ok, so ack from this point of view. But I would just like to know if it is necessary. I just inspected F15 pki-ca package from nightly repo - it does Require pki-ca-theme >= 9.0.0 (which is provided by dogtag-pki-ca-theme) and we will be requiring pki-ca. I suspect similar situation will be for dogtag-pki-common-theme. So I don't see why we should explicitly Require both packages ourselves. Thanks in advance for explanation Jan ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 0074 Add requires
On Thu, 2011-01-27 at 11:27 +0100, Jan Zelený wrote: > Simo Sorce wrote: > > First part of ticket #855 > > > > Add the requires we will need on F15, tested against jdennis ipa-devel > > repo, works as expected. > > > > Simo. > > The patch is obviously ok, so ack from this point of view. But I would just > like to know if it is necessary. I just inspected F15 pki-ca package from > nightly repo - it does Require pki-ca-theme >= 9.0.0 (which is provided by > dogtag-pki-ca-theme) and we will be requiring pki-ca. I suspect similar > situation will be for dogtag-pki-common-theme. So I don't see why we should > explicitly Require both packages ourselves. > > Thanks in advance for explanation Sorry I don't know why they are needed I just implemented the ticket Rob opened. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 0074 Add requires
Simo Sorce wrote: On Thu, 2011-01-27 at 11:27 +0100, Jan Zelený wrote: Simo Sorce wrote: First part of ticket #855 Add the requires we will need on F15, tested against jdennis ipa-devel repo, works as expected. Simo. The patch is obviously ok, so ack from this point of view. But I would just like to know if it is necessary. I just inspected F15 pki-ca package from nightly repo - it does Require pki-ca-theme>= 9.0.0 (which is provided by dogtag-pki-ca-theme) and we will be requiring pki-ca. I suspect similar situation will be for dogtag-pki-common-theme. So I don't see why we should explicitly Require both packages ourselves. Thanks in advance for explanation Sorry I don't know why they are needed I just implemented the ticket Rob opened. Simo. I asked the same question before filing the ticket, here is the response: Actually, all three theme packages contain the exact same "Provides:" statements (e. g. - ipa-pki-common-theme "Provides: pki-common-theme" and dogtag-pki-common-theme "Provides: pki-common-theme") while the actual package pki-common "Requires: pki-common-theme"). For this reason, it is up to the end-user (in this case, FreeIPA and IPA) to decide which theme package will be installed (regardless of platform), and that is why we are suggesting that FreeIPA specifically "Requires: dogtag-pki-common-theme" and "Requires: dogtag-pki-ca-theme" while IPA v2 specifically "Requires: ipa-pki-common-theme" and "Requires: ipa-pki-ca-theme". For Fedora, although neither ipa nor redhat theme packages will be available, all three will potentially be available on RHEL platforms. To address this issue from the CS view, the original intention has (and will continue to be) to eventually resolve this by supplying Meta packages which require specific themes (e. g. - dogtag-pki, dogtag-pki-ca, redhat-pki, redhat-pki-ca, etc.), as currently, unless the FreeIPA and IPA applications specifically require specific theme packages, there are no packages which explicitly require a specific PKI theme package. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 0074 Add requires
On Thu, 2011-01-27 at 11:27 +0100, Jan Zelený wrote: > The patch is obviously ok, so ack from this point of view. Pushed to master. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 0074 Add requires
On 01/27/2011 05:27 AM, Jan Zelený wrote: Simo Sorce wrote: First part of ticket #855 Add the requires we will need on F15, tested against jdennis ipa-devel repo, works as expected. Simo. The patch is obviously ok, so ack from this point of view. But I would just like to know if it is necessary. I just inspected F15 pki-ca package from nightly repo - it does Require pki-ca-theme>= 9.0.0 (which is provided by dogtag-pki-ca-theme) and we will be requiring pki-ca. I suspect similar situation will be for dogtag-pki-common-theme. So I don't see why we should explicitly Require both packages ourselves. Have you seen the explanation that Matthew Harmsen put together about all the theme packages? I do not know if this would make things cleaner. I will send it off list. Thanks in advance for explanation Jan ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 0074 Add requires
Dmitri Pal wrote: > On 01/27/2011 05:27 AM, Jan Zelený wrote: > > Simo Sorce wrote: > >> First part of ticket #855 > >> > >> Add the requires we will need on F15, tested against jdennis ipa-devel > >> repo, works as expected. > >> > >> Simo. > > > > The patch is obviously ok, so ack from this point of view. But I would > > just like to know if it is necessary. I just inspected F15 pki-ca > > package from nightly repo - it does Require pki-ca-theme>= 9.0.0 (which > > is provided by dogtag-pki-ca-theme) and we will be requiring pki-ca. I > > suspect similar situation will be for dogtag-pki-common-theme. So I > > don't see why we should explicitly Require both packages ourselves. > > Have you seen the explanation that Matthew Harmsen put together about > all the theme packages? > I do not know if this would make things cleaner. > I will send it off list. Yes, I've read it and I understand now. Thanks for the info. Jan ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
