Re: [Freeipa-devel] [PATCH] 0088 Fix ipa winsync plugin

2011-03-01 Thread Simo Sorce 
On Mon, 28 Feb 2011 10:42:48 +0100
Jakub Hrozek jhro...@redhat.com wrote:

 On 02/26/2011 06:26 PM, Simo Sorce wrote:
  
  When the plugin was adjusted to not use LDAP_DEPRECATED it was
  broken and DNs where generated withouth the RDN attribute name part.
  
  Simo.

 
 I broke this one..
 
 Ack

Thanks.

Pushed to master.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0088 Fix ipa winsync plugin

2011-02-28 Thread Jakub Hrozek 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 02/26/2011 06:26 PM, Simo Sorce wrote:
 
 When the plugin was adjusted to not use LDAP_DEPRECATED it was broken
 and DNs where generated withouth the RDN attribute name part.
 
 Simo.
 

I broke this one..

Ack
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk1rbhgACgkQHsardTLnvCWn/gCeJv3Hdh2/hQCqvO/NClz1B9NN
kKUAn3jMzjhPETAdJQJsQPgE362ch1vY
=wDHg
-END PGP SIGNATURE-

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] 0088 Fix ipa winsync plugin

2011-02-26 Thread Simo Sorce 

When the plugin was adjusted to not use LDAP_DEPRECATED it was broken
and DNs where generated withouth the RDN attribute name part.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York
From 0fa84cf2ac08115da42418da917c056afcb9eedc Mon Sep 17 00:00:00 2001
From: Simo Sorce sso...@redhat.com
Date: Fri, 25 Feb 2011 13:11:34 -0500
Subject: [PATCH 3/8] Unbreak the ipa winsync plugin.

Fix RDN construction.

Fixes: https://fedorahosted.org/freeipa/ticket/1015
---
 .../ipa-slapi-plugins/ipa-winsync/ipa-winsync.c|2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/daemons/ipa-slapi-plugins/ipa-winsync/ipa-winsync.c b/daemons/ipa-slapi-plugins/ipa-winsync/ipa-winsync.c
index 2c0f4d1d2438420a95950cb72bded9288e3abf79..b98a34d1fdefd454e1c1eb600513176a39892b26 100644
--- a/daemons/ipa-slapi-plugins/ipa-winsync/ipa-winsync.c
+++ b/daemons/ipa-slapi-plugins/ipa-winsync/ipa-winsync.c
@@ -403,7 +403,7 @@ ipa_winsync_get_new_ds_user_dn_cb(void *cbdata, const Slapi_Entry *rawentry,
 return;
 }
 
-ldap_rdn2str(ldn[0], rdn, LDAP_DN_FORMAT_UFN);
+ldap_rdn2str(ldn[0], rdn, LDAP_DN_FORMAT_LDAPV3);
 *new_dn_string = slapi_ch_smprintf(%s,%s, rdn, slapi_sdn_get_dn(ds_suffix));
 ldap_dnfree(ldn);
 ldap_memfree(rdn);
-- 
1.7.4

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel