Re: [Freeipa-devel] [PATCH] 2 Call standard_logging_setup() before any logging is done

2011-09-13 Thread Martin Kosek
On Tue, 2011-09-13 at 12:44 +0200, Sumit Bose wrote:
> Hi,
> 
> in ipa-dns-install installutils.check_server_configuration() is called
> before standard_logging_setup() but already calls logging.debug() and
> all settings from standard_logging_setup() are ignored. The attached
> patch should fix it.
> 
> bye,
> Sumit

ACK. Pushed to master, ipa-2-1.

Martin

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


[Freeipa-devel] [PATCH] 2 Call standard_logging_setup() before any logging is done

2011-09-13 Thread Sumit Bose
Hi,

in ipa-dns-install installutils.check_server_configuration() is called
before standard_logging_setup() but already calls logging.debug() and
all settings from standard_logging_setup() are ignored. The attached
patch should fix it.

bye,
Sumit
From 4379fda4b40d0a8b76d2ec9ee960904d321acc2f Mon Sep 17 00:00:00 2001
From: Sumit Bose 
Date: Tue, 13 Sep 2011 12:37:47 +0200
Subject: [PATCH] Call standard_logging_setup() before any logging is done

---
 install/tools/ipa-dns-install |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/install/tools/ipa-dns-install b/install/tools/ipa-dns-install
index 
09006a2009c42a61ab80172637eeaf87a9db0635..9869eae8b143ee10e15fc811f9c1ab25aee77544
 100755
--- a/install/tools/ipa-dns-install
+++ b/install/tools/ipa-dns-install
@@ -87,14 +87,14 @@ def main():
 if os.getegid() != 0:
 sys.exit("Must be root to setup server")
 
-installutils.check_server_configuration()
-
 standard_logging_setup("/var/log/ipaserver-install.log", options.debug, 
filemode='a')
 print "\nThe log file for this installation can be found in 
/var/log/ipaserver-install.log"
 
 logging.debug('%s was invoked with options: %s' % (sys.argv[0], 
safe_options))
 logging.debug("missing options might be asked for interactively later\n")
 
+installutils.check_server_configuration()
+
 global fstore
 fstore = sysrestore.FileStore('/var/lib/ipa/sysrestore')
 
-- 
1.7.6

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel