Re: [Freeipa-devel] [PATCH] 418 Make ssbrowser.html work in IE 10

2013-06-04 Thread Petr Vobornik

On 06/03/2013 06:18 PM, Ana Krivokapic wrote:

On 05/29/2013 01:15 PM, Petr Vobornik wrote:

Manual configuration page for other browsers (ssbrowser.html) doesn't
work in IE 10 - error page is displayed.

This patch is conditioning creation of Firefox configuration object so
that configure.jar is requested only in Firefox. IE doesn't request it
and so it does not fail.

https://fedorahosted.org/freeipa/ticket/3645




ACK

--
Regards,

Ana Krivokapic


Pushed to master, ipa-3-2

--
Petr Vobornik

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] 418 Make ssbrowser.html work in IE 10

2013-06-03 Thread Ana Krivokapic
On 05/29/2013 01:15 PM, Petr Vobornik wrote:
 Manual configuration page for other browsers (ssbrowser.html) doesn't
 work in IE 10 - error page is displayed.

 This patch is conditioning creation of Firefox configuration object so
 that configure.jar is requested only in Firefox. IE doesn't request it
 and so it does not fail.

 https://fedorahosted.org/freeipa/ticket/3645


 ___
 Freeipa-devel mailing list
 Freeipa-devel@redhat.com
 https://www.redhat.com/mailman/listinfo/freeipa-devel

ACK

-- 
Regards,

Ana Krivokapic
Associate Software Engineer
FreeIPA team
Red Hat Inc.

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] 418 Make ssbrowser.html work in IE 10

2013-05-29 Thread Petr Vobornik
Manual configuration page for other browsers (ssbrowser.html) doesn't 
work in IE 10 - error page is displayed.


This patch is conditioning creation of Firefox configuration object so 
that configure.jar is requested only in Firefox. IE doesn't request it 
and so it does not fail.


https://fedorahosted.org/freeipa/ticket/3645
--
Petr Vobornik
From af2c2fb00e0146f60ad31f17fba25be5e89120af Mon Sep 17 00:00:00 2001
From: Petr Vobornik pvobo...@redhat.com
Date: Wed, 29 May 2013 13:06:11 +0200
Subject: [PATCH] Make ssbrowser.html work in IE 10

Manual configuration page for other browsers (ssbrowser.html) doesn't work in IE 10 - error page is displayed.

This patch is conditioning creation of Firefox configuration object so that configure.jar is requested only in Firefox. IE doesn't request it and so it does not fail.

https://fedorahosted.org/freeipa/ticket/3645
---
 install/html/ssbrowser.html | 12 +---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/install/html/ssbrowser.html b/install/html/ssbrowser.html
index 2afb0facf5c112d6595fbf2f9d2d81e6e5eb61df..72fd573cf907e7ce3a27a17a2857633480cff9de 100644
--- a/install/html/ssbrowser.html
+++ b/install/html/ssbrowser.html
@@ -16,7 +16,14 @@
 $('.example-domain').text(domain);
 
 if ($.browser.mozilla) {
-$(#configurefirefox).show();
+var ff_config = $(#configurefirefox);
+var obj = $('object/', {
+type: 'text/html',
+'class': 'browser-config'
+});
+obj.prop('data', 'jar:/ipa/errors/configure.jar!/preferences.html');
+obj.appendTo(ff_config);
+ff_config.show();
 }
 });
 /script
@@ -72,8 +79,7 @@
 ul
 li1. Import a href=ca.crtCA certificate/a. Make sure you checked all three checkboxes./li
 li2. Click on Configure Browser button below./li
-li id=configurefirefox style=display:noneobject data=jar:/ipa/errors/configure.jar!/preferences.html
-type=text/html class=browser-config/object/li
+li id=configurefirefox style=display:none/li
 /ul
 /div
 
-- 
1.8.1.4

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel