Re: [Freeipa-devel] [PATCH] 518 handle errors in uninstall better

2010-09-07 Thread Rob Crittenden

Dmitri Pal wrote:

Adam Young wrote:

On 08/31/2010 05:27 PM, Rob Crittenden wrote:

# Always start certmonger. We can't untrack something if it isn't

Is this really necessary? This is the only thing that jumped out at me
in the patch.

Assuming it really is: Ack


I have not looked at the patch but I suspect that it is related to the
fact that we plan to automatically track the expiration of the certs
issued to the server itself. So yes we need to have certmonger running
all the time thus comment makes sense to me.


I did this in case the user has stopped certmonger. If we try to use the 
ipa-getcert command with the certmonger service stopped a DBUS error 
will be thrown. Trying to start a running service is a no-op so it 
doesn't hurt anything.


This patch relies on unreviewed patch 512, I need to get that one acked 
before I can push this one.


rob

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] 518 handle errors in uninstall better

2010-09-01 Thread Dmitri Pal
Adam Young wrote:
 On 08/31/2010 05:27 PM, Rob Crittenden wrote:
 # Always start certmonger. We can't untrack something if it isn't
 Is this really necessary? This is the only thing that jumped out at me
 in the patch.

 Assuming it really is: Ack

I have not looked at the patch but I suspect that it is related to the
fact that we plan to automatically track the expiration of the certs
issued to the server itself. So yes we need to have certmonger running
all the time thus comment makes sense to me.


 ___
 Freeipa-devel mailing list
 Freeipa-devel@redhat.com
 https://www.redhat.com/mailman/listinfo/freeipa-devel




-- 
Thank you,
Dmitri Pal

Engineering Manager IPA project,
Red Hat Inc.


---
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel