Re: [Freeipa-devel] [PATCH] 737 move BuildRequires

2011-02-22 Thread Jakub Hrozek 
On Tue, Feb 22, 2011 at 10:34:35AM +0100, Jan Zeleny wrote:
 Rob Crittenden rcrit...@redhat.com wrote:
  Move some BuildRequires so building with ONLY_CLIENT works.
  
  I tested with:
  
  $ mock -r fedora-14-x86_64 --define='ONLY_CLIENT 1'
  ./dist/srpms/freeipa-2.0.0GIT055a668-0.fc14.src.rpm
  
  rob
 
 I'm a little confused. Some of the lines are only moved a couple lines above 
 their original location (like python-ldap for instance).
 
 Does this really have an impact on building? The only three lines I undestand 
 are those first three.
 

Note the %else.

Koji scratch build of client worked fine:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2856864

Ack

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 737 move BuildRequires

2011-02-22 Thread Jakub Hrozek 
On Tue, Feb 22, 2011 at 11:21:41AM +0100, Jakub Hrozek wrote:
 Note the %else.
 

Sorry, %endif. That separates BRs for !ONLY_CLIENT from those that are
needed in both cases.

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 737 move BuildRequires

2011-02-22 Thread Jan Zelený 
Jakub Hrozek jhro...@redhat.com wrote:
 On Tue, Feb 22, 2011 at 11:21:41AM +0100, Jakub Hrozek wrote:
  Note the %else.
 
 Sorry, %endif. That separates BRs for !ONLY_CLIENT from those that are
 needed in both cases.

Yes I noticed that and I understand that part. I meant the part after the 
%endif - there is no need to move those dependencies. On the other hand it's 
definitely not a patch-blocker or something, so I give this patch ACK.

Jan

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 737 move BuildRequires

2011-02-22 Thread Rob Crittenden 

Jan Zelený wrote:

Jakub Hrozekjhro...@redhat.com  wrote:

On Tue, Feb 22, 2011 at 11:21:41AM +0100, Jakub Hrozek wrote:

Note the %else.


Sorry, %endif. That separates BRs for !ONLY_CLIENT from those that are
needed in both cases.


Yes I noticed that and I understand that part. I meant the part after the
%endif - there is no need to move those dependencies. On the other hand it's
definitely not a patch-blocker or something, so I give this patch ACK.

Jan


pushed to master

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 737 move BuildRequires

2011-02-22 Thread Rob Crittenden 

Jan Zeleny wrote:

Rob Crittendenrcrit...@redhat.com  wrote:

Move some BuildRequires so building with ONLY_CLIENT works.

I tested with:

$ mock -r fedora-14-x86_64 --define='ONLY_CLIENT 1'
./dist/srpms/freeipa-2.0.0GIT055a668-0.fc14.src.rpm

rob


I'm a little confused. Some of the lines are only moved a couple lines above
their original location (like python-ldap for instance).

Does this really have an impact on building? The only three lines I undestand
are those first three.

Thanks for explanation

Jan


I had already sone a similar change in another spec I maintain and pull 
them out one at a time until it built properly, thus I didn't maintain 
order.


What this does is it pulls most of the requires out of the ! ONLY_CLIENT 
conditional.


rob

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] 737 move BuildRequires

2011-02-21 Thread Rob Crittenden 

Move some BuildRequires so building with ONLY_CLIENT works.

I tested with:

$ mock -r fedora-14-x86_64 --define='ONLY_CLIENT 1' 
./dist/srpms/freeipa-2.0.0GIT055a668-0.fc14.src.rpm


rob


freeipa-rcrit-737-spec.patch
Description: application/mbox
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel