Re: [Freeipa-devel] [PATCH] 853 remove upgrade state when uninstalling
Adam Young wrote: On 08/24/2011 11:38 AM, Rob Crittenden wrote: The upgrade process makes saves some information in the IPA sysrestore state. If any of this state remains after an uninstall then you will get an error during re-install. Theoretically all this state should be removed as part of the upgrade process but on the outside chance, lets remove the state at uninstall to prevent problems. I've had just one report of this, it may have been due to a blown upgrade, I'm not sure. I've been unable to reproduce it but at worst this is a noop and at best allows easy re-installation. This requires patch 852. rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK pushed to master ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 853 remove upgrade state when uninstalling
On 08/24/2011 11:38 AM, Rob Crittenden wrote: The upgrade process makes saves some information in the IPA sysrestore state. If any of this state remains after an uninstall then you will get an error during re-install. Theoretically all this state should be removed as part of the upgrade process but on the outside chance, lets remove the state at uninstall to prevent problems. I've had just one report of this, it may have been due to a blown upgrade, I'm not sure. I've been unable to reproduce it but at worst this is a noop and at best allows easy re-installation. This requires patch 852. rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 853 remove upgrade state when uninstalling
Adam Young wrote: On 08/24/2011 11:38 AM, Rob Crittenden wrote: The upgrade process makes saves some information in the IPA sysrestore state. If any of this state remains after an uninstall then you will get an error during re-install. Theoretically all this state should be removed as part of the upgrade process but on the outside chance, lets remove the state at uninstall to prevent problems. I've had just one report of this, it may have been due to a blown upgrade, I'm not sure. I've been unable to reproduce it but at worst this is a noop and at best allows easy re-installation. This requires patch 852. rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel So my latest patch changes .etc.httpd/nss.conf. Is this an appropriate approach for that file as well? No, we back up the entire file. It should get restored to its previous state on uninstall. rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 853 remove upgrade state when uninstalling
On 08/24/2011 11:38 AM, Rob Crittenden wrote: The upgrade process makes saves some information in the IPA sysrestore state. If any of this state remains after an uninstall then you will get an error during re-install. Theoretically all this state should be removed as part of the upgrade process but on the outside chance, lets remove the state at uninstall to prevent problems. I've had just one report of this, it may have been due to a blown upgrade, I'm not sure. I've been unable to reproduce it but at worst this is a noop and at best allows easy re-installation. This requires patch 852. rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel So my latest patch changes .etc.httpd/nss.conf. Is this an appropriate approach for that file as well? ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
[Freeipa-devel] [PATCH] 853 remove upgrade state when uninstalling
The upgrade process makes saves some information in the IPA sysrestore
state. If any of this state remains after an uninstall then you will get
an error during re-install. Theoretically all this state should be
removed as part of the upgrade process but on the outside chance, lets
remove the state at uninstall to prevent problems.
I've had just one report of this, it may have been due to a blown
upgrade, I'm not sure. I've been unable to reproduce it but at worst
this is a noop and at best allows easy re-installation.
This requires patch 852.
rob
>From 915f2df4ec84a07dbde7c2738f4ab314721d67df Mon Sep 17 00:00:00 2001
From: Rob Crittenden
Date: Wed, 24 Aug 2011 11:28:20 -0400
Subject: [PATCH] Remove 389-ds upgrade state during uninstall
When we perform an upgrade 389-ds is set to listen only on its
ldapi port. Theoretically it should be restored to the previous
state regardless of whether the upgrades were successful or not.
To be sure that a subsequent re-install will be successful go ahead
and remove the state for these options. Think of it as wearing a
belt and suspenders. Otherwise a re-install could return an error
message that IPA is already configured.
https://fedorahosted.org/freeipa/ticket/1667
---
ipaserver/install/dsinstance.py |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/ipaserver/install/dsinstance.py b/ipaserver/install/dsinstance.py
index df6024a..ad3a3e6 100644
--- a/ipaserver/install/dsinstance.py
+++ b/ipaserver/install/dsinstance.py
@@ -683,6 +683,12 @@ class DsInstance(service.Service):
except ipautil.CalledProcessError, e:
logging.critical("failed to delete user %s" % e)
+# Make sure some upgrade-related state is removed. This could cause
+# re-installation problems.
+self.restore_state('nsslapd-port')
+self.restore_state('nsslapd-security')
+self.restore_state('nsslapd-ldapiautobind')
+
if self.restore_state("running"):
self.start()
--
1.7.4
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
