Re: [Freeipa-devel] [PATCH] 875 topology: fix swapped topologysegment-reinitialize behavior

2015-06-15 Thread Petr Vobornik

On 06/12/2015 06:31 PM, Martin Babinsky wrote:

On 06/12/2015 04:19 PM, Petr Vobornik wrote:

setting nsds5BeginReplicaRefresh;left to start reinintializes the
right node and not the left node. This patch fixes API to match the
behavior.

part of: https://fedorahosted.org/freeipa/ticket/4302



ACK



Pushed to master: bb6c0b9c634f26ae5d16079b3a66841ac0ce60cc
--
Petr Vobornik

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code


[Freeipa-devel] [PATCH] 875 topology: fix swapped topologysegment-reinitialize behavior

2015-06-12 Thread Petr Vobornik

setting nsds5BeginReplicaRefresh;left to start reinintializes the
right node and not the left node. This patch fixes API to match the
behavior.

part of: https://fedorahosted.org/freeipa/ticket/4302
--
Petr Vobornik
From 63d7541247985a22463857110befdfc3394b25f7 Mon Sep 17 00:00:00 2001
From: Petr Vobornik pvobo...@redhat.com
Date: Fri, 12 Jun 2015 15:59:48 +0200
Subject: [PATCH] topology: fix swapped topologysegment-reinitialize behavior

setting nsds5BeginReplicaRefresh;left to start reinintializes the
right node and not the left node. This patch fixes API to match the
behavior.

part of: https://fedorahosted.org/freeipa/ticket/4302
---
 ipalib/plugins/topology.py | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/ipalib/plugins/topology.py b/ipalib/plugins/topology.py
index be2ac0bd23dd074536cbd098cb90d12b208de499..494d3bb0a564e5c8ef3d7c2af50dbf1e83a36e1f 100644
--- a/ipalib/plugins/topology.py
+++ b/ipalib/plugins/topology.py
@@ -294,9 +294,11 @@ class topologysegment_reinitialize(LDAPQuery):
 msg = _('Stopping of replication refresh for segment: '
 '%(pkey)s requested.')
 
-if left:
-entry['nsds5beginreplicarefresh;left'] = [action]
+# left and right are swapped because internally it's a push not
+# pull operation
 if right:
+entry['nsds5beginreplicarefresh;left'] = [action]
+if left:
 entry['nsds5beginreplicarefresh;right'] = [action]
 
 self.obj.backend.update_entry(entry)
-- 
2.1.0

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH] 875 topology: fix swapped topologysegment-reinitialize behavior

2015-06-12 Thread Martin Babinsky

On 06/12/2015 04:19 PM, Petr Vobornik wrote:

setting nsds5BeginReplicaRefresh;left to start reinintializes the
right node and not the left node. This patch fixes API to match the
behavior.

part of: https://fedorahosted.org/freeipa/ticket/4302



ACK

--
Martin^3 Babinsky

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code