Re: [Freeipa-devel] [PATCH] Fix format string typo

2013-06-10 Thread Martin Kosek 
On 06/07/2013 06:20 PM, Sumit Bose wrote:
 On Tue, Jun 04, 2013 at 10:56:59AM +0200, Sumit Bose wrote:
 On Tue, Jun 04, 2013 at 10:49:45AM +0200, Petr Viktorin wrote:
 On 06/03/2013 03:41 PM, Martin Kosek wrote:
 On 06/03/2013 03:39 PM, Sumit Bose wrote:
 Hi,

 this patch just fixes a typo.

 bye,
 Sumit


 Obvious ACK. Pushed to master, ipa-3-2.

 Martin

 Is the patch really right? It caused a new compiler warning:

 format '%lu' expects argument of type 'long unsigned int', but
 argument 6 has type 'uint32_t' [-Wformat=]

 ah, sorry, I didn't check the compiler output carefully enough, I'll
 send a fix.
 
 sorry, for the delay, fix attached.
 
 bye,
 Sumit

Thanks! I tested it and it fixed the FreeIPA build warning.

ACK. Pushed to master, ipa-3-2.

Martin

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] Fix format string typo

2013-06-07 Thread Sumit Bose 
On Tue, Jun 04, 2013 at 10:56:59AM +0200, Sumit Bose wrote:
 On Tue, Jun 04, 2013 at 10:49:45AM +0200, Petr Viktorin wrote:
  On 06/03/2013 03:41 PM, Martin Kosek wrote:
  On 06/03/2013 03:39 PM, Sumit Bose wrote:
  Hi,
  
  this patch just fixes a typo.
  
  bye,
  Sumit
  
  
  Obvious ACK. Pushed to master, ipa-3-2.
  
  Martin
  
  Is the patch really right? It caused a new compiler warning:
  
  format '%lu' expects argument of type 'long unsigned int', but
  argument 6 has type 'uint32_t' [-Wformat=]
 
 ah, sorry, I didn't check the compiler output carefully enough, I'll
 send a fix.

sorry, for the delay, fix attached.

bye,
Sumit
 
 bye,
 Sumit
  
  -- 
  Petr³
 
 ___
 Freeipa-devel mailing list
 Freeipa-devel@redhat.com
 https://www.redhat.com/mailman/listinfo/freeipa-devel
From 1bbf2626a0ef5c127b35e700e7eb2e2feec6659e Mon Sep 17 00:00:00 2001
From: Sumit Bose sb...@redhat.com
Date: Fri, 7 Jun 2013 18:17:55 +0200
Subject: [PATCH] Fix type of printf argument

---
 daemons/ipa-slapi-plugins/ipa-sidgen/ipa_sidgen_common.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/daemons/ipa-slapi-plugins/ipa-sidgen/ipa_sidgen_common.c 
b/daemons/ipa-slapi-plugins/ipa-sidgen/ipa_sidgen_common.c
index 
fafc55a497620024e45186b48ed84029e273f5ef..6f784804cd39acdf88ceceb0e21b272a04fa13fc
 100644
--- a/daemons/ipa-slapi-plugins/ipa-sidgen/ipa_sidgen_common.c
+++ b/daemons/ipa-slapi-plugins/ipa-sidgen/ipa_sidgen_common.c
@@ -518,7 +518,8 @@ int find_sid_for_ldap_entry(struct slapi_entry *entry,
 
 ret = find_sid_for_id(id, plugin_id, base_dn, dom_sid, ranges, sid);
 if (ret != 0) {
-LOG_FATAL(Cannot convert Posix ID [%lu] into an unused SID.\n, id);
+LOG_FATAL(Cannot convert Posix ID [%lu] into an unused SID.\n,
+  (unsigned long) id);
 goto done;
 }
 
-- 
1.8.1.4

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] Fix format string typo

2013-06-04 Thread Petr Viktorin 

On 06/03/2013 03:41 PM, Martin Kosek wrote:

On 06/03/2013 03:39 PM, Sumit Bose wrote:

Hi,

this patch just fixes a typo.

bye,
Sumit



Obvious ACK. Pushed to master, ipa-3-2.

Martin


Is the patch really right? It caused a new compiler warning:

format '%lu' expects argument of type 'long unsigned int', but argument 
6 has type 'uint32_t' [-Wformat=]


--
Petr³

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] Fix format string typo

2013-06-04 Thread Sumit Bose 
On Tue, Jun 04, 2013 at 10:49:45AM +0200, Petr Viktorin wrote:
 On 06/03/2013 03:41 PM, Martin Kosek wrote:
 On 06/03/2013 03:39 PM, Sumit Bose wrote:
 Hi,
 
 this patch just fixes a typo.
 
 bye,
 Sumit
 
 
 Obvious ACK. Pushed to master, ipa-3-2.
 
 Martin
 
 Is the patch really right? It caused a new compiler warning:
 
 format '%lu' expects argument of type 'long unsigned int', but
 argument 6 has type 'uint32_t' [-Wformat=]

ah, sorry, I didn't check the compiler output carefully enough, I'll
send a fix.

bye,
Sumit
 
 -- 
 Petr³

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] Fix format string typo

2013-06-03 Thread Sumit Bose 
Hi,

this patch just fixes a typo.

bye,
Sumit
From b4bf2704175de6ddf961e7447c57c5ced8cc0c5a Mon Sep 17 00:00:00 2001
From: Sumit Bose sb...@redhat.com
Date: Mon, 3 Jun 2013 14:05:03 +0200
Subject: [PATCH] Fix format string typo

---
 daemons/ipa-slapi-plugins/ipa-sidgen/ipa_sidgen_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/daemons/ipa-slapi-plugins/ipa-sidgen/ipa_sidgen_common.c 
b/daemons/ipa-slapi-plugins/ipa-sidgen/ipa_sidgen_common.c
index 
d7e6ac39a57ce26cf6ac7196a1797c44e5a65f77..fafc55a497620024e45186b48ed84029e273f5ef
 100644
--- a/daemons/ipa-slapi-plugins/ipa-sidgen/ipa_sidgen_common.c
+++ b/daemons/ipa-slapi-plugins/ipa-sidgen/ipa_sidgen_common.c
@@ -518,7 +518,7 @@ int find_sid_for_ldap_entry(struct slapi_entry *entry,
 
 ret = find_sid_for_id(id, plugin_id, base_dn, dom_sid, ranges, sid);
 if (ret != 0) {
-LOG_FATAL(Cannot convert Posix ID [%ul] into an unused SID.\n, id);
+LOG_FATAL(Cannot convert Posix ID [%lu] into an unused SID.\n, id);
 goto done;
 }
 
-- 
1.8.1.4

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] Fix format string typo

2013-06-03 Thread Martin Kosek 
On 06/03/2013 03:39 PM, Sumit Bose wrote:
 Hi,
 
 this patch just fixes a typo.
 
 bye,
 Sumit
 

Obvious ACK. Pushed to master, ipa-3-2.

Martin

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel