Re: [Freeipa-devel] [PATCH] Fix setattr mail bug in user plugin.

2011-02-15 Thread Martin Kosek
ACK.

Martin

On Tue, 2011-02-15 at 16:18 +0100, Pavel Zuna wrote:
 The email normalizer expects a list or tuple, but when using setattr it gets 
 a 
 string and interates on it as if it was a list/tuple.
 
 Before patch:
 
 [root@ipadev freeipa]# ./ipa user-mod testuser --setattr 
 mail=testu...@example.com
 
 Modified user testuser
 
User login: testuser
First name: f
Last name: l
Home directory: /home/testuser
Login shell: /bin/sh
Email address: c@pzuna, @, x@pzuna, o@pzuna, .@pzuna, t@pzuna, e@pzuna, 
 s@pzuna, r@pzuna, a@pzuna, m@pzuna, p@pzuna, u@pzuna, l@pzuna
Account disabled: False
Member of groups: ipausers
 
 
 Pavel


___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] Fix setattr mail bug in user plugin.

2011-02-15 Thread Adam Young

On 02/15/2011 10:56 AM, Martin Kosek wrote:

ACK.

Martin

On Tue, 2011-02-15 at 16:18 +0100, Pavel Zuna wrote:

The email normalizer expects a list or tuple, but when using setattr it gets a
string and interates on it as if it was a list/tuple.

Before patch:

[root@ipadev freeipa]# ./ipa user-mod testuser --setattr 
mail=testu...@example.com

Modified user testuser

User login: testuser
First name: f
Last name: l
Home directory: /home/testuser
Login shell: /bin/sh
Email address: c@pzuna, @, x@pzuna, o@pzuna, .@pzuna, t@pzuna, e@pzuna,
s@pzuna, r@pzuna, a@pzuna, m@pzuna, p@pzuna, u@pzuna, l@pzuna
Account disabled: False
Member of groups: ipausers


Pavel


___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Pushed to master

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel