Re: [Freeipa-devel] [PATCH] Fixed command delegation-show

2011-02-07 Thread Jan Zelený
Jakub Hrozek  wrote:
> On Fri, Feb 04, 2011 at 06:40:54PM +0100, Jan Zeleny wrote:
> > Recent changes in permission prefixes influenced also delegations. The
> > plugin has been updated accordingly, but this one line has been
> > forgotten.
> > 
> > Jan
> 
> I think it is not needed, the only command preceding return from the
> function is is_delegation() that has the value of aciprefix hardcoded.
> 
> Jakub

Sorry, withdrawing the patch. I originally made it because delegation-show 
didn't work for me, but it was probably only typo on the command line or 
something. The code is indeed ok. Thanks for catching that.

Jan

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] Fixed command delegation-show

2011-02-07 Thread Jakub Hrozek
On Fri, Feb 04, 2011 at 06:40:54PM +0100, Jan Zeleny wrote:
> Recent changes in permission prefixes influenced also delegations. The
> plugin has been updated accordingly, but this one line has been
> forgotten.
> 
> Jan

I think it is not needed, the only command preceding return from the
function is is_delegation() that has the value of aciprefix hardcoded.

Jakub

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


[Freeipa-devel] [PATCH] Fixed command delegation-show

2011-02-04 Thread Jan Zeleny
Recent changes in permission prefixes influenced also delegations. The
plugin has been updated accordingly, but this one line has been
forgotten.

Jan
From e3bfaee5c71aa1e39ac23268e3029c283c60ce9e Mon Sep 17 00:00:00 2001
From: Jan Zeleny 
Date: Fri, 4 Feb 2011 12:37:28 -0500
Subject: [PATCH] Fixed command delegation-show

Recent changes in permission prefixes influenced also delegations. The
plugin has been updated accordingly, but this one line has been
forgotten.
---
 ipalib/plugins/delegation.py |1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/ipalib/plugins/delegation.py b/ipalib/plugins/delegation.py
index 8ea0af9cfd14555b6c9bf10a6bf2ed462b8f16be..7db03a6b6b2757f31821ad5171d7d745b2b41fbd 100644
--- a/ipalib/plugins/delegation.py
+++ b/ipalib/plugins/delegation.py
@@ -258,6 +258,7 @@ class delegation_show(crud.Retrieve):
 
 def execute(self, aciname, **kw):
 ldap = self.api.Backend.ldap2
+kw['aciprefix'] = ACI_PREFIX
 result = is_delegation(ldap, aciname)
 return dict(
 result=result,
-- 
1.7.4

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel