Re: [Freeipa-devel] [PATCH] Normalize manager name in user-add
On 11/05/2015 03:25 PM, Martin Basti wrote: On 05.11.2015 07:58, Abhijeet Kasurde wrote: Hi All, Please find the patch for https://fedorahosted.org/freeipa/ticket/5387 Thanks, Abhijeet Kasurde Hello, I'm sorry I forgot to mark "patch posted for review", but the ticket is marked as assigned, that means the somebody (me in this case) is working on it. I posted patch 332. Due the ticket https://fedorahosted.org/freeipa/ticket/5344 I will change multiple parts of user plugin code, and the normalization of manager will be done in different way. So even my patch 332 is not valid anymore. No issues. Thanks for your time. -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH] Normalize manager name in user-add
On 05.11.2015 07:58, Abhijeet Kasurde wrote: Hi All, Please find the patch for https://fedorahosted.org/freeipa/ticket/5387 Thanks, Abhijeet Kasurde Hello, I'm sorry I forgot to mark "patch posted for review", but the ticket is marked as assigned, that means the somebody (me in this case) is working on it. I posted patch 332. Due the ticket https://fedorahosted.org/freeipa/ticket/5344 I will change multiple parts of user plugin code, and the normalization of manager will be done in different way. So even my patch 332 is not valid anymore. -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [PATCH] Normalize manager name in user-add
Hi All, Please find the patch for https://fedorahosted.org/freeipa/ticket/5387 Thanks, Abhijeet Kasurde From 4be9fef17e6b31ad2b3ebb496d4a60887ca97b5c Mon Sep 17 00:00:00 2001 From: Abhijeet Kasurde Date: Thu, 5 Nov 2015 12:22:59 +0530 Subject: [PATCH] Added fix to normalize manager name in user-add This fix allows to normalize manager name to human readable name as specified in user-add command instead of actual DN. Fixes: https://fedorahosted.org/freeipa/ticket/5387 Signed-off-by: Abhijeet Kasurde --- ipalib/plugins/baseuser.py | 1 + 1 file changed, 1 insertion(+) diff --git a/ipalib/plugins/baseuser.py b/ipalib/plugins/baseuser.py index b974e3fb18659e7eb6e75557e0d4db3ec1197dcd..a22923048002e1ac38cf007e871d7ee8ffc44da1 100644 --- a/ipalib/plugins/baseuser.py +++ b/ipalib/plugins/baseuser.py @@ -490,6 +490,7 @@ class baseuser_add(LDAPCreate): def post_common_callback(self, ldap, dn, entry_attrs, **options): assert isinstance(dn, DN) +self.obj.convert_manager(entry_attrs, **options) self.obj.convert_usercertificate_post(entry_attrs, **options) class baseuser_del(LDAPDelete): -- 2.4.3 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code