Re: [Freeipa-devel] [PATCH 0003] Fix several small typos
On 26.07.2016 11:55, Petr Spacek wrote: On 25.7.2016 17:00, Ben Lipton wrote: On 07/18/2016 04:54 PM, Lukas Slebodnik wrote: On (18/07/16 16:38), Petr Spacek wrote: On 14.7.2016 16:11, Ben Lipton wrote: On 07/14/2016 04:09 AM, Alexander Bokovoy wrote: On Wed, 13 Jul 2016, Ben Lipton wrote: Nothing too exciting, just fixes a few typos I've noticed in comments. ACK. However, please file a ticket and mention it in the commit message. Is it worth the bureaucracy? I do not think so. We will certainly not backport typo fixes in comments to older branches so I would say that ticket is useless. Just my two cents. +1 LS Necessary or not, as the ticket is created now, any objection to pushing the patch? ACK Pushed to master: 99a702568d1bcaad2c0d1f83fdc2b485958b6e3d -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH 0003] Fix several small typos
On 25.7.2016 17:00, Ben Lipton wrote: > On 07/18/2016 04:54 PM, Lukas Slebodnik wrote: >> On (18/07/16 16:38), Petr Spacek wrote: >>> On 14.7.2016 16:11, Ben Lipton wrote: On 07/14/2016 04:09 AM, Alexander Bokovoy wrote: > On Wed, 13 Jul 2016, Ben Lipton wrote: >> Nothing too exciting, just fixes a few typos I've noticed in comments. > ACK. However, please file a ticket and mention it in the commit message. >>> Is it worth the bureaucracy? I do not think so. We will certainly not >>> backport >>> typo fixes in comments to older branches so I would say that ticket is >>> useless. >>> >>> Just my two cents. >>> >> +1 >> >> LS >> > Necessary or not, as the ticket is created now, any objection to pushing the > patch? ACK -- Petr^2 Spacek -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH 0003] Fix several small typos
On 07/18/2016 04:54 PM, Lukas Slebodnik wrote: On (18/07/16 16:38), Petr Spacek wrote: On 14.7.2016 16:11, Ben Lipton wrote: On 07/14/2016 04:09 AM, Alexander Bokovoy wrote: On Wed, 13 Jul 2016, Ben Lipton wrote: Nothing too exciting, just fixes a few typos I've noticed in comments. ACK. However, please file a ticket and mention it in the commit message. Is it worth the bureaucracy? I do not think so. We will certainly not backport typo fixes in comments to older branches so I would say that ticket is useless. Just my two cents. +1 LS Necessary or not, as the ticket is created now, any objection to pushing the patch? Ben -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH 0003] Fix several small typos
On (18/07/16 16:38), Petr Spacek wrote: >On 14.7.2016 16:11, Ben Lipton wrote: >> On 07/14/2016 04:09 AM, Alexander Bokovoy wrote: >>> On Wed, 13 Jul 2016, Ben Lipton wrote: Nothing too exciting, just fixes a few typos I've noticed in comments. >>> ACK. However, please file a ticket and mention it in the commit message. > >Is it worth the bureaucracy? I do not think so. We will certainly not backport >typo fixes in comments to older branches so I would say that ticket is useless. > >Just my two cents. > +1 LS -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH 0003] Fix several small typos
On 14.7.2016 16:11, Ben Lipton wrote: > On 07/14/2016 04:09 AM, Alexander Bokovoy wrote: >> On Wed, 13 Jul 2016, Ben Lipton wrote: >>> Nothing too exciting, just fixes a few typos I've noticed in comments. >> ACK. However, please file a ticket and mention it in the commit message. Is it worth the bureaucracy? I do not think so. We will certainly not backport typo fixes in comments to older branches so I would say that ticket is useless. Just my two cents. -- Petr^2 Spacek -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH 0003] Fix several small typos
On 07/14/2016 04:09 AM, Alexander Bokovoy wrote: On Wed, 13 Jul 2016, Ben Lipton wrote: Nothing too exciting, just fixes a few typos I've noticed in comments. ACK. However, please file a ticket and mention it in the commit message. Thanks, updated patch attached. From a9916a5ce1447417dcbf2c00a9024775d0a30e17 Mon Sep 17 00:00:00 2001 From: Ben Lipton Date: Fri, 8 Jul 2016 11:41:43 -0400 Subject: [PATCH] Fix several small typos Fixes: https://fedorahosted.org/freeipa/ticket/6085 --- ipatests/test_xmlrpc/tracker/base.py| 2 +- ipatests/test_xmlrpc/tracker/user_plugin.py | 2 +- ipatests/test_xmlrpc/xmlrpc_test.py | 5 +++-- ipatests/util.py| 2 +- 4 files changed, 6 insertions(+), 5 deletions(-) diff --git a/ipatests/test_xmlrpc/tracker/base.py b/ipatests/test_xmlrpc/tracker/base.py index 6a0af510f52aa1d7ccd94450c0848149d9abab48..f7fc55d54b6bcd31308d3eaaea9dffb0228e38bf 100644 --- a/ipatests/test_xmlrpc/tracker/base.py +++ b/ipatests/test_xmlrpc/tracker/base.py @@ -289,5 +289,5 @@ class Tracker(object): set(expected_updates.keys())) def check_update(self, result, extra_keys=()): -"""Check the plugin's `find` command result""" +"""Check the plugin's `mod` command result""" raise NotImplementedError(self._override_me_msg) diff --git a/ipatests/test_xmlrpc/tracker/user_plugin.py b/ipatests/test_xmlrpc/tracker/user_plugin.py index 1a85e93327e5d517249fd67e208e83a922509002..10093a9530dbdd57b53e412ad6c4d4f2e6174fd5 100644 --- a/ipatests/test_xmlrpc/tracker/user_plugin.py +++ b/ipatests/test_xmlrpc/tracker/user_plugin.py @@ -184,7 +184,7 @@ class UserTracker(Tracker): Overriding Tracker method for setting self.attrs correctly; * most attributes stores its value in list * the rest can be overridden by expected_updates - * allow deleting parametrs if update value is None + * allow deleting parameters if update value is None """ if expected_updates is None: expected_updates = {} diff --git a/ipatests/test_xmlrpc/xmlrpc_test.py b/ipatests/test_xmlrpc/xmlrpc_test.py index ddfe9c17c5ca110bc5eb66dead618383b861eda9..78d96388d36f586a3f95c7dffd7a072da43b1f81 100644 --- a/ipatests/test_xmlrpc/xmlrpc_test.py +++ b/ipatests/test_xmlrpc/xmlrpc_test.py @@ -97,8 +97,9 @@ fuzzy_issuer = Fuzzy(type=six.string_types) fuzzy_hex = Fuzzy('^0x[0-9a-fA-F]+$', type=six.string_types) -# Matches password - password consists of all printable characters without whitespaces -# The only exception is space, but space cannot be at the beggingin or end of the pwd +# Matches password - password consists of all printable characters without +# whitespaces. The only exception is space, but space cannot be at the +# beginning or end of the pwd. fuzzy_password = Fuzzy('^\S([\S ]*\S)*$') # Matches generalized time value. Time format is: %Y%m%d%H%M%SZ diff --git a/ipatests/util.py b/ipatests/util.py index 118c47a12e0d97907cb559d716989a9ca6c5f304..796f87cbbfb25028a5135394a0a97a6b1f7180b5 100644 --- a/ipatests/util.py +++ b/ipatests/util.py @@ -205,7 +205,7 @@ class Fuzzy(object): >>> fuzzy.test # doctest:+ELLIPSIS at 0x...> -To aid debugging, `Fuzzy.__repr__()` revealse these kwargs as well: +To aid debugging, `Fuzzy.__repr__()` reveals these kwargs as well: >>> fuzzy # doctest:+ELLIPSIS Fuzzy('.+', , at 0x...>) -- 2.5.5 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH 0003] Fix several small typos
On Wed, 13 Jul 2016, Ben Lipton wrote: Nothing too exciting, just fixes a few typos I've noticed in comments. ACK. However, please file a ticket and mention it in the commit message. -- / Alexander Bokovoy -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [PATCH 0003] Fix several small typos
Nothing too exciting, just fixes a few typos I've noticed in comments. Thanks, Ben From 26d9ba08e06a145fa9d67a039d23c3fdb272b23e Mon Sep 17 00:00:00 2001 From: Ben Lipton Date: Fri, 8 Jul 2016 11:41:43 -0400 Subject: [PATCH] Fix several small typos --- ipatests/test_xmlrpc/tracker/base.py| 2 +- ipatests/test_xmlrpc/tracker/user_plugin.py | 2 +- ipatests/test_xmlrpc/xmlrpc_test.py | 5 +++-- ipatests/util.py| 2 +- 4 files changed, 6 insertions(+), 5 deletions(-) diff --git a/ipatests/test_xmlrpc/tracker/base.py b/ipatests/test_xmlrpc/tracker/base.py index 6a0af510f52aa1d7ccd94450c0848149d9abab48..f7fc55d54b6bcd31308d3eaaea9dffb0228e38bf 100644 --- a/ipatests/test_xmlrpc/tracker/base.py +++ b/ipatests/test_xmlrpc/tracker/base.py @@ -289,5 +289,5 @@ class Tracker(object): set(expected_updates.keys())) def check_update(self, result, extra_keys=()): -"""Check the plugin's `find` command result""" +"""Check the plugin's `mod` command result""" raise NotImplementedError(self._override_me_msg) diff --git a/ipatests/test_xmlrpc/tracker/user_plugin.py b/ipatests/test_xmlrpc/tracker/user_plugin.py index 1a85e93327e5d517249fd67e208e83a922509002..10093a9530dbdd57b53e412ad6c4d4f2e6174fd5 100644 --- a/ipatests/test_xmlrpc/tracker/user_plugin.py +++ b/ipatests/test_xmlrpc/tracker/user_plugin.py @@ -184,7 +184,7 @@ class UserTracker(Tracker): Overriding Tracker method for setting self.attrs correctly; * most attributes stores its value in list * the rest can be overridden by expected_updates - * allow deleting parametrs if update value is None + * allow deleting parameters if update value is None """ if expected_updates is None: expected_updates = {} diff --git a/ipatests/test_xmlrpc/xmlrpc_test.py b/ipatests/test_xmlrpc/xmlrpc_test.py index ddfe9c17c5ca110bc5eb66dead618383b861eda9..78d96388d36f586a3f95c7dffd7a072da43b1f81 100644 --- a/ipatests/test_xmlrpc/xmlrpc_test.py +++ b/ipatests/test_xmlrpc/xmlrpc_test.py @@ -97,8 +97,9 @@ fuzzy_issuer = Fuzzy(type=six.string_types) fuzzy_hex = Fuzzy('^0x[0-9a-fA-F]+$', type=six.string_types) -# Matches password - password consists of all printable characters without whitespaces -# The only exception is space, but space cannot be at the beggingin or end of the pwd +# Matches password - password consists of all printable characters without +# whitespaces. The only exception is space, but space cannot be at the +# beginning or end of the pwd. fuzzy_password = Fuzzy('^\S([\S ]*\S)*$') # Matches generalized time value. Time format is: %Y%m%d%H%M%SZ diff --git a/ipatests/util.py b/ipatests/util.py index 118c47a12e0d97907cb559d716989a9ca6c5f304..796f87cbbfb25028a5135394a0a97a6b1f7180b5 100644 --- a/ipatests/util.py +++ b/ipatests/util.py @@ -205,7 +205,7 @@ class Fuzzy(object): >>> fuzzy.test # doctest:+ELLIPSIS at 0x...> -To aid debugging, `Fuzzy.__repr__()` revealse these kwargs as well: +To aid debugging, `Fuzzy.__repr__()` reveals these kwargs as well: >>> fuzzy # doctest:+ELLIPSIS Fuzzy('.+', , at 0x...>) -- 2.5.5 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code