Re: [Freeipa-devel] [PATCH 0124] ipa-csreplica-manage: remove extraneous ldap2 connection

2016-01-13 Thread Martin Basti 



On 11.01.2016 16:47, Martin Basti wrote:



On 11.01.2016 12:34, Martin Kosek wrote:

On 01/08/2016 06:31 PM, Martin Babinsky wrote:

On 01/08/2016 06:17 PM, Martin Basti wrote:


On 08.01.2016 17:18, Martin Babinsky wrote:

fixes ipa-csreplica-manage del blowing up due

https://fedorahosted.org/freeipa/ticket/5583

for master and ipa-4-3 only.


Give me patch plese!!

Auto-attach plugin would be most welcome.. here's the patch.

Back my developer days, I used this script for sending patches :-)

https://github.com/freeipa/freeipa-tools/blob/master/sendpatch.py

This let me (almost never) forget attaching the file(s) in the right 
format.



ACK


Pushed to:
master: a81e69a796fee2405252838d512e5b950f3be5d8
ipa-4-3: 6ef4bfb7b422af4e487043cdfec88845c3644d6a

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH 0124] ipa-csreplica-manage: remove extraneous ldap2 connection

2016-01-11 Thread Martin Kosek 
On 01/08/2016 06:31 PM, Martin Babinsky wrote:
> On 01/08/2016 06:17 PM, Martin Basti wrote:
>>
>>
>> On 08.01.2016 17:18, Martin Babinsky wrote:
>>> fixes ipa-csreplica-manage del blowing up due
>>>
>>> https://fedorahosted.org/freeipa/ticket/5583
>>>
>>> for master and ipa-4-3 only.
>>>
>> Give me patch plese!!
> 
> Auto-attach plugin would be most welcome.. here's the patch.

Back my developer days, I used this script for sending patches :-)

https://github.com/freeipa/freeipa-tools/blob/master/sendpatch.py

This let me (almost never) forget attaching the file(s) in the right format.

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH 0124] ipa-csreplica-manage: remove extraneous ldap2 connection

2016-01-11 Thread Martin Basti 



On 11.01.2016 12:34, Martin Kosek wrote:

On 01/08/2016 06:31 PM, Martin Babinsky wrote:

On 01/08/2016 06:17 PM, Martin Basti wrote:


On 08.01.2016 17:18, Martin Babinsky wrote:

fixes ipa-csreplica-manage del blowing up due

https://fedorahosted.org/freeipa/ticket/5583

for master and ipa-4-3 only.


Give me patch plese!!

Auto-attach plugin would be most welcome.. here's the patch.

Back my developer days, I used this script for sending patches :-)

https://github.com/freeipa/freeipa-tools/blob/master/sendpatch.py

This let me (almost never) forget attaching the file(s) in the right format.


ACK

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [PATCH 0124] ipa-csreplica-manage: remove extraneous ldap2 connection

2016-01-08 Thread Martin Babinsky 

fixes ipa-csreplica-manage del blowing up due

https://fedorahosted.org/freeipa/ticket/5583

for master and ipa-4-3 only.

--
Martin^3 Babinsky

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH 0124] ipa-csreplica-manage: remove extraneous ldap2 connection

2016-01-08 Thread Martin Babinsky 

On 01/08/2016 06:17 PM, Martin Basti wrote:



On 08.01.2016 17:18, Martin Babinsky wrote:

fixes ipa-csreplica-manage del blowing up due

https://fedorahosted.org/freeipa/ticket/5583

for master and ipa-4-3 only.


Give me patch plese!!


Auto-attach plugin would be most welcome.. here's the patch.

--
Martin^3 Babinsky
From 8c87211d0f51f692999b0393de4b795564b87f8a Mon Sep 17 00:00:00 2001
From: Martin Babinsky 
Date: Thu, 7 Jan 2016 18:09:41 +0100
Subject: [PATCH] ipa-csreplica-manage: remove extraneous ldap2 connection

https://fedorahosted.org/freeipa/ticket/5583
---
 install/tools/ipa-csreplica-manage | 2 --
 1 file changed, 2 deletions(-)

diff --git a/install/tools/ipa-csreplica-manage b/install/tools/ipa-csreplica-manage
index 96f565839362f268ca15aa904f838ef9927fe7b2..f271863b8f8a6addf630bf8d570adf039db64d89 100755
--- a/install/tools/ipa-csreplica-manage
+++ b/install/tools/ipa-csreplica-manage
@@ -285,8 +285,6 @@ def del_master(realm, hostname, options):
 try:
 if bindinstance.dns_container_exists(options.host, api.env.basedn,
  dm_password=options.dirman_passwd):
-api.Backend.ldap2.connect(bind_dn=DN(('cn', 'Directory Manager')),
-  bind_pw=options.dirman_passwd)
 bind = bindinstance.BindInstance()
 bind.remove_ipa_ca_dns_records(hostname, realm.lower())
 except Exception as e:
-- 
2.5.0

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH 0124] ipa-csreplica-manage: remove extraneous ldap2 connection

2016-01-08 Thread Martin Basti 



On 08.01.2016 17:18, Martin Babinsky wrote:

fixes ipa-csreplica-manage del blowing up due

https://fedorahosted.org/freeipa/ticket/5583

for master and ipa-4-3 only.


Give me patch plese!!

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code