Re: [Freeipa-devel] [PATCH 0133] Fix ipactl service ordering
On 08/10/14 20:08, Martin Basti wrote: On 08/10/14 16:59, Martin Basti wrote: IPA sorts service order alphabetically, this patch modify ipactl to use integers. How to reproduce: set attribute ipaConfigString: startOrder 150 DN: cn=HTTP,cn=ipa.example.com,cn=masters,cn=ipa,cn=etc,dc=example,dc=com then run #ipactl restart httpd service should start as last service, but it starts almost first. Patch attached. selfNACK NACKing my SelfNACK, I accidentally installed wrong RPM and I though I haven't fixed it correctly. Patch is OK. -- Martin Basti ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH 0133] Fix ipactl service ordering
On 10/09/2014 12:44 PM, Martin Basti wrote: On 08/10/14 20:08, Martin Basti wrote: On 08/10/14 16:59, Martin Basti wrote: IPA sorts service order alphabetically, this patch modify ipactl to use integers. How to reproduce: set attribute ipaConfigString: startOrder 150 DN: cn=HTTP,cn=ipa.example.com,cn=masters,cn=ipa,cn=etc,dc=example,dc=com then run #ipactl restart httpd service should start as last service, but it starts almost first. Patch attached. selfNACK NACKing my SelfNACK, I accidentally installed wrong RPM and I though I haven't fixed it correctly. Patch is OK. Works for me, ACK. -- David Kupka ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH 0133] Fix ipactl service ordering
On 10/09/2014 12:51 PM, David Kupka wrote: On 10/09/2014 12:44 PM, Martin Basti wrote: On 08/10/14 20:08, Martin Basti wrote: On 08/10/14 16:59, Martin Basti wrote: IPA sorts service order alphabetically, this patch modify ipactl to use integers. How to reproduce: set attribute ipaConfigString: startOrder 150 DN: cn=HTTP,cn=ipa.example.com,cn=masters,cn=ipa,cn=etc,dc=example,dc=com then run #ipactl restart httpd service should start as last service, but it starts almost first. Patch attached. selfNACK NACKing my SelfNACK, I accidentally installed wrong RPM and I though I haven't fixed it correctly. Patch is OK. Works for me, ACK. Pushed to: master: 57c510dcc7a08d908fd55856a735b8dca6684571 ipa-4-1: f74213877a81553bc16c8e050956e742b0b9a5f4 ipa-4-0: 56a146a66627e71fcd927ede7608ed3358cd904c Martin ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
[Freeipa-devel] [PATCH 0133] Fix ipactl service ordering
IPA sorts service order alphabetically, this patch modify ipactl to use
integers.
How to reproduce:
set attribute ipaConfigString: startOrder 150
DN: cn=HTTP,cn=ipa.example.com,cn=masters,cn=ipa,cn=etc,dc=example,dc=com
then run
#ipactl restart
httpd service should start as last service, but it starts almost first.
Patch attached.
--
Martin Basti
From 277e71a1ce05636fd3961276f626335fe9bfbbbe Mon Sep 17 00:00:00 2001
From: Martin Basti mba...@redhat.com
Date: Wed, 8 Oct 2014 16:40:53 +0200
Subject: [PATCH] Fix ipactl service ordering
Ipactl sorted service start order as string, which causes service with start order
100 starts before service with start order 30.
Patch fixes ipactl to use integers for ordering.
---
install/tools/ipactl | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/install/tools/ipactl b/install/tools/ipactl
index 3f0e79867032b61f63e0626ce33df75df14cecab..7a1e41b01a80eeea85c417399dcf4666f70d4b26 100755
--- a/install/tools/ipactl
+++ b/install/tools/ipactl
@@ -159,7 +159,11 @@ def get_config(dirsrv):
name = entry.single_value['cn']
for p in entry['ipaConfigString']:
if p.startswith('startOrder '):
-order = p.split()[1]
+try:
+order = int(p.split()[1])
+except ValueError:
+raise IpactlError(Expected order as integer in: %s:%s % (
+name, p))
svc_list.append([order, name])
ordered_list = []
--
1.8.3.1
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH 0133] Fix ipactl service ordering
On 08/10/14 16:59, Martin Basti wrote: IPA sorts service order alphabetically, this patch modify ipactl to use integers. How to reproduce: set attribute ipaConfigString: startOrder 150 DN: cn=HTTP,cn=ipa.example.com,cn=masters,cn=ipa,cn=etc,dc=example,dc=com then run #ipactl restart httpd service should start as last service, but it starts almost first. Patch attached. selfNACK -- Martin Basti ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
