Re: [Freeipa-devel] [PATCH 0165] --zonemgr options must be unicode
On 18.11.2014 12:43, David Kupka wrote: On 11/18/2014 12:07 PM, Martin Basti wrote: On 13/11/14 18:28, Martin Basti wrote: To allow IDNA zonemgr email, value must be unicode not ASCII Ticket: https://fedorahosted.org/freeipa/ticket/4724 Patch attached. Patch for ipa-4.0 added. Thanks, works for me, ACK. Pushed to: ipa-4-0: ca6958c348edac53c40423679340967749015dd4 ipa-4-1: 53cf615ad87c6a019eca31a924abd035c375c556 master: d2ffd176176e20860998d29ede4e9bd65f398bf2 -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH 0165] --zonemgr options must be unicode
On 13/11/14 18:28, Martin Basti wrote: To allow IDNA zonemgr email, value must be unicode not ASCII Ticket: https://fedorahosted.org/freeipa/ticket/4724 Patch attached. Patch for ipa-4.0 added. -- Martin Basti From 033b2ab8b8d92e92a852eedbd7f7d4a5aea1e92b Mon Sep 17 00:00:00 2001 From: Martin Basti mba...@redhat.com Date: Thu, 13 Nov 2014 18:22:22 +0100 Subject: [PATCH] Fix: zonemgr must be unicode value To support IDNA --zonemgr option must be unicode not ascii https://fedorahosted.org/freeipa/ticket/4724 --- ipaserver/install/bindinstance.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ipaserver/install/bindinstance.py b/ipaserver/install/bindinstance.py index ecaf4e0f92b33b6933e747280986dee7ad44a86d..ae517843695068e5598a4e845f1ba421b11faa08 100644 --- a/ipaserver/install/bindinstance.py +++ b/ipaserver/install/bindinstance.py @@ -22,6 +22,7 @@ import os import pwd import netaddr import re +import sys import time import ldap @@ -403,6 +404,8 @@ def zonemgr_callback(option, opt_str, value, parser): # validate the value first try: +# IDNA support requires unicode +value = value.decode(sys.stdin.encoding) validate_zonemgr_str(value) except ValueError, e: parser.error(invalid zonemgr: + unicode(e)) -- 1.8.3.1 From a90379c83e3e10373e54868402f55e965713236e Mon Sep 17 00:00:00 2001 From: Martin Basti mba...@redhat.com Date: Thu, 13 Nov 2014 18:22:22 +0100 Subject: [PATCH] Fix: zonemgr must be unicode value To support IDNA --zonemgr option must be unicode not ascii https://fedorahosted.org/freeipa/ticket/4724 --- ipaserver/install/bindinstance.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ipaserver/install/bindinstance.py b/ipaserver/install/bindinstance.py index 6cf018e9cda3734a99a8ac5ac1df134e9e4c2293..70e987aa1eb48466c36cae5aadda1aa56f9c34f9 100644 --- a/ipaserver/install/bindinstance.py +++ b/ipaserver/install/bindinstance.py @@ -403,6 +403,8 @@ def zonemgr_callback(option, opt_str, value, parser): # validate the value first try: +# IDNA support requires unicode +value = value.decode(sys.stdin.encoding) validate_zonemgr_str(value) except ValueError, e: parser.error(invalid zonemgr: + unicode(e)) -- 1.8.3.1 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH 0165] --zonemgr options must be unicode
On 11/18/2014 12:07 PM, Martin Basti wrote: On 13/11/14 18:28, Martin Basti wrote: To allow IDNA zonemgr email, value must be unicode not ASCII Ticket: https://fedorahosted.org/freeipa/ticket/4724 Patch attached. Patch for ipa-4.0 added. Thanks, works for me, ACK. -- David Kupka ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
[Freeipa-devel] [PATCH 0165] --zonemgr options must be unicode
To allow IDNA zonemgr email, value must be unicode not ASCII Ticket: https://fedorahosted.org/freeipa/ticket/4724 Patch attached. -- Martin Basti From a90379c83e3e10373e54868402f55e965713236e Mon Sep 17 00:00:00 2001 From: Martin Basti mba...@redhat.com Date: Thu, 13 Nov 2014 18:22:22 +0100 Subject: [PATCH] Fix: zonemgr must be unicode value To support IDNA --zonemgr option must be unicode not ascii https://fedorahosted.org/freeipa/ticket/4724 --- ipaserver/install/bindinstance.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ipaserver/install/bindinstance.py b/ipaserver/install/bindinstance.py index 6cf018e9cda3734a99a8ac5ac1df134e9e4c2293..70e987aa1eb48466c36cae5aadda1aa56f9c34f9 100644 --- a/ipaserver/install/bindinstance.py +++ b/ipaserver/install/bindinstance.py @@ -403,6 +403,8 @@ def zonemgr_callback(option, opt_str, value, parser): # validate the value first try: +# IDNA support requires unicode +value = value.decode(sys.stdin.encoding) validate_zonemgr_str(value) except ValueError, e: parser.error(invalid zonemgr: + unicode(e)) -- 1.8.3.1 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
