Re: [Freeipa-devel] [PATCH 0408] CI DNSSEC: add missing glue record

2016-01-25 Thread Martin Basti 



On 23.01.2016 10:34, Petr Spacek wrote:

On 22.1.2016 17:47, Martin Basti wrote:

-# make BIND happy, and delegate zone which contains A record of master
+# make BIND happy: add the glue record and delegate zone
+args = [
+"ipa", "dnsrecord-add", root_zone, self.master.domain.name,
+"--a-rec=" + self.master.ip
+]
+self.master.run_command(args)
+time.sleep(10)  # sleep a bit until data are provided by 
bind-dyndb-ldap
+

LGTM, ACK. In the worst case it will not fix the test :-)


Pushed to:
ipa-4-3: 47422b0f3913e352cd28cac24128afed178701e8
master: cdf08a0a869f83a6111d9560b69c582d2c04f89c

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH 0408] CI DNSSEC: add missing glue record

2016-01-23 Thread Petr Spacek 
On 22.1.2016 17:47, Martin Basti wrote:
> -# make BIND happy, and delegate zone which contains A record of 
> master
> +# make BIND happy: add the glue record and delegate zone
> +args = [
> +"ipa", "dnsrecord-add", root_zone, self.master.domain.name,
> +"--a-rec=" + self.master.ip
> +]
> +self.master.run_command(args)
> +time.sleep(10)  # sleep a bit until data are provided by 
> bind-dyndb-ldap
> +

LGTM, ACK. In the worst case it will not fix the test :-)

-- 
Petr^2 Spacek

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [PATCH 0408] CI DNSSEC: add missing glue record

2016-01-22 Thread Martin Basti 

Patch attached.
From 15e6c98420c9ffc7b840373910a06f251cca653a Mon Sep 17 00:00:00 2001
From: Martin Basti 
Date: Fri, 22 Jan 2016 14:23:53 +0100
Subject: [PATCH] Fix DNSSEC test: add glue record

Missing glue record causes test failure in cases when DNS zone was not
managed by IPA DNS
---
 ipatests/test_integration/test_dnssec.py | 9 -
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/ipatests/test_integration/test_dnssec.py b/ipatests/test_integration/test_dnssec.py
index 65b1bdaf0e5dd4991b5f4dc1e8173f0fc8ad0537..111d39855b399e52052716cd83da8dfb2213fbee 100644
--- a/ipatests/test_integration/test_dnssec.py
+++ b/ipatests/test_integration/test_dnssec.py
@@ -275,7 +275,14 @@ class TestInstallDNSSECFirst(IntegrationTest):
 ]
 self.master.run_command(args)
 
-# make BIND happy, and delegate zone which contains A record of master
+# make BIND happy: add the glue record and delegate zone
+args = [
+"ipa", "dnsrecord-add", root_zone, self.master.domain.name,
+"--a-rec=" + self.master.ip
+]
+self.master.run_command(args)
+time.sleep(10)  # sleep a bit until data are provided by bind-dyndb-ldap
+
 args = [
 "ipa", "dnsrecord-add", root_zone, self.master.domain.name,
 "--ns-rec=" + self.master.hostname
-- 
2.5.0

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code