Re: [Freeipa-devel] [PATCH 130] Missing DNS tests

2014-10-09 Thread David Kupka 

On 10/01/2014 01:42 PM, Martin Basti wrote:

This patch adds 2 missing DNS tests:
* removing non-existent permission
* removing idnssoamname value using dnszone-mod --name-server=

Patch attached, belongs to ipa-4-1 and master branches.



___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Works for me, ACK.

--
David Kupka

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH 130] Missing DNS tests

2014-10-09 Thread Martin Kosek 
On 10/01/2014 01:42 PM, Martin Basti wrote:
 This patch adds 2 missing DNS tests:
 * removing non-existent permission
 * removing idnssoamname value using dnszone-mod --name-server=
 
 Patch attached, belongs to ipa-4-1 and master branches.

Pushed to:
master: 41015e6c9c5232a741314ba77df082ba7db55620
ipa-4-1: 6d10f98c6b1adae1687738e8240ae78991f48ba3

Martin

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH 130] Missing DNS tests

2014-10-09 Thread Martin Kosek 
On 10/09/2014 09:00 AM, David Kupka wrote:
 On 10/01/2014 01:42 PM, Martin Basti wrote:
 This patch adds 2 missing DNS tests:
 * removing non-existent permission
 * removing idnssoamname value using dnszone-mod --name-server=

 Patch attached, belongs to ipa-4-1 and master branches.



 ___
 Freeipa-devel mailing list
 Freeipa-devel@redhat.com
 https://www.redhat.com/mailman/listinfo/freeipa-devel

 Works for me, ACK.
 

I see I replied to wrong part of the thread :-) So just to repeat:

Pushed to:
master: 41015e6c9c5232a741314ba77df082ba7db55620
ipa-4-1: 6d10f98c6b1adae1687738e8240ae78991f48ba3


Martin

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH 130] Missing DNS tests

2014-10-01 Thread Martin Basti 

This patch adds 2 missing DNS tests:
* removing non-existent permission
* removing idnssoamname value using dnszone-mod --name-server=

Patch attached, belongs to ipa-4-1 and master branches.

--
Martin Basti

From ebaecee49b50e341b3d9e26ecd4722b21dc3ac4a Mon Sep 17 00:00:00 2001
From: Martin Basti mba...@redhat.com
Date: Wed, 1 Oct 2014 13:21:19 +0200
Subject: [PATCH] DNS missing tests

* try to remove non-existent permission
* try to remove idnssoamname using dnszone-mod --name-server=
---
 ipatests/test_xmlrpc/test_dns_plugin.py | 20 
 1 file changed, 20 insertions(+)

diff --git a/ipatests/test_xmlrpc/test_dns_plugin.py b/ipatests/test_xmlrpc/test_dns_plugin.py
index b5df897fcbde509e2fd727c79797fd4e76d6dd61..0f9b16ba7e9c1ff58f0ae0f270172cb610e4f631 100644
--- a/ipatests/test_xmlrpc/test_dns_plugin.py
+++ b/ipatests/test_xmlrpc/test_dns_plugin.py
@@ -507,6 +507,15 @@ class test_dns(Declarative):
 },
 ),
 
+dict(
+desc='Try to remove value of idnssomrname attribute using dnszone-mod --name-server=',
+command=(
+'dnszone_mod', [zone2], {
+'idnssoamname': None,
+}
+),
+expected=errors.ValidationError(name='name_server', error=uis required),
+),
 
 dict(
 desc='Create a zone with upper case name',
@@ -1886,6 +1895,17 @@ class test_dns(Declarative):
  % zone1_permission)
 ),
 
+
+dict(
+desc='Try to remove non-existent per-zone permission for zone %r' % zone1,
+command=(
+'dnszone_remove_permission', [zone1], {}
+),
+expected=errors.NotFound(reason=u'%s: permission not found'
+ % zone1_permission)
+),
+
+
 dict(
 desc='Try to create zone %r with relative nameserver' % zone3,
 command=(
-- 
1.8.3.1

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel