Re: [Freeipa-devel] [PATCHES] Various fixes for trust and range CLI

2012-09-07 Thread Martin Kosek
On Thu, 2012-09-06 at 16:50 +0200, Petr Vobornik wrote:
> On 09/06/2012 01:39 PM, Sumit Bose wrote:
> > Hi,
> >
> > this series of patches touches couple of tickets related to the trust
> > and (id)range CLI. I post them together because some of them depend on
> > each other. I already rebased them on Martin's "Add range safety check
> > for range_mod and range_del" patch which I'm currently reviewing.
> >
> > bye,
> > Sumit
> >
> >
> 
> ACK for the UI changes in patch 60.
> 
> There is a minor issue in ipa_init_objects.json and 
> ipa_init_command.json files: Labels aren't changed so there are still 
> 'Ranges' instead of 'ID ranges'. I don't think it matters because it 
> doesn't affect actual functionality and I will definitely regenerate 
> those files sometime in a future. They are only for developer and 
> related purposes.

Ok, I will leave the UI patch as is, it is ok to have the label
regenerated later.

ACK for the rest of the patches. Pushed them all to master, ipa-3-0.

Martin

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCHES] Various fixes for trust and range CLI

2012-09-06 Thread Petr Vobornik

On 09/06/2012 01:39 PM, Sumit Bose wrote:

Hi,

this series of patches touches couple of tickets related to the trust
and (id)range CLI. I post them together because some of them depend on
each other. I already rebased them on Martin's "Add range safety check
for range_mod and range_del" patch which I'm currently reviewing.

bye,
Sumit




ACK for the UI changes in patch 60.

There is a minor issue in ipa_init_objects.json and 
ipa_init_command.json files: Labels aren't changed so there are still 
'Ranges' instead of 'ID ranges'. I don't think it matters because it 
doesn't affect actual functionality and I will definitely regenerate 
those files sometime in a future. They are only for developer and 
related purposes.

--
Petr Vobornik

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel