Re: [Freeipa-devel] [TEST][PATCH 0019] A proper fix for reverse-zone creation in integration tests

[Martin Basti]

On 18.01.2016 12:51, Oleg Fayans wrote:


On 01/18/2016 10:30 AM, Petr Spacek wrote:

On 14.1.2016 15:05, Oleg Fayans wrote:

Date: Thu, 14 Jan 2016 14:59:37 +0100
Subject: [PATCH] fixed an issue with master installation not creating reverse
  zone

When resolv.conf is set to point to the master's ip before installation, the
ipa-server-install does not create a reverse zone for it's ip even despite
--auto-reverse option provided. The fix is not to mess around with resolv.conf
before master installation.
---
  ipatests/test_integration/tasks.py | 7 ---
  1 file changed, 4 insertions(+), 3 deletions(-)

This is reasonable fix. ACK if it passes your functional tests.

It does :)


Pushed to:
master: 7a742391c1558680900bcb130bbf3fe6790fc573
ipa-4-3: d27d2fd8691f37e9824c8367d7e636523006b5d6

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [TEST][PATCH 0019] A proper fix for reverse-zone creation in integration tests

[Petr Spacek]

On 14.1.2016 15:05, Oleg Fayans wrote:
> Date: Thu, 14 Jan 2016 14:59:37 +0100
> Subject: [PATCH] fixed an issue with master installation not creating reverse
>  zone
> 
> When resolv.conf is set to point to the master's ip before installation, the
> ipa-server-install does not create a reverse zone for it's ip even despite
> --auto-reverse option provided. The fix is not to mess around with resolv.conf
> before master installation.
> ---
>  ipatests/test_integration/tasks.py | 7 ---
>  1 file changed, 4 insertions(+), 3 deletions(-)

This is reasonable fix. ACK if it passes your functional tests.

-- 
Petr^2 Spacek

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [TEST][PATCH 0019] A proper fix for reverse-zone creation in integration tests

[Oleg Fayans]

On 01/18/2016 10:30 AM, Petr Spacek wrote:
> On 14.1.2016 15:05, Oleg Fayans wrote:
>> Date: Thu, 14 Jan 2016 14:59:37 +0100
>> Subject: [PATCH] fixed an issue with master installation not creating reverse
>>  zone
>>
>> When resolv.conf is set to point to the master's ip before installation, the
>> ipa-server-install does not create a reverse zone for it's ip even despite
>> --auto-reverse option provided. The fix is not to mess around with 
>> resolv.conf
>> before master installation.
>> ---
>>  ipatests/test_integration/tasks.py | 7 ---
>>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> This is reasonable fix. ACK if it passes your functional tests.

It does :)

> 

-- 
Oleg Fayans
Quality Engineer
FreeIPA team
RedHat.

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [TEST][PATCH 0019] A proper fix for reverse-zone creation in integration tests

[Oleg Fayans]

-- 
Oleg Fayans
Quality Engineer
FreeIPA team
RedHat.
From 249db32dc5a7ce1e6df826c68f2919c07d953c45 Mon Sep 17 00:00:00 2001
From: Oleg Fayans 
Date: Thu, 14 Jan 2016 14:59:37 +0100
Subject: [PATCH] fixed an issue with master installation not creating reverse
 zone

When resolv.conf is set to point to the master's ip before installation, the
ipa-server-install does not create a reverse zone for it's ip even despite
--auto-reverse option provided. The fix is not to mess around with resolv.conf
before master installation.
---
 ipatests/test_integration/tasks.py | 7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/ipatests/test_integration/tasks.py b/ipatests/test_integration/tasks.py
index 6fdcf9a9019244d0ee5ae9f4d456d72df7c0566e..a1d6cb88a1bfe2ac8c2fae9d758da726a5536ce2 100644
--- a/ipatests/test_integration/tasks.py
+++ b/ipatests/test_integration/tasks.py
@@ -88,11 +88,12 @@ def allow_sync_ptr(host):
  raiseonerr=False)
 
 
-def apply_common_fixes(host):
+def apply_common_fixes(host, fix_resolv=True):
 fix_etc_hosts(host)
 fix_hostname(host)
 modify_nm_resolv_conf_settings(host)
-fix_resolv_conf(host)
+if fix_resolv:
+fix_resolv_conf(host)
 
 
 def backup_file(host, filename):
@@ -264,7 +265,7 @@ def install_master(host, setup_dns=True, setup_kra=False):
 host.collect_log(paths.SLAPD_INSTANCE_ERROR_LOG_TEMPLATE % inst)
 host.collect_log(paths.SLAPD_INSTANCE_ACCESS_LOG_TEMPLATE % inst)
 
-apply_common_fixes(host)
+apply_common_fixes(host, fix_resolv=False)
 fix_apache_semaphores(host)
 
 args = [
-- 
2.4.3

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code