[Freeipa-devel] [freeipa PR#113][comment] ipalib.constants: Remove default domain, realm, basedn, xmlrpc_uri, ldap_uri

2017-02-21 Thread HonzaCholasta
  URL: https://github.com/freeipa/freeipa/pull/113
Title: #113: ipalib.constants: Remove default domain, realm, basedn, 
xmlrpc_uri, ldap_uri

HonzaCholasta commented:
"""
Superseded by #492.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/113#issuecomment-281360258
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#113][comment] ipalib.constants: Remove default domain, realm, basedn, xmlrpc_uri, ldap_uri

2017-01-18 Thread HonzaCholasta
  URL: https://github.com/freeipa/freeipa/pull/113
Title: #113: ipalib.constants: Remove default domain, realm, basedn, 
xmlrpc_uri, ldap_uri

HonzaCholasta commented:
"""
@pvoborni, my plan is to amend / extend this patch.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/113#issuecomment-273696077
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#113][comment] ipalib.constants: Remove default domain, realm, basedn, xmlrpc_uri, ldap_uri

2017-01-18 Thread pvoborni
  URL: https://github.com/freeipa/freeipa/pull/113
Title: #113: ipalib.constants: Remove default domain, realm, basedn, 
xmlrpc_uri, ldap_uri

pvoborni commented:
"""
@HonzaCholasta with @pspacek  no longer caring about this PR, we should close 
it. But before we do it, what are your thoughts on what should be the right 
approach.  Are you going to amend this path or replace it with something 
different?
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/113#issuecomment-273537412
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#113][comment] ipalib.constants: Remove default domain, realm, basedn, xmlrpc_uri, ldap_uri

2017-01-18 Thread tiran
  URL: https://github.com/freeipa/freeipa/pull/113
Title: #113: ipalib.constants: Remove default domain, realm, basedn, 
xmlrpc_uri, ldap_uri

tiran commented:
"""
I would appreciate to have this fix landed in master rather sooner than later. 
The questionable default values have triggered hard to find bugs in one of my 
integration efforts. It took me a while to track them down and find the root 
cause. I wasted half an hour to an hour on the problem.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/113#issuecomment-273436538
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#113][comment] ipalib.constants: Remove default domain, realm, basedn, xmlrpc_uri, ldap_uri

2016-11-24 Thread pspacek
  URL: https://github.com/freeipa/freeipa/pull/113
Title: #113: ipalib.constants: Remove default domain, realm, basedn, 
xmlrpc_uri, ldap_uri

pspacek commented:
"""
Honza will take care of this as part of ipalib cleanup for the Integration 
Improvements project.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/113#issuecomment-262787493
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#113][comment] ipalib.constants: Remove default domain, realm, basedn, xmlrpc_uri, ldap_uri

2016-11-21 Thread jcholast
  URL: https://github.com/freeipa/freeipa/pull/113
Title: #113: ipalib.constants: Remove default domain, realm, basedn, 
xmlrpc_uri, ldap_uri

jcholast commented:
"""
Actually it should be created from domain name, which is the primary identifier 
of an IPA domain, not from realm name.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/113#issuecomment-261875920
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#113][comment] ipalib.constants: Remove default domain, realm, basedn, xmlrpc_uri, ldap_uri

2016-11-16 Thread tiran
  URL: https://github.com/freeipa/freeipa/pull/113
Title: #113: ipalib.constants: Remove default domain, realm, basedn, 
xmlrpc_uri, ldap_uri

tiran commented:
"""
Please create a default basedn from realm with 
```ipapython.ipautil.realm_to_suffix()```.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/113#issuecomment-260919587
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#113][comment] ipalib.constants: Remove default domain, realm, basedn, xmlrpc_uri, ldap_uri

2016-10-06 Thread stlaz
  URL: https://github.com/freeipa/freeipa/pull/113
Title: #113: ipalib.constants: Remove default domain, realm, basedn, 
xmlrpc_uri, ldap_uri

stlaz commented:
"""
NACK, please see the review comment.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/113#issuecomment-251895399
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code