[Freeipa-devel] [freeipa PR#181][comment] Tests : User Tracker creation of user with minimal values
URL: https://github.com/freeipa/freeipa/pull/181 Title: #181: Tests : User Tracker creation of user with minimal values MartinBasti commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/fa7aaef1de2c97ac9d24925ca9adb25c7151055f https://fedorahosted.org/freeipa/changeset/91c050b4e093802d8c6b510a22d6e435faba965f """ See the full comment at https://github.com/freeipa/freeipa/pull/181#issuecomment-273827674 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#181][comment] Tests : User Tracker creation of user with minimal values
URL: https://github.com/freeipa/freeipa/pull/181 Title: #181: Tests : User Tracker creation of user with minimal values MartinBasti commented: """ @gkaihorodova you haven't pushed the changes to github repo ``` git push --force ``` """ See the full comment at https://github.com/freeipa/freeipa/pull/181#issuecomment-273414761 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#181][comment] Tests : User Tracker creation of user with minimal values
URL: https://github.com/freeipa/freeipa/pull/181 Title: #181: Tests : User Tracker creation of user with minimal values gkaihorodova commented: """ @mbasti-rh done. hope now it's fine """ See the full comment at https://github.com/freeipa/freeipa/pull/181#issuecomment-272172666 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#181][comment] Tests : User Tracker creation of user with minimal values
URL: https://github.com/freeipa/freeipa/pull/181 Title: #181: Tests : User Tracker creation of user with minimal values mbasti-rh commented: """ This PR still needs rebase, it is not possible to apply patch without 3way merge, please pull the latest master and do rebase, we merge only patches that can be merged without 3-way merge ``` $ hub am https://github.com/freeipa/freeipa/pull/181 -3 Applying: Unaccessible variable self.attrs in Tracker Using index info to reconstruct a base tree... M ipatests/test_xmlrpc/tracker/base.py Falling back to patching base and 3-way merge... No changes -- Patch already applied. Applying: User Tracker: creation of user with minimal values Using index info to reconstruct a base tree... M ipatests/test_xmlrpc/tracker/user_plugin.py Falling back to patching base and 3-way merge... Auto-merging ipatests/test_xmlrpc/tracker/user_plugin.py Applying: User Tracker: Test to create user with minimal values ``` """ See the full comment at https://github.com/freeipa/freeipa/pull/181#issuecomment-272122000 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#181][comment] Tests : User Tracker creation of user with minimal values
URL: https://github.com/freeipa/freeipa/pull/181 Title: #181: Tests : User Tracker creation of user with minimal values gkaihorodova commented: """ Thank you for review! """ See the full comment at https://github.com/freeipa/freeipa/pull/181#issuecomment-271236642 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#181][comment] Tests : User Tracker creation of user with minimal values
URL: https://github.com/freeipa/freeipa/pull/181 Title: #181: Tests : User Tracker creation of user with minimal values stlaz commented: """ Thank you for the changes! """ See the full comment at https://github.com/freeipa/freeipa/pull/181#issuecomment-271222754 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#181][comment] Tests : User Tracker creation of user with minimal values
URL: https://github.com/freeipa/freeipa/pull/181
Title: #181: Tests : User Tracker creation of user with minimal values
gkaihorodova commented:
"""
Yes, the intention was to have repr() of the given string , so I'll use ''{!r}
instead of '{}', and apply that change to #210 also. Thank you.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/181#issuecomment-270871478
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#181][comment] Tests : User Tracker creation of user with minimal values
URL: https://github.com/freeipa/freeipa/pull/181
Title: #181: Tests : User Tracker creation of user with minimal values
stlaz commented:
"""
The changes introduce different behavior than in the previous change where
repr() of the given strings would have been printed. To have repr() of the
given string, use '{!r}' instead of '{}' in string format if that is what's
desired. CondACK if it's not but please tell :) Same for
https://github.com/freeipa/freeipa/pull/210
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/181#issuecomment-270847597
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#181][comment] Tests : User Tracker creation of user with minimal values
URL: https://github.com/freeipa/freeipa/pull/181 Title: #181: Tests : User Tracker creation of user with minimal values stlaz commented: """ Seems fine + Travis is satisfied as well, ACK. """ See the full comment at https://github.com/freeipa/freeipa/pull/181#issuecomment-270845790 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#181][comment] Tests : User Tracker creation of user with minimal values
URL: https://github.com/freeipa/freeipa/pull/181 Title: #181: Tests : User Tracker creation of user with minimal values stlaz commented: """ Seems fine + Travis is satisfied as well, ACK. """ See the full comment at https://github.com/freeipa/freeipa/pull/181#issuecomment-270845790 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#181][comment] Tests : User Tracker creation of user with minimal values
URL: https://github.com/freeipa/freeipa/pull/181 Title: #181: Tests : User Tracker creation of user with minimal values mbasti-rh commented: """ Then, @stlaz must give final ACK """ See the full comment at https://github.com/freeipa/freeipa/pull/181#issuecomment-270692529 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#181][comment] Tests : User Tracker creation of user with minimal values
URL: https://github.com/freeipa/freeipa/pull/181 Title: #181: Tests : User Tracker creation of user with minimal values gkaihorodova commented: """ will do, but before let me do small changes that was requested by @stlaz in #210, to use str.format() instead of " %r " """ See the full comment at https://github.com/freeipa/freeipa/pull/181#issuecomment-270642709 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#181][comment] Tests : User Tracker creation of user with minimal values
URL: https://github.com/freeipa/freeipa/pull/181 Title: #181: Tests : User Tracker creation of user with minimal values mbasti-rh commented: """ PR needs rebase """ See the full comment at https://github.com/freeipa/freeipa/pull/181#issuecomment-270594446 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#181][comment] Tests : User Tracker creation of user with minimal values
URL: https://github.com/freeipa/freeipa/pull/181 Title: #181: Tests : User Tracker creation of user with minimal values martbab commented: """ Bump for review. """ See the full comment at https://github.com/freeipa/freeipa/pull/181#issuecomment-266416346 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#181][comment] Tests : User Tracker creation of user with minimal values
URL: https://github.com/freeipa/freeipa/pull/181 Title: #181: Tests : User Tracker creation of user with minimal values mirielka commented: """ Please check inline comments. Also suggestion for more test cases: - try to create a user whose automatically generated uid would be too long (>32 characters) - try to create a user whose automatically generated uid would contain invalid characters (other than letters, numbers, _, -, . and $). Also goes for PR #210 """ See the full comment at https://github.com/freeipa/freeipa/pull/181#issuecomment-265110867 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#181][comment] Tests : User Tracker creation of user with minimal values
URL: https://github.com/freeipa/freeipa/pull/181 Title: #181: Tests : User Tracker creation of user with minimal values apophys commented: """ I think in this case we can go with keyword arguments only. Most of the uses of the tracker in the tests do it already. What I will need in the case of keyword arguments is an explicit check for some non-empty unicode string for the required attributes in the __init__ method. All of this applies to `StageUserTracker` in #210 as well """ See the full comment at https://github.com/freeipa/freeipa/pull/181#issuecomment-261940072 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#181][comment] Tests : User Tracker creation of user with minimal values
URL: https://github.com/freeipa/freeipa/pull/181
Title: #181: Tests : User Tracker creation of user with minimal values
mirielka commented:
"""
Having "None" default values for obligatory arguments does not seem to be a
good idea. If the method was called with default values, it would fail. It
would be best if obligatory arguments ("givenname" and "sn") were provided as
positional arguments and voluntary "name" as keyword argument. Please note that
such a change will cause failure of existing tests that use this tracker,
therefore it's necessary to fix them as well - include this in separate commit
of this PR. Also please don't forget to add testcases for which this PR was
created originally - creating user without the "name" argument (both positive
and negative testcases).
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/181#issuecomment-260255613
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#181][comment] Tests : User Tracker creation of user with minimal values
URL: https://github.com/freeipa/freeipa/pull/181 Title: #181: Tests : User Tracker creation of user with minimal values gkaihorodova commented: """ Yes, It's a valid point to add testcases for these changes . Will do. Thank you. """ See the full comment at https://github.com/freeipa/freeipa/pull/181#issuecomment-255976850 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#181][comment] Tests : User Tracker creation of user with minimal values
URL: https://github.com/freeipa/freeipa/pull/181 Title: #181: Tests : User Tracker creation of user with minimal values mirielka commented: """ The same minimal values apply for stageuser-add command, can you please modify the stageuser tracker as well? Also adding testcases for these changes would be nice. """ See the full comment at https://github.com/freeipa/freeipa/pull/181#issuecomment-255951439 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
