[Freeipa-devel] [freeipa PR#347][comment] Improvements in {get|set}_directive functions
URL: https://github.com/freeipa/freeipa/pull/347
Title: #347: Improvements in {get|set}_directive functions
martbab commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/e1ed8b5eff40331ba532d37f3fb08814d8a55b77
https://fedorahosted.org/freeipa/changeset/517d43e78b8d8ea0b796a6ff6a379236eaae21df
https://fedorahosted.org/freeipa/changeset/2831b30e9a9de947481c058d8d32e174f951b1c0
https://fedorahosted.org/freeipa/changeset/86f4a93fb3aeb6742acab5abaa1c17b525ea4223
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/347#issuecomment-275115080
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#347][comment] Improvements in {get|set}_directive functions
URL: https://github.com/freeipa/freeipa/pull/347
Title: #347: Improvements in {get|set}_directive functions
martbab commented:
"""
Thank's, let's hope that all this code will be replaced by some proper
configuration parsing mechanism in the future.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/347#issuecomment-275099477
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#347][comment] Improvements in {get|set}_directive functions
URL: https://github.com/freeipa/freeipa/pull/347
Title: #347: Improvements in {get|set}_directive functions
tomaskrizek commented:
"""
I wasn't able to find any more issues with the quoting of certificate names.
The directive quoting seems to work properly now.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/347#issuecomment-274867155
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#347][comment] Improvements in {get|set}_directive functions
URL: https://github.com/freeipa/freeipa/pull/347
Title: #347: Improvements in {get|set}_directive functions
martbab commented:
"""
Thanks, I have fixed the docstrings. I have also made directive unquoting less
silly.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/347#issuecomment-273194982
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#347][comment] Improvements in {get|set}_directive functions
URL: https://github.com/freeipa/freeipa/pull/347
Title: #347: Improvements in {get|set}_directive functions
tomaskrizek commented:
"""
I still managed to find a an issue for certain edge cases. See inline comments
for more info.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/347#issuecomment-273119920
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#347][comment] Improvements in {get|set}_directive functions
URL: https://github.com/freeipa/freeipa/pull/347
Title: #347: Improvements in {get|set}_directive functions
tomaskrizek commented:
"""
Please see my feedback in in-line comments.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/347#issuecomment-271272632
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#347][comment] Improvements in {get|set}_directive functions
URL: https://github.com/freeipa/freeipa/pull/347
Title: #347: Improvements in {get|set}_directive functions
martbab commented:
"""
Can somebody take over the review of this PR please?
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/347#issuecomment-270072446
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#347][comment] Improvements in {get|set}_directive functions
URL: https://github.com/freeipa/freeipa/pull/347
Title: #347: Improvements in {get|set}_directive functions
martbab commented:
"""
Please see my in-line replies to your in-line comments :).
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/347#issuecomment-268268766
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#347][comment] Improvements in {get|set}_directive functions
URL: https://github.com/freeipa/freeipa/pull/347
Title: #347: Improvements in {get|set}_directive functions
pspacek commented:
"""
Please see my in-line comments.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/347#issuecomment-267899165
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
