[Freeipa-devel] [freeipa PR#532][comment] Fix cookie with Max-Age processing
URL: https://github.com/freeipa/freeipa/pull/532 Title: #532: Fix cookie with Max-Age processing HonzaCholasta commented: """ master: * 24eeb4d6a3be678d652247a4a862ffde037514da Fix cookie with Max-Age processing """ See the full comment at https://github.com/freeipa/freeipa/pull/532#issuecomment-284361733 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#532][comment] Fix cookie with Max-Age processing
URL: https://github.com/freeipa/freeipa/pull/532 Title: #532: Fix cookie with Max-Age processing simo5 commented: """ LGTM, please merge """ See the full comment at https://github.com/freeipa/freeipa/pull/532#issuecomment-284055799 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#532][comment] Fix cookie with Max-Age processing
URL: https://github.com/freeipa/freeipa/pull/532 Title: #532: Fix cookie with Max-Age processing apophys commented: """ Hi, can this PR get little more attention? The issue seems to be a cause for a lot of failures in our integration tests. (I'm not 100% sure though) """ See the full comment at https://github.com/freeipa/freeipa/pull/532#issuecomment-283999510 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#532][comment] Fix cookie with Max-Age processing
URL: https://github.com/freeipa/freeipa/pull/532 Title: #532: Fix cookie with Max-Age processing simo5 commented: """ Ok, sorry for some reason I thought this was on the server side, where we do not care what the cookie looks like, but on the client side we indeed care. """ See the full comment at https://github.com/freeipa/freeipa/pull/532#issuecomment-283666136 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#532][comment] Fix cookie with Max-Age processing
URL: https://github.com/freeipa/freeipa/pull/532 Title: #532: Fix cookie with Max-Age processing stlaz commented: """ If I read the code well, in a well-set-up cookie, during `store_session_cookie()` when `Cookie.get_named_cookie_from_string()` is called, the expiration gets normalized which basically means removing the `Max-Age` attribute and replacing it with the `Expires` attribute in the cookie string (see `Cookie.normalize_expiration()` and `Cookie.__str__()`). When later retrieving the cookie, it should not have the `Max-Age` attribute anymore but only `Expires`. Therefore we need to calculate it or change the way `normalize_expiration()` behaves. """ See the full comment at https://github.com/freeipa/freeipa/pull/532#issuecomment-283665210 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#532][comment] Fix cookie with Max-Age processing
URL: https://github.com/freeipa/freeipa/pull/532 Title: #532: Fix cookie with Max-Age processing simo5 commented: """ Do we really care for calculating the expiration time ? Should we just set timestamp to 0 or even remove the whole thing ? """ See the full comment at https://github.com/freeipa/freeipa/pull/532#issuecomment-283658705 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
