[Freeipa-devel] [freeipa PR#548][comment] ipa-server-install: add --setup-kra option
URL: https://github.com/freeipa/freeipa/pull/548 Title: #548: ipa-server-install: add --setup-kra option dkupka commented: """ master: * 4006cbbc02c368ac9e5e3721613158decb34fd37 KRA: add --setup-kra to ipa-server-install * 25fa2bb6c9fa1b498330b13c9a6116b646eb75ba tests: use --setup-kra in tests """ See the full comment at https://github.com/freeipa/freeipa/pull/548#issuecomment-285061152 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#548][comment] ipa-server-install: add --setup-kra option
URL: https://github.com/freeipa/freeipa/pull/548 Title: #548: ipa-server-install: add --setup-kra option MartinBasti commented: """ Given that there is no time, I dropped commit you NACKed as it unneeded for this PR, but please note my disagreement about a way how `kra.py` handles `--setup-kra` option for the future release. """ See the full comment at https://github.com/freeipa/freeipa/pull/548#issuecomment-285020252 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#548][comment] ipa-server-install: add --setup-kra option
URL: https://github.com/freeipa/freeipa/pull/548 Title: #548: ipa-server-install: add --setup-kra option HonzaCholasta commented: """ NACK on the "KRA: run install and install_check only when KRA should be installed" commit. The end goal for all component installers is to make them isolated and handle their options themselves, so that they can be packaged separately (among other things). This commit takes the code in the opposite direction. Also it does not make the code more readable because it is inconsistent with the CA installer. """ See the full comment at https://github.com/freeipa/freeipa/pull/548#issuecomment-284983950 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code