[Freeipa-devel] [freeipa PR#73][comment] Tests for certificates with SAN
URL: https://github.com/freeipa/freeipa/pull/73 Title: #73: Tests for certificates with SAN martbab commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/4f8e212c428b1fff63f38ea15d7ce9f230085c5c https://fedorahosted.org/freeipa/changeset/7eb78aa8dbc167c36869ddd6cfa525139aff7bbc https://fedorahosted.org/freeipa/changeset/10b4b155b6b411ab339bce92c1a335b4914cfc1c ipa-4-4: https://fedorahosted.org/freeipa/changeset/e607bd000b1593f6824ccc9ca8862eec43c442bb https://fedorahosted.org/freeipa/changeset/3fd233458bc7976790d48374c48d48f27596536e https://fedorahosted.org/freeipa/changeset/5d75842017a917ac7769e5c837bfffa1ba0e1c74 """ See the full comment at https://github.com/freeipa/freeipa/pull/73#issuecomment-251433037 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#73][comment] Tests for certificates with SAN
URL: https://github.com/freeipa/freeipa/pull/73 Title: #73: Tests for certificates with SAN apophys commented: """ I have fixed typos and implemented the proposed test cases. I have also provided docstring to the change_principal context manager. """ See the full comment at https://github.com/freeipa/freeipa/pull/73#issuecomment-250461484 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#73][comment] Tests for certificates with SAN
URL: https://github.com/freeipa/freeipa/pull/73 Title: #73: Tests for certificates with SAN martbab commented: """ NACK: you probably forgot to add service fixtures as params to the added test cases: https://paste.fedoraproject.org/437721/51355181/ In addition please write sensible commit message to commit f43833d and probably squash the last commit into 2d75883 I have also noticed that you linked the commits to a ticket in a already closed milestone. Per our process guidelines you need to open a new ticket and go through a new triage, sorry. """ See the full comment at https://github.com/freeipa/freeipa/pull/73#issuecomment-250397011 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
