Re: [Freeipa-devel] Minor error: format not a string literal and no format arguments [-Werror=format-security]

2013-06-03 Thread Martin Kosek 
On 06/02/2013 06:48 AM, Diane Trout wrote:
> I wasn't subscribed to the list before, so here's the git formatted patch you 
> were asking for.
> 
> Diane

Sumit already ACKed the patch, I pushed it to master and ipa-3-2 branches.

Thanks for the patch. We appreciate efforts in making FreeIPA available in
other platforms, patches welcome.

Martin

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] Minor error: format not a string literal and no format arguments [-Werror=format-security]

2013-06-01 Thread Diane Trout 
I wasn't subscribed to the list before, so here's the git formatted patch you 
were asking for.

Diane>From 9d03964afbbbf6c7f45c99e8c4da4183f05cd949 Mon Sep 17 00:00:00 2001
From: Diane Trout 
Date: Sat, 1 Jun 2013 21:44:35 -0700
Subject: [PATCH] Fix log format not a string literal.

This was to resolve a -Werror=format-security error.

  ipa_extdom_extop.c: In function 'ipa_extdom_extop':
  ipa_extdom_extop.c:144:9: error: format not a string literal and no format
arguments [-Werror=format-security]
---
 daemons/ipa-slapi-plugins/ipa-extdom-extop/ipa_extdom_extop.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/daemons/ipa-slapi-plugins/ipa-extdom-extop/ipa_extdom_extop.c b/daemons/ipa-slapi-plugins/ipa-extdom-extop/ipa_extdom_extop.c
index f36878c..37a4b1d 100644
--- a/daemons/ipa-slapi-plugins/ipa-extdom-extop/ipa_extdom_extop.c
+++ b/daemons/ipa-slapi-plugins/ipa-extdom-extop/ipa_extdom_extop.c
@@ -141,7 +141,7 @@ done:
 free(req);
 free(res);
 if (err_msg != NULL) {
-LOG(err_msg);
+LOG("%s", err_msg);
 }
 slapi_send_ldap_result(pb, rc, NULL, err_msg, 0, NULL);
 return SLAPI_PLUGIN_EXTENDED_SENT_RESULT;
-- 
1.7.10.4

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] Minor error: format not a string literal and no format arguments [-Werror=format-security]

2013-05-30 Thread Sumit Bose 
On Wed, May 29, 2013 at 11:26:17PM -0700, Diane Trout wrote:
> Hi,
> 
> I was trying to compile freeipa on debian and the compiler threw a minor 
> error. 
> 
>   Resolve a -Werror=format-security error.
> 
>   ipa_extdom_extop.c: In function 'ipa_extdom_extop':
>   ipa_extdom_extop.c:144:9: error: format not a string literal and no format 
> arguments [-Werror=format-security]
> 
> --- a/daemons/ipa-slapi-plugins/ipa-extdom-extop/ipa_extdom_extop.c
> +++ b/daemons/ipa-slapi-plugins/ipa-extdom-extop/ipa_extdom_extop.c
> @@ -141,7 +141,7 @@
>  free(req);
>  free(res);
>  if (err_msg != NULL) {
> -LOG(err_msg);
> +LOG("%s", err_msg);
>  }
>  slapi_send_ldap_result(pb, rc, NULL, err_msg, 0, NULL);
>  return SLAPI_PLUGIN_EXTENDED_SENT_RESULT;

This is obviously correct, ACK.

Do you have a chance to resent the patch as a git formatted one? If not,
I can prepare one for you and resent it.

bye,
Sumit
> 
> ___
> Freeipa-devel mailing list
> Freeipa-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] Minor error: format not a string literal and no format arguments [-Werror=format-security]

2013-05-30 Thread Diane Trout 
Hi,

I was trying to compile freeipa on debian and the compiler threw a minor 
error. 

  Resolve a -Werror=format-security error.

  ipa_extdom_extop.c: In function 'ipa_extdom_extop':
  ipa_extdom_extop.c:144:9: error: format not a string literal and no format 
arguments [-Werror=format-security]

--- a/daemons/ipa-slapi-plugins/ipa-extdom-extop/ipa_extdom_extop.c
+++ b/daemons/ipa-slapi-plugins/ipa-extdom-extop/ipa_extdom_extop.c
@@ -141,7 +141,7 @@
 free(req);
 free(res);
 if (err_msg != NULL) {
-LOG(err_msg);
+LOG("%s", err_msg);
 }
 slapi_send_ldap_result(pb, rc, NULL, err_msg, 0, NULL);
 return SLAPI_PLUGIN_EXTENDED_SENT_RESULT;

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel