Re: [Freeipa-devel] [PATCH] Improve developers RPM builds
On Tue, 18 Nov 2014 21:46:00 +0100 Martin Kosek wrote: > On 11/18/2014 09:25 PM, Simo Sorce wrote: > > On Tue, 18 Nov 2014 11:25:19 -0500 > > Nathaniel McCallum wrote: > > > >> On Mon, 2014-11-17 at 23:42 -0500, Simo Sorce wrote: > >>> This small patch will add a date component to the ipa version when > >>> building straight from git. > >>> > >>> This way successive builds will clearly install on top of a > >>> previous one even if alphabetically the git commit id has gone > >>> backwards. > >>> > >>> It also gives a chance of remembering what/when you had installed > >>> on older VMs at a simply rpm -qi glance. > >> > >> ACK > >> > >> And thank you! This has been bugging me. > >> > >> Nathaniel > >> > > > > I added your reviewed-by and pushed it to master. > > > > Do people want to push it to other branches ? > > > > Simo. > > > > It should be harmless for release builds and should help development > builds. So +1 for adding to all actively developed branches, i.e. > ipa-4-1 and ipa-4-0. Ok, pushed there too. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] Improve developers RPM builds
On 11/18/2014 09:25 PM, Simo Sorce wrote: On Tue, 18 Nov 2014 11:25:19 -0500 Nathaniel McCallum wrote: On Mon, 2014-11-17 at 23:42 -0500, Simo Sorce wrote: This small patch will add a date component to the ipa version when building straight from git. This way successive builds will clearly install on top of a previous one even if alphabetically the git commit id has gone backwards. It also gives a chance of remembering what/when you had installed on older VMs at a simply rpm -qi glance. ACK And thank you! This has been bugging me. Nathaniel I added your reviewed-by and pushed it to master. Do people want to push it to other branches ? Simo. It should be harmless for release builds and should help development builds. So +1 for adding to all actively developed branches, i.e. ipa-4-1 and ipa-4-0. Thanks, Martin ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] Improve developers RPM builds
On Tue, 18 Nov 2014 11:25:19 -0500 Nathaniel McCallum wrote: > On Mon, 2014-11-17 at 23:42 -0500, Simo Sorce wrote: > > This small patch will add a date component to the ipa version when > > building straight from git. > > > > This way successive builds will clearly install on top of a previous > > one even if alphabetically the git commit id has gone backwards. > > > > It also gives a chance of remembering what/when you had installed on > > older VMs at a simply rpm -qi glance. > > ACK > > And thank you! This has been bugging me. > > Nathaniel > I added your reviewed-by and pushed it to master. Do people want to push it to other branches ? Simo. -- Simo Sorce * Red Hat, Inc * New York ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] Improve developers RPM builds
On Mon, 2014-11-17 at 23:42 -0500, Simo Sorce wrote: > This small patch will add a date component to the ipa version when > building straight from git. > > This way successive builds will clearly install on top of a previous > one even if alphabetically the git commit id has gone backwards. > > It also gives a chance of remembering what/when you had installed on > older VMs at a simply rpm -qi glance. ACK And thank you! This has been bugging me. Nathaniel ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
