Re: Change of logging behaviour in 2.1.9

2010-06-20 Thread Alan DeKok
Jakob Hirsch wrote:
> But it was already re-opening the log file for every log write,
> obviously, so I don't see, why that was necessary.

  The bug was that it wasn't re-opening the log file on HUP.  That
needed to be fixed.

  Alan DeKok.
-
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html


Re: Change of logging behaviour in 2.1.9

2010-06-19 Thread Jakob Hirsch
On 18.06.2010 17:48, Alan DeKok wrote:

>> I just wonder why there is such a change in a patch level update. And
>> what the above mentioned bug was about...
>   The bug was that it *wasn't* re-opening the log file on HUP.  Since
> this is expected behavior, it needed to be fixed.

But it was already re-opening the log file for every log write,
obviously, so I don't see, why that was necessary.
-
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html


Re: Change of logging behaviour in 2.1.9

2010-06-18 Thread Alan DeKok
Jakob Hirsch wrote:
> I just wonder why there is such a change in a patch level update. And
> what the above mentioned bug was about...

  The bug was that it *wasn't* re-opening the log file on HUP.  Since
this is expected behavior, it needed to be fixed.

  Alan DeKok.
-
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html


Re: Change of logging behaviour in 2.1.9

2010-06-18 Thread Jakob Hirsch
Bjørn Mork, 2010-06-17 18:28:

>>>   * re-open log file after HUP.  Closes bug #63.
> FWIW we have been HUPing the server from a daily, unattended process
> with FR 2.1.8 since it was released (we need it to rotate log files

Ok. That's what we are doing now, too. After all, other daemons (apache,
rsyslogd etc.) are doing the same all the time.

I just wonder why there is such a change in a patch level update. And
what the above mentioned bug was about...

-
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html

Re: Change of logging behaviour in 2.1.9

2010-06-18 Thread Alan DeKok
Jakob Hirsch wrote:
> Since the update to 2.1.9 a new log file is _only_ opened on HUP. Is
> this behaviour intended?

  Yes.  It's the way most daemons work.

> Is the only possibility to reopen the log file now to send HUP to the
> server? I don't feel very comfortable with this. The server reloads the
> config, modules and whatnot. I think this is not something that one
> wants to do in a daily, unattended process. Isn't there any other, less
> intrusive method to tell freeradius to reopen the log file? (besides a
> restart, of course)

  Source code patches.

  Alan DeKok.
-
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html


Re: Change of logging behaviour in 2.1.9

2010-06-17 Thread Bjørn Mork
Jakob Hirsch  writes:

> Hi,
>
> Alan DeKok, 2010-05-24 12:28:
>>   * re-open log file after HUP.  Closes bug #63.
>
> Since the update to 2.1.9 a new log file is _only_ opened on HUP. Is
> this behaviour intended?
> Previously we just let logrotate rename the old logfile and freeradius
> created a new radius.log. I'm aware that it is not very efficient to do
> open/write/close all the time, but it just worked [tm].
>
> Is the only possibility to reopen the log file now to send HUP to the
> server? I don't feel very comfortable with this. The server reloads the
> config, modules and whatnot. I think this is not something that one
> wants to do in a daily, unattended process. Isn't there any other, less
> intrusive method to tell freeradius to reopen the log file? (besides a
> restart, of course)

FWIW we have been HUPing the server from a daily, unattended process
with FR 2.1.8 since it was released (we need it to rotate log files
written by a private accounting module we are using). The server will
only reload the modules that are explicitly marked as OK with that.  And
it all works very well. 



Bjørn

-
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html

Change of logging behaviour in 2.1.9 (was: Version 2.1.9 has been released)

2010-06-17 Thread Jakob Hirsch
Hi,

Alan DeKok, 2010-05-24 12:28:
>   * re-open log file after HUP.  Closes bug #63.

Since the update to 2.1.9 a new log file is _only_ opened on HUP. Is
this behaviour intended?
Previously we just let logrotate rename the old logfile and freeradius
created a new radius.log. I'm aware that it is not very efficient to do
open/write/close all the time, but it just worked [tm].

Is the only possibility to reopen the log file now to send HUP to the
server? I don't feel very comfortable with this. The server reloads the
config, modules and whatnot. I think this is not something that one
wants to do in a daily, unattended process. Isn't there any other, less
intrusive method to tell freeradius to reopen the log file? (besides a
restart, of course)


Regards,
Jakob
-
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html